Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote_type is not supposed to be overloaded #67

Open
nsajko opened this issue Apr 18, 2024 · 1 comment · May be fixed by #70
Open

promote_type is not supposed to be overloaded #67

nsajko opened this issue Apr 18, 2024 · 1 comment · May be fixed by #70

Comments

@nsajko
Copy link

nsajko commented Apr 18, 2024

Several methods are added for promote_type in src/libarb/promote.jl. Xref JuliaLang/julia#54138
@JeffreySarnoff
Copy link
Owner

This was intentional. At the time it was written, this approach worked best. It may well be that over time, as Julia evolved, it is no longer needed.

@lgoettgens lgoettgens linked a pull request Jun 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace all methods of promote_type by promote_rule lgoettgens/ArbNumerics.jl
2 participants
@JeffreySarnoff @nsajko