Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed references to Cintin ArbComplex.jl #64

Merged
merged 3 commits into from
Oct 30, 2023
Merged

removed references to Cintin ArbComplex.jl #64

merged 3 commits into from
Oct 30, 2023

Conversation

KlausC
Copy link
Collaborator

@KlausC KlausC commented Oct 26, 2023

Solves Issue #34.
The C-library is using type Int64 to pass integers in general.
A call to acb_set_round did provide a rounding mode argument, which is not needed (used).

@KlausC
Copy link
Collaborator Author

KlausC commented Oct 27, 2023

@JeffreySarnoff what do you think? This PR requires your workflow approval in order to run the test jobs.

@JeffreySarnoff
Copy link
Owner

thank you

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/libarb/ArbComplex.jl 17.90% <66.66%> (-1.41%) ⬇️

📢 Thoughts on this report? Let us know!.

@KlausC
Copy link
Collaborator Author

KlausC commented Oct 29, 2023

Would you mind to allow me to run those jobs. I would also like to improve test coverage in a separate PR, once this one is finished.

@JeffreySarnoff
Copy link
Owner

JeffreySarnoff commented Oct 30, 2023 via email

@JeffreySarnoff JeffreySarnoff merged commit 68093b3 into JeffreySarnoff:main Oct 30, 2023
2 checks passed
@KlausC KlausC deleted the krc/complex_constructors branch October 30, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants