Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape commas in std::vector<std::string> JOmnifactory parameters #380

Open
ruse-traveler opened this issue Nov 7, 2024 · 2 comments
Open

Comments

@ruse-traveler
Copy link

I recently encountered an issue working on EICrecon that seems to be related to JANA2 parsing std::vector<std::string> parameters of a JOmnifactory...

To resolve eic/EICrecon#1669, I modified an algorithm (see here) to accept a vector of expressions stored as strings with the intent of providing a way to map one set of readout indices onto another. For example:

phi-fmod(phi,5)

However, the expression that gets passed to the algorithm is:

phi-fmod(phi

This seems to be JANA2 splitting on the , in the expression. Would it be possible to escape commas in strings (maybe like fmod(phi\,5)) so that the string is passed to the algorithm as a whole?

@nathanwbrei
Copy link
Collaborator

I agree it would be great to support this feature. I'll add it to the roadmap for the next release.

@ruse-traveler
Copy link
Author

🙌 🙌 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants