feature: "Only show active spaces" #32
Open
+20
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…space numbers from showing on the menubar display
|
Is there any chance that this pull request will be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented "Only show active spaces" as a option in preferences which will hide all non-active space numbers from showing on the menubar display.
This button gets auto-disabled when the "Rectangles" style is selected since it would just end up showing a singular rectangle for each monitor that does not convey any information.
I primarily wrote this change since the notch on Apple Silicon iterations of the MacBook Pro means that there is very limited menu bar icon real estate that the inactive desktop numbers/icons would potentially completely cover if they can even fit on the menu bar in the first place (in the case of having many virtual desktops open).
This PR would address #14, #23
Screenshots
Note: the virtual desktop configuration I have in these screenshots is 9 virtual desktops on the left monitor and one on the right monitor. In addition to this, I have the JankyBorders app active so ignore the blue border around the preference window.
Previous behavior (disabling newly-added checkbox "Only show active spaces")
New behavior
Disabled when "Rectangles" style is chosen