Enable setting a color for the non-home keys. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wanted to better be able to see the rest of the keys in low light. I tried to pick a light white/gray that didn't overwhelm the home keys but was still visible.
|
@asutherland Thanks for the submittion. I've been a bit otherwise occupied the past few days and haven't had a chance to reply. I'll take a look at this in the next few days and merge it in. Conceptually I like the idea. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to better be able to see the rest of the keys in low light.
I tried to pick a light white/gray that didn't overwhelm the home
keys but was still visible.
Thanks very much for this extension! I made these changes for my own benefit, they might not fit with your vision, but I figured I'd let you make the call.