Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General tweaks, fixes/tests, and research #5

Open
8 of 11 tasks
Janne252 opened this issue Jan 13, 2022 · 0 comments
Open
8 of 11 tasks

General tweaks, fixes/tests, and research #5

Janne252 opened this issue Jan 13, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@Janne252
Copy link
Owner

Janne252 commented Jan 13, 2022

  • Destroyed event label for entities
  • Does cancelling an emplacemet construction trigger a death event?
    • Yes, some emplacements are squad based
  • Add unit tests for off-map airstrikes
    • Both the kind that display XP kickers (player-owned weapon?), e.g. Stuka Fragmentation bombs, and the kind that don't, e.g. Stuka dive bomb
  • Add unit test for goliath caused death (goliath death should filter out as expected)
  • Experiment with somehow indicating time since event to more easily differentiate between new and old events
  • Research on how to encode 2-byte characters via lua strings, e.g. unicode symbols
    • This could be used to display "ascii" progress bars and veterancy rank starts
  • is_abandoned may remain for US Forces vehicles until death if squad ID is retained trough disembark -> re-crew
  • Vehicle crew death (triggered by vehicle death) may have a weird position - see if the vehicle's position or last known position could be used instead? Or just ignore all vehicle crew deaths due to the crew being something worth to report is very unlikely.
  • Remove previous event indicators of an entity, e.g. when an AT-gun gets de-crewed multiple times within the event display duration time
  • Raketenwerfer event doesn't have event type suffix?
    image
    • Other events during the same https://www.youtube.com/watch?v=oWHarpRdWtg cast had event type suffix. Additionally a volksgrenadier death was later also reported without event type suffix. Is there something weird going on with screen_name_short values? At 22:15 a Panzer IV death was titled as "Panzer". Yet again no suffix and seemingly truncated unit name?
      image
      Later Raketen werfer successfully rendered when owned by a different player.
    • Likely caused by the $ in the player name
@Janne252 Janne252 added the enhancement New feature or request label Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant