Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP files aren't synchronized on game start/stop #17

Open
kwaiette opened this issue Feb 13, 2019 · 8 comments
Open

PSP files aren't synchronized on game start/stop #17

kwaiette opened this issue Feb 13, 2019 · 8 comments

Comments

@kwaiette
Copy link

PPSSPP saves don't use the standard <ROM_NAME>.* so the filter doesn't catch them.

@Dannflower
Copy link

@kwaiette Just a heads up that I am working on a solution to this. I'm currently adding some functionality that will allow us to adjust the filters/save locations on a per emulator basis. So, this should also cover the case where an emulator, such as ppsspp (as opposed to lr-ppsspp) isn't subject to retroarch.cfg files telling it where to put its save files.

I'll open a PR on this repo, but I'll also be merging it into my fork.

@Dannflower
Copy link

@kwaiette If you're interested, I've got a branch open in my repo that's at a point it could use some testing on a setup other than mine. See this branch: https://github.com/Dannflower/rclone_script/tree/psp-save-support

Before trying anything, make sure you have all of your saves backed up.

To use the changes, you can either do a fresh install from the branch I linked (preferable for testing) or just replace all of your rclone scripts with the ones in my branch.

Once you've done that, the file of interest to you will be emulator_settings.xml in the rclone_script directory. In it you'll see that I've created a preset for the lr-ppsspp emulator to show how to structure the xml. Here you can add file extensions for saves/states on a per emulator basis. Any files in that system's save folder with those extensions will be sync'ed. Any emulator not define in the xml will use the normal logic of <ROM_name>.* to look for save files.

The saveFilePath and saveStatePath elements in the xml can be ignored for now. I'm working on adding these paths as overrides for the default save location so that saves from emulators like ppsspp can be found and sync'ed. Additionally I think I am going to add a toggle to disable save state uploads as well, because for some systems, like the psp, these files are very large to upload/download especially if there are many of them.

Let me know if you give it a shot and how it goes!

@kwaiette
Copy link
Author

Got it installed using the installer script, I'll run some tests with various save states tomorrow.

@kwaiette
Copy link
Author

kwaiette commented Apr 1, 2019

Just an update on where I'm at on testing, it appears to be copying everything to the cloud and downloading it just fine. I tried loading up the save games / states on my phone but lr-ppsspp in RetroArch crashes and the stand-alone ppsspp app says it's the wrong version. I haven't had time to troubleshoot that yet, but as far as I can tell the savegame sync is working for PSP games on my RetroPie.

@Dannflower
Copy link

Hm, that's odd. I plan to return to this script over the weekend to adjust it to support a save state sync toggle, so if you've found out any more about the issue let me know. I'll try loading my saves into an lr-ppsspp instance not on my Retropie and see if I get the same issue.

Thanks for taking the time to test this out!

@Dannflower
Copy link

Dannflower commented Apr 11, 2019

Just a quick update: I went ahead and opened a PR here but also merged into master on my fork. I've added support for custom save file paths to support emulators that do not adhere to the retroarch.cfg files. As with save file extensions, this can be set in the emulator_settings.xml.

Keep in mind that emulators for the same system will SHARE THE SAME REMOTE FOLDER. This means that if you currently have different saves for the same game in the two different save locations (say 1 save for lr-ppsspp and one save for ppsspp) there is the potential for conflict which could result in an overwritten save file when switching between emulators. Barring any pre-existing conflicts, this shouldn't be a huge issue unless you frequently switch emulators for the same system without first synchronizing their save folders. As long as you sync the saves for the emulators you were using and then switch emulators everything should work fine.

I didn't get around to adding the save state upload toggle, but I figured my goal here was to get PSP (and any other emulator using complex saves) to synchronize and it was in good enough shape to be useful and merge. For now, if you want to prevent save states from being uploaded remove the "state" extension from the xml.

As for your issue with the "wrong version" error, I was not running into this though I may not have tested it the way you were. My saves seemed to transfer fine between both lr-ppsspp and the normal ppsspp emulator within Retropie.

Hope this is what you were looking for and let me know if you run into any issues.

@Questinghero
Copy link

I installed lr-ppsspp core AFTER installing the script. Do I need to do a full sync or reinstall the script to get the PSP saves to start syncing? I am new to all of this, I installed the script for the first time this past week, so I should be up to date on the script revision.

@Questinghero
Copy link

Update, re-running the script fixed everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants