Improvement for creating runcommand-on*.sh

[parker-hemphill]

You could use the following commands instead of printf:

echo -e '#!/bin/bash\n~/scripts/rclone_script/rclone_script.sh "down" "$1" "$2" "$3" "$4"\n' >>

and

echo -e '#!/bin/bash\n~/scripts/rclone_script/rclone_script.sh "up" "$1" "$2" "$3" "$4"\n' >>

You could also use printf like you were but you need to single quote the input to escape the ! in the shebang. I'd also recommend adding

chmod +x /opt/retropie/configs/all/runcommand-onstart.sh
and
chmod +x /opt/retropie/configs/all/runcommand-onend.sh after the file is created if it doesn't exist