Don't assume Google Chrome is the default browser #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without using '-a <browser>', the 'open' command just uses the user's default browser. This may not be the case, and if it's not, it breaks the preview workflow when using 'g:vim_markdown_preview_browser="Google Chrome"'.
zhimsel
added a commit
to zhimsel/dotfiles
that referenced
this pull request
Mar 18, 2019
For Vim_Markdown_Preview(), the file is saved to `/tmp/`. Whoops!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without using
-a <browser>, theopencommand just uses the user'sdefault browser. This may not be the case, and if it's not, it breaks
the preview workflow when
g:vim_markdown_preview_browser="Google Chrome"is set.For example, say the user's default browser is set to Firefox. If the user's vimrc has
g:vim_markdown_preview_browser="Google Chrome"set, the included applescripts will search Chrome for an already-open preview tab. If it doesn't find one, it'll open the preview in Firefox instead.