-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opens new tab when called on Ubuntu 16 with firefox #68
Comments
We still need to add Firefox as a supported browser. If you are on linux, |
Calling xdotool by hand using the way you pointed doesn't cause anything to happen (I was inside the folder with the markdown-preview.html. I have installed chrome and I still get a new tab when using . Addionally, both in chrome and firefox my code blocks and bullet points don't render (they appear raw, as typed in the document). |
The issue is that xdotool does not find the browser window that already displays the html file because it searches for the wrong title. I implemented a workaround by setting the html title when creating the html and make xdotool explicitely search for it when updating/displaying the html. Check out the fork here. I can submit a PR if it works for you. Remember to set HTH :)! |
@pylipp a PR for firefox would be great! |
@pylipp How can I test your version of the plugin using Vundle? I copied |
@pylipp Thanks! |
Mmh a hack I can think of is to leave your vimrc untouched and go to the plugin directory instead (something like
Then you should be on the correct branch. However, this is probably going to be overwritten when you update the original plugin from within vim. |
Dear friends, Problem Solved, I missed the following setting:
Many thanks! Dear friends, Although I've installed
the plug-in, yet, doesn't work. I am a bit frustrated. Could you be kind to lend me a hand? Any tip are highly appreciated.
|
@pylipp I also did not manage to use firefox with your modifications. In my init.vim I have
|
Can you specify the system you are running? |
Are you using NeoVim? I never tested the plugin or the firefox-branch there. Maybe that's an issue. |
@pylipp One thing before I will answer. To which project exactly do you refer by |
|
I think this also requires a
And maybe setting the environment variable |
@pylipp Well, but this is a Debian related package, and as I see it is an alias on I set the |
Regarding the new tab being opened: Did the browser tab displaying the preview lose focus between two calls to If you don't want to use xdg-open or mailcap, you could hardcode the browser executable in the source code. |
I was able to get tabs refreshing on Ubuntu 16 with firefox with the following steps:
|
@DmitrySandalov Thanks for investigating :) What version of firefox are you using? I think that makes a difference in how Firefox builds the tab title. |
@DmitrySandalov |
I have firefox as the standard browser (it is what came installed in the distro), and whenever I do a new tab opens. How can I fix this?
The text was updated successfully, but these errors were encountered: