Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conform to standard code style guide #29

Open
JamesLongman opened this issue Mar 5, 2018 · 1 comment
Open

Conform to standard code style guide #29

JamesLongman opened this issue Mar 5, 2018 · 1 comment

Comments

@JamesLongman
Copy link
Owner

The project thus far has conformed to no style guide whatsoever. As I am hoping to add project tests in the next update it would also make sense to conform to a style guide at the same time. A tool I have worked with in the past to automate some aspects of code review is Codacy which seems to be able to assist in conforming to a style guide into a CI solution.

I have never written swift code prior to this project so updating the project will probably require amendments to all project files

@JamesLongman JamesLongman added this to the V1.1.0 milestone Mar 5, 2018
@JamesLongman JamesLongman self-assigned this Mar 5, 2018
JamesLongman added a commit that referenced this issue Mar 6, 2018
#29 Implementing automated code review and style guide
@JamesLongman
Copy link
Owner Author

Merged, final issues were dealt with on Codacy all warnings left after the PR just needed to be ignored on the website (xcode native files and one odd bug where codacy was reading an old version of a file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant