Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable or add a way to customize the PDF.js keybindings #4484

Closed
1 task done
Sakarah opened this issue Dec 11, 2024 · 1 comment
Closed
1 task done

Disable or add a way to customize the PDF.js keybindings #4484

Sakarah opened this issue Dec 11, 2024 · 1 comment

Comments

@Sakarah
Copy link

Sakarah commented Dec 11, 2024

Please fill the following fields with a star (*) and provide as much related information as possible.

Pre-checks*

Please change the following [ ] to [x] for confirmation.

  • The feature request has not been suggested in this repository.

The Missed*

Is your feature request related to a problem? Please provide a clear and concise description of what the problem is.

  • Currently, PDF.js registers a lot of keybindings as stated on the page https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#faq-shortcuts. Those keybindings are effective for internal viewer tabs but they do not appear in the list of VSCode keybindings, and thus cannot be customized. This can be very annoying because these keybindings may conflict with others bindings, and some of them are redundant with existing VSCode features.
    For my personal use case, the Ctrl+O keybinding for Open a file is a real issue since I use Vim keybindings and Ctrl+O is normally bound to Jump to previous location.

The Solution*

Please provide a solution you would like to have.

  • An easy intermediate solution for my particular use case would be to completely remove keybindings that are already covered by VSCode features. Such keybindings are the download document (Ctrl+S) and the open file (Ctrl+O) bindings.
  • To handle all possible keybinding conflicts, it would be great to allow the customization of all keybindings of PDF.js in the standard VSCode keybindings.json.

Anything Else?

Add any other context about the feature request below.

  • The two solutions I have listed are not mutually exclusive because it will never make sense to create another way of opening or saving a pdf file than what VSCode already provides.
@James-Yu
Copy link
Owner

This is the best thing we can do. As keybindings of viewer are hard coded, it's almost impossible to customize them by vscode settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants