framework-instrumentation-tests (#297)

* Fix: Use bitmap icon for shortcut

Use `BitmapFactory.decodeByteArray` to decode the byte array into a bitmap before creating the icon for the shortcut. This ensures that the icon is displayed correctly.

* Add tests for AssetManager, ClipboardManager, and PackageManager wrappers

* Added tests for `AndroidAssetManagerWrapper` to verify the parsing of app settings templates from a JSON file.
* Added tests for `AndroidClipboardManagerWrapper` to verify the behavior of `setPrimaryClip` on different API levels.
* Added tests for `AndroidPackageManagerWrapper` to verify the filtering of installed applications and retrieval of app icons.
* Added necessary dependencies for testing, including Robolectric and Kotlin test libraries.
* Updated build configurations to enable testing and code coverage reporting.

* Fix: Handle JsonSyntaxException when parsing app settings

Handle JsonSyntaxException when parsing app settings from assets by returning an empty list instead of throwing an exception. This ensures the app doesn't crash if the JSON is invalid and provides a fallback behavior.

Author: JackEblan

.idea/androidTestResultsUserPreferences.xml

@@ -24,10 +24,6 @@ plugins {
 }
 
 android {
-    defaultConfig {
-        testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
-    }
-
     namespace = "com.android.geto.data.room"
 
     sourceSets {

.idea/deploymentTargetSelector.xml

@@ -24,10 +24,6 @@ plugins {
 }
 
 android {
-    defaultConfig {
-        testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
-    }
-
     namespace = "com.android.geto.designsystem"
 }
 

data/room/build.gradle.kts

@@ -18,6 +18,7 @@
 
 plugins {
     alias(libs.plugins.com.android.geto.library)
+    alias(libs.plugins.com.android.geto.libraryJacoco)
     alias(libs.plugins.com.android.geto.hilt)
 }
 
@@ -30,4 +31,9 @@ dependencies {
 
     implementation(projects.domain.common)
     implementation(projects.domain.framework)
+
+    androidTestImplementation(kotlin("test"))
+    androidTestImplementation(libs.androidx.test.core)
+    androidTestImplementation(libs.androidx.test.runner)
+    androidTestImplementation(libs.kotlinx.coroutines.test)
 }

design-system/build.gradle.kts

@@ -0,0 +1 @@
+"Trigger JsonSyntaxException in tests"

framework/asset-manager/build.gradle.kts

@@ -0,0 +1,61 @@
+/*
+ *
+ *   Copyright 2023 Einstein Blanco
+ *
+ *   Licensed under the GNU General Public License v3.0 (the "License");
+ *   you may not use this file except in compliance with the License.
+ *   You may obtain a copy of the License at
+ *
+ *       https://www.gnu.org/licenses/gpl-3.0
+ *
+ *   Unless required by applicable law or agreed to in writing, software
+ *   distributed under the License is distributed on an "AS IS" BASIS,
+ *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *   See the License for the specific language governing permissions and
+ *   limitations under the License.
+ *
+ */
+package com.android.geto.framework.assetmanager
+
+import android.content.Context
+import androidx.test.core.app.ApplicationProvider
+import kotlinx.coroutines.test.UnconfinedTestDispatcher
+import kotlinx.coroutines.test.runTest
+import kotlin.test.BeforeTest
+import kotlin.test.Test
+import kotlin.test.assertTrue
+
+class AssetManagerWrapperTest {
+    private val context = ApplicationProvider.getApplicationContext<Context>()
+
+    private val testDispatcher = UnconfinedTestDispatcher()
+
+    private lateinit var assetManagerWrapper: AndroidAssetManagerWrapper
+
+    @BeforeTest
+    fun setUp() {
+        assetManagerWrapper = AndroidAssetManagerWrapper(
+            ioDispatcher = testDispatcher,
+            context = context,
+        )
+    }
+
+    @Test
+    fun getAppSettingTemplates_shouldReturnParsedList_whenJsonIsReadSuccessfully() = runTest {
+        assertTrue(assetManagerWrapper.getAppSettingTemplates().isNotEmpty())
+    }
+
+    @Test
+    fun getAppSettingTemplates_shouldReturnEmpty_whenIOExceptionOccurs() = runTest {
+        assetManagerWrapper.appSettingTemplatesJson = ""
+
+        assertTrue(assetManagerWrapper.getAppSettingTemplates().isEmpty())
+    }
+
+    @Test
+    fun getAppSettingTemplates_shouldReturnEmpty_whenJsonSyntaxExceptionOccurs() = runTest {
+        assetManagerWrapper.appSettingTemplatesJson = "FakeAppSettingTemplates.json"
+
+        assertTrue(assetManagerWrapper.getAppSettingTemplates().isEmpty())
+    }
+}

framework/asset-manager/src/androidTest/assets/FakeAppSettingTemplates.json

@@ -18,11 +18,13 @@
 package com.android.geto.framework.assetmanager
 
 import android.content.Context
+import androidx.annotation.VisibleForTesting
 import com.android.geto.domain.common.dispatcher.Dispatcher
 import com.android.geto.domain.common.dispatcher.GetoDispatchers.IO
 import com.android.geto.domain.framework.AssetManagerWrapper
 import com.android.geto.domain.model.AppSettingTemplate
 import com.google.gson.Gson
+import com.google.gson.JsonSyntaxException
 import com.google.gson.reflect.TypeToken
 import dagger.hilt.android.qualifiers.ApplicationContext
 import kotlinx.coroutines.CoroutineDispatcher
@@ -36,7 +38,8 @@ internal class AndroidAssetManagerWrapper @Inject constructor(
 ) : AssetManagerWrapper {
     private val appSettingsType = object : TypeToken<List<AppSettingTemplate>>() {}.type
 
-    private val appSettingTemplatesJson = "AppSettingTemplates.json"
+    @VisibleForTesting
+    var appSettingTemplatesJson = "AppSettingTemplates.json"
 
     override suspend fun getAppSettingTemplates(): List<AppSettingTemplate> {
         val jsonString = withContext(ioDispatcher) {
@@ -47,6 +50,10 @@ internal class AndroidAssetManagerWrapper @Inject constructor(
             }
         }
 
-        return Gson().fromJson(jsonString, appSettingsType)
+        return try {
+            Gson().fromJson(jsonString, appSettingsType) ?: emptyList()
+        } catch (e: JsonSyntaxException) {
+            emptyList()
+        }
     }
 }

framework/asset-manager/src/androidTest/kotlin/com/android/geto/framework/assetmanager/AssetManagerWrapperTest.kt

@@ -18,13 +18,26 @@
 
 plugins {
     alias(libs.plugins.com.android.geto.library)
+    alias(libs.plugins.com.android.geto.libraryJacoco)
     alias(libs.plugins.com.android.geto.hilt)
 }
 
 android {
     namespace = "com.android.geto.framework.clipboardmanager"
+
+    testOptions {
+        unitTests {
+            isIncludeAndroidResources = true
+        }
+    }
 }
 
 dependencies {
     implementation(projects.domain.framework)
+
+    testImplementation(kotlin("test"))
+    testImplementation(libs.androidx.test.core)
+    testImplementation(libs.androidx.test.runner)
+    testImplementation(libs.kotlinx.coroutines.test)
+    testImplementation(libs.robolectric)
 }

framework/asset-manager/src/main/kotlin/com/android/geto/framework/assetmanager/AndroidAssetManagerWrapper.kt

@@ -0,0 +1,54 @@
+/*
+ *
+ *   Copyright 2023 Einstein Blanco
+ *
+ *   Licensed under the GNU General Public License v3.0 (the "License");
+ *   you may not use this file except in compliance with the License.
+ *   You may obtain a copy of the License at
+ *
+ *       https://www.gnu.org/licenses/gpl-3.0
+ *
+ *   Unless required by applicable law or agreed to in writing, software
+ *   distributed under the License is distributed on an "AS IS" BASIS,
+ *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *   See the License for the specific language governing permissions and
+ *   limitations under the License.
+ *
+ */
+package com.android.geto.framework.clipboardmanager
+
+import android.content.Context
+import android.os.Build
+import androidx.test.core.app.ApplicationProvider
+import kotlinx.coroutines.test.runTest
+import org.junit.runner.RunWith
+import org.robolectric.RobolectricTestRunner
+import org.robolectric.annotation.Config
+import kotlin.test.BeforeTest
+import kotlin.test.Test
+import kotlin.test.assertFalse
+import kotlin.test.assertTrue
+
+@RunWith(RobolectricTestRunner::class)
+class ClipboardManagerWrapperTest {
+    private val context = ApplicationProvider.getApplicationContext<Context>()
+
+    private lateinit var clipboardManagerWrapper: AndroidClipboardManagerWrapper
+
+    @BeforeTest
+    fun setUp() {
+        clipboardManagerWrapper = AndroidClipboardManagerWrapper(context = context)
+    }
+
+    @Test
+    @Config(sdk = [Build.VERSION_CODES.S])
+    fun setPrimaryClip_onApi32() = runTest {
+        assertTrue(clipboardManagerWrapper.setPrimaryClip(label = "label", text = "text"))
+    }
+
+    @Test
+    @Config(sdk = [Build.VERSION_CODES.TIRAMISU])
+    fun setPrimaryClip_onApi33() = runTest {
+        assertFalse(clipboardManagerWrapper.setPrimaryClip(label = "label", text = "text"))
+    }
+}