Skip to content
This repository has been archived by the owner on Oct 19, 2022. It is now read-only.

Move away from node-fetch #10

Open
bdotsamir opened this issue Jun 4, 2022 · 5 comments
Open

Move away from node-fetch #10

bdotsamir opened this issue Jun 4, 2022 · 5 comments
Labels
📁 category: dependencies related to third-party packages the bot uses ⚙️ complexity: 1 ez pz ⚠ priority: 2 lower priority 🔁 status: to-do this will be added sooner or later

Comments

@bdotsamir
Copy link
Collaborator

Node 18 now has support for the browser fetch() method. It's also an LTS release, so we can rely on there being plenty of bug fixes and backported features for years to come.

@bdotsamir bdotsamir added ⚠ priority: 2 lower priority 🔁 status: to-do this will be added sooner or later ⚙️ complexity: ??? no idea how hard this might be 📁 category: dependencies related to third-party packages the bot uses labels Jun 4, 2022
@RobertRR11
Copy link
Contributor

I just tested all of the 4 cases of fetch that the bot uses and it's just as easy as removing the node-fetch package

@bdotsamir
Copy link
Collaborator Author

Sweet, ty. The current plan is to finish up #4- jack and I are on a call rn- then we'll tackle this one. But it's good to know that removing the node-fetch package is all it takes

@JackDotJS
Copy link
Owner

I just tested all of the 4 cases of fetch that the bot uses and it's just as easy as removing the node-fetch package

lol that's what i figured x)

@JackDotJS JackDotJS added ⚙️ complexity: 1 ez pz and removed ⚙️ complexity: ??? no idea how hard this might be labels Jun 4, 2022
@JackDotJS
Copy link
Owner

jack and I are on a call rn

@RobertRR11 if you wanna join the call by any chance lmk

@RobertRR11
Copy link
Contributor

sure @JackDotJS

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📁 category: dependencies related to third-party packages the bot uses ⚙️ complexity: 1 ez pz ⚠ priority: 2 lower priority 🔁 status: to-do this will be added sooner or later
Projects
None yet
Development

No branches or pull requests

3 participants