Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing (sub)domains #5

Open
MarkWieczorek opened this issue Aug 1, 2023 · 1 comment
Open

Missing (sub)domains #5

MarkWieczorek opened this issue Aug 1, 2023 · 1 comment

Comments

@MarkWieczorek
Copy link

MarkWieczorek commented Aug 1, 2023

I noticed that there were a couple missing domains and subdomains in the list like "videos", "t.co", and "x.com"

If you use regex, most of these could be caught using the following

  • (.|^)twitter.com$
  • (.|^)twimb.com$
  • (.|^)x.com$
  • (.|^)t.co$
@JackCuthbert
Copy link
Owner

I'm of the understanding that PiHole does not support regular expressions in the blocklist / hosts file format which this repo provides. I did a quick search and couldn't find anything that confirmed that understanding though... do you know of any documentation that might confirm it?

What I did find however was mmotti/pihole-regex which might help add regex filters somewhat automatically.

I will add the the x.com and t.co domains now too.

JackCuthbert added a commit that referenced this issue Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants