Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JNI crashes when trying to load invalid file #61

Open
pjreiniger opened this issue Jan 31, 2019 · 0 comments
Open

JNI crashes when trying to load invalid file #61

pjreiniger opened this issue Jan 31, 2019 · 0 comments

Comments

@pjreiniger
Copy link

The C code segfaults if the FILE* fp pointer is null. I think the best thing to do would be having the read/write file classes do some defensive coding and check for null first. I was going to make a PR for that, but I saw #59, which is similar in concept, just higher up the chain.

It is a pretty cryptic crash that most students will probably not be able to figure out quickly, so I think it is a valuable update to make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant