Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Log model to not overwrite time #196

Open
JWardee opened this issue May 29, 2024 · 0 comments
Open

Update Log model to not overwrite time #196

JWardee opened this issue May 29, 2024 · 0 comments
Assignees

Comments

@JWardee
Copy link
Owner

JWardee commented May 29, 2024

In src/Models/Logs.php line 199-200 we move time to timestamp, but this has lead to it needing to be writen back in src/Loggers/LogHelper.php line 70 to allow for hooks to work correctly. Ideally we'd just have time always contain the timestamp and have the human readable time in a different property (eg human_time) which'll allow us to remove the hacky rewriting of the property

@JWardee JWardee self-assigned this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant