feat: System.getProperty("SPLIT_NAMES_ON_DELIMITER") for allowing . dots in Table Names

- fixes #2179

Signed-off-by: Andreas Reichel <[email protected]>

Author: manticore-projects

src/main/java/net/sf/jsqlparser/schema/Table.java

@@ -58,6 +58,14 @@ public class Table extends ASTNodeAccessImpl implements FromItem, MultiPartName
 
     public Table() {}
 
+    /**
+     * Instantiates a new Table.
+     *
+     * Sets the table name, splitting it into parts (catalog, schema, name) on `.` dots when quoted
+     * unless the system property `SPLIT_NAMES_ON_DELIMITER` points to `FALSE`
+     *
+     * @param name the table name, optionally quoted
+     */
     public Table(String name) {
         setName(name);
     }
@@ -170,10 +178,22 @@ public String getName() {
     }
 
 
+    /**
+     * Sets the table name, splitting it into parts (catalog, schema, name) on `.` dots when quoted
+     * unless the system property `SPLIT_NAMES_ON_DELIMITER` points to `FALSE`
+     *
+     * @param name the table name, optionally quoted
+     */
     public void setName(String name) {
         // BigQuery seems to allow things like: `catalogName.schemaName.tableName` in only one pair
         // of quotes
-        if (MultiPartName.isQuoted(name) && name.contains(".")) {
+        // however, some people believe that Dots in Names are a good idea, so provide a switch-off
+        boolean splitNamesOnDelimiter = System.getProperty("SPLIT_NAMES_ON_DELIMITER") == null ||
+                !List
+                        .of("0", "N", "n", "FALSE", "false", "OFF", "off")
+                        .contains(System.getProperty("SPLIT_NAMES_ON_DELIMITER"));
+
+        if (MultiPartName.isQuoted(name) && name.contains(".") && splitNamesOnDelimiter) {
             partItems.clear();
             for (String unquotedIdentifier : MultiPartName.unquote(name).split("\\.")) {
                 partItems.add("\"" + unquotedIdentifier + "\"");

src/test/resources/net/sf/jsqlparser/statement/select/oracle-tests/query_factoring07.sql

@@ -87,5 +87,4 @@ select
 )
 
 --@FAILURE: Encountered unexpected token: "by" "BY" recorded first on Aug 3, 2021, 7:20:08 AM
---@SUCCESSFULLY_PARSED_AND_DEPARSED first on Nov 14, 2022, 11:44:23 AM
---@FAILURE: (select bsln_statistics_t(bsln_guid,metric_id,:b11,:b10,timegroup,sample_count,average,minimum,maximum,sdev,pctile_25,pctile_50,pctile_75,pctile_90,pctile_95,pctile_99,est_sample_count,est_slope,est_intercept,case when est_slope=0 then 0 else greatest(0,nvl(100-(25*power((1-est_mu1/est_slope),2)*(est_sample_count-1)),0))end,ln(1000)*est_slope+est_intercept,ln(10000)*est_slope+est_intercept)from(select metric_id,bsln_guid,timegroup,est_mu as est_slope,est_mu*ln(alpha)+x_m as est_intercept,to_number(null)as est_fit_quality,case when count_below_x_j>0 then(sum_below_x_j+(n-m+1)*(x_j-x_m))/count_below_x_j-x_j else to_number(null)end as est_mu1,est_sample_count,n as sample_count,average,minimum,maximum,sdev,pctile_25,pctile_50,pctile_75,pctile_90,pctile_95,pctile_99 from(select metric_id,bsln_guid,timegroup,max(n)as n,count(rrank)as est_sample_count,case when count(rrank)>3 then(sum(obs_value)+(max(n)-max(rrank))*max(obs_value)-(max(n)-min(rrank)+1)*min(obs_value))/(count(rrank)-1)else to_number(null)end as est_mu,(max(n)-min(rrank)+1)/(max(n)+1)as alpha,min(obs_value)as x_m,max(obs_value)as x_l,max(rrank)as l,min(rrank)as m,max(mid_tail_value)as x_j,sum(case when obs_value<mid_tail_value then obs_value else 0 end)as sum_below_x_j,sum(case when cume_dist<:b7 then 1 else 0 end)as count_below_x_j,max(max_val)as maximum,max(min_val)as minimum,max(avg_val)as average,max(sdev_val)as sdev,max(pctile_25)as pctile_25,max(pctile_50)as pctile_50,max(pctile_75)as pctile_75,max(pctile_90)as pctile_90,max(pctile_95)as pctile_95,max(pctile_99)as pctile_99 from(select metric_id,bsln_guid,timegroup,obs_value as obs_value,cume_dist()over(partition by metric_id,bsln_guid,timegroup order by obs_value)as cume_dist,count(1)over(partition by metric_id,bsln_guid,timegroup)as n,row_number()over(partition by metric_id,bsln_guid,timegroup order by obs_value)as rrank,percentile_disc(:b7)within group(order by obs_value asc)over(partition by metric_id,bsln_guid,timegroup)as mid_tail_value,max(obs_value)over(partition by metric_id,bsln_guid,timegroup)as max_val,min(obs_value)over(partition by metric_id,bsln_guid,timegroup)as min_val,avg(obs_value)over(partition by metric_id,bsln_guid,timegroup)as avg_val,stddev(obs_value)over(partition by metric_id,bsln_guid,timegroup)as sdev_val,percentile_cont(0.25)within group(order by obs_value asc)over(partition by metric_id,bsln_guid,timegroup)as pctile_25,percentile_cont(0.5)within group(order by obs_value asc)over(partition by metric_id,bsln_guid,timegroup)as pctile_50,percentile_cont(0.75)within group(order by obs_value asc)over(partition by metric_id,bsln_guid,timegroup)as pctile_75,percentile_cont(0.90)within group(order by obs_value asc)over(partition by metric_id,bsln_guid,timegroup)as pctile_90,percentile_cont(0.95)within group(order by obs_value asc)over(partition by metric_id,bsln_guid,timegroup)as pctile_95,percentile_cont(0.99)within group(order by obs_value asc)over(partition by metric_id,bsln_guid,timegroup)as pctile_99 from timegrouped_rawdata d)x where x.cume_dist>=:b9 and x.cume_dist<=:b8 group by metric_id,bsln_guid,timegroup))) recorded first on 12 Jan 2025, 15:47:43
+--@SUCCESSFULLY_PARSED_AND_DEPARSED first on Nov 14, 2022, 11:44:23 AM