Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible for newcomers to climb the leaderboard #98

Open
Asuza opened this issue Sep 6, 2018 · 5 comments
Open

Make it possible for newcomers to climb the leaderboard #98

Asuza opened this issue Sep 6, 2018 · 5 comments

Comments

@Asuza
Copy link
Contributor

Asuza commented Sep 6, 2018

For example, instead of showing total wins as "376" and losses as "259", show the win ratio as "1.45". Instead of showing diamonds as "58725", show them as an average per game of "16.87" or something similar.

These statistics should be the default display for the leaderboard. However, the existing statistics should remain accessible. These changes should provide a more even playing field for newcomers.

Possible changes might include:

  • Wins -> Win Ratio
  • Kills -> Kill Ratio
  • Souls -> Average Souls Per Game
  • Diamonds -> Average Diamonds Per Game
  • Healer -> Average Health Given Per Game

Kudos to @flesler for the idea.

@flesler
Copy link

flesler commented Sep 6, 2018

I have code calculating this from the JSON of historical matches if you want it. It should be fairly easy to do, though, no magic there

@Asuza
Copy link
Contributor Author

Asuza commented Sep 6, 2018

Sure, that would be nice to have as a starting point, even if it's simple.

@flesler
Copy link

flesler commented Sep 6, 2018

Here it is, you should dump the data/ directory in your hero-starter repo root (I .gitignore'd it).
I included the actual downloaded and generated data, because why not. Uncompressed it is over 250MB.

jsfight.club.zip

I suppose though, that you already have all the totals (shown in the ranking). All you need to do is divide each of them by matches played (by that user)

@flesler
Copy link

flesler commented Dec 14, 2018

@Asuza 🙏

@Asuza
Copy link
Contributor Author

Asuza commented Dec 14, 2018

@flesler I simply haven't had time to work on the site lately. I'm hoping my amount of free time will improve next year and I can prioritize some of the open issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants