Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial battle run #127

Open
dtfinch opened this issue Jun 10, 2021 · 6 comments
Open

Partial battle run #127

dtfinch opened this issue Jun 10, 2021 · 6 comments

Comments

@dtfinch
Copy link

dtfinch commented Jun 10, 2021

Today there were just two battles with 7 bots per team.

short

@dtfinch
Copy link
Author

dtfinch commented Jun 10, 2021

My account page said it was disabled due to a "Code fetch error"

@Asuza
Copy link
Contributor

Asuza commented Jul 13, 2021

@dtfinch, I've finally gotten a chance to look at this issue, and it appears that on that day, jsfight.club was getting authorization errors back from GitHub and wasn't able to download most player code. Unfortunately, the logs do not show enough information for me to know what exactly happened. I'll see if I can improve the logs in case this happens again.

@dtfinch
Copy link
Author

dtfinch commented Aug 12, 2021

There was another partial run today.

Edit: 2 days in a row

@Asuza
Copy link
Contributor

Asuza commented Aug 13, 2021

Thanks, @dtfinch. Pretty sure GitHub is changing the API to get player code, so it could be broken and/or breaking soon from that. I just haven't made time to look at the problem yet.

@dtfinch
Copy link
Author

dtfinch commented Sep 10, 2021

Two partial days in a row again (8964-8967). Same 28-29 bots each time.

Their api documentation says unauthenticated requests are rate-limited to 60 per hour, so I think it's hitting that after an auth error.

https://docs.github.com/en/rest/overview/resources-in-the-rest-api#rate-limiting

@Asuza
Copy link
Contributor

Asuza commented Sep 13, 2021

Thanks for the info, @dtfinch! I haven't gotten to spend as much time as I was hoping, but that rate-limiting would definitely break the existing game runner. Good to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants