Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The latest package has dependency to Caraya Unit Test Framework #50

Open
Bas-vE opened this issue Aug 30, 2024 · 4 comments
Open

The latest package has dependency to Caraya Unit Test Framework #50

Bas-vE opened this issue Aug 30, 2024 · 4 comments

Comments

@Bas-vE
Copy link

Bas-vE commented Aug 30, 2024

version 2.1.0 has a dependency to caraya which can also be seen on VIPM https://www.vipm.io/package/jki_lib_json_serialization/
It feels like this is not by design.

@jimkring
Copy link
Contributor

jimkring commented Sep 6, 2024

Oh! I'll take a look. You're right @Bas-vE, it's not by design.

CC: @nate-moehring

@jimkring jimkring pinned this issue Sep 6, 2024
@nate-moehring
Copy link
Contributor

When I allow VIPM to scan for dependencies, this is all that comes up:
image

@jimkring, I'm guessing you or I mistakenly added Caraya to the package dependencies manually, though I don't know why. You did create that VI Tree in the src folder, which does have a static call to run_tests.vi, but neither is included in the package source files list.

I think we just need to remove it from package dependency list and rebuild it.

@jimkring
Copy link
Contributor

jimkring commented Sep 7, 2024

@nate-moehring @Bas-vE I’ll take a look into this one later this weekend and see if I can do a clean rebuild of the package and what the final dependencies look like.

@francois-normandin
Copy link
Collaborator

The VI Tree references run_tests.vi, which pulls Caraya as a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants