cleanup and refactor

Author: jyu115

react-example/e2e/authentication.spec.ts

@@ -1,8 +1,6 @@
 import { test, expect } from '@playwright/test';
 import { BasePage } from './page-objects/BasePage';
-
-const TEST_EMAIL =
-  process.env.LOGIN_EMAIL || '[email protected]';
+import { TEST_EMAIL } from './utils/test-constants';
 
 /**
  * SDK Authentication Test Suite

react-example/e2e/fixtures/message-factory.ts

@@ -3,40 +3,11 @@
  * Follows Playwright best practices - DRY, reusable, maintainable
  */
 
+import type { InAppMessage } from '@iterable/web-sdk';
 import { MessageTemplates } from './message-templates';
 
-export interface InAppMessage {
-  messageId: string;
-  campaignId: number;
-  createdAt: number;
-  expiresAt: number;
-  content: {
-    html: string;
-    payload: Record<string, unknown>;
-    inAppDisplaySettings: {
-      top: { displayOption: string };
-      right: { percentage: number };
-      bottom: { displayOption: string };
-      left: { percentage: number };
-      shouldAnimate: boolean;
-      bgColor?: { alpha: number; hex: string };
-    };
-    webInAppDisplaySettings: { position: string };
-  };
-  customPayload: Record<string, unknown>;
-  trigger: { type: string };
-  saveToInbox: boolean;
-  inboxMetadata: {
-    title: string;
-    subtitle: string;
-    icon: string;
-  };
-  priorityLevel: number;
-  read: boolean;
-  jsonOnly: boolean;
-  typeOfContent: string;
-  messageType: string;
-}
+// Re-export InAppMessage type for convenience
+export type { InAppMessage };
 
 const defaultDisplaySettings = {
   top: { displayOption: 'AutoExpand' },

react-example/e2e/fixtures/test-fixtures.ts

@@ -13,9 +13,7 @@
 import { test as base } from '@playwright/test';
 import { BasePage } from '../page-objects/BasePage';
 import { InAppPage } from '../page-objects/pages/InAppPage';
-
-const TEST_EMAIL =
-  process.env.LOGIN_EMAIL || '[email protected]';
+import { TEST_EMAIL } from '../utils/test-constants';
 
 type CustomFixtures = {
   basePage: BasePage;

react-example/e2e/inapp-e2e.spec.ts

@@ -1,9 +1,7 @@
 import { test, expect } from '@playwright/test';
 import { BasePage } from './page-objects/BasePage';
 import { InAppPage } from './page-objects/pages/InAppPage';
-
-const TEST_EMAIL =
-  process.env.LOGIN_EMAIL || '[email protected]';
+import { TEST_EMAIL } from './utils/test-constants';
 
 /**
  * In-App Messaging E2E Tests
@@ -158,7 +156,8 @@ test.describe('In-App Messaging - E2E (Real API)', () => {
       .first();
     if (await closeButton.isVisible({ timeout: 2000 }).catch(() => false)) {
       await closeButton.click();
-      await page.waitForTimeout(500);
+      // Wait for iframe to be removed
+      await expect(page.locator('iframe#iterable-iframe')).not.toBeAttached();
     }
 
     await inAppPage.pauseButton.click();
@@ -184,7 +183,8 @@ test.describe('In-App Messaging - E2E (Real API)', () => {
         .first();
       if (await closeButton.isVisible({ timeout: 2000 }).catch(() => false)) {
         await closeButton.click();
-        await page.waitForTimeout(500);
+        // Wait for iframe to be removed
+        await expect(iframe).not.toBeAttached();
       }
     }
 

react-example/e2e/utils/test-constants.ts

@@ -0,0 +1,13 @@
+/**
+ * Shared test constants
+ * Single source of truth for test configuration values
+ */
+
+export const TEST_EMAIL =
+  process.env.LOGIN_EMAIL || '[email protected]';
+
+export const API_TIMEOUTS = {
+  standard: 15000,
+  short: 5000,
+  iframe: 10000
+} as const;