You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the parser has no limit on numbers in expressions, leaving us vulnerable to overflows and attacks that aim to exhaust all memory.
I don't deem it realistic to want more than 100k dice in a throw nor modifier, so I think that is a sensible cap.
Also consider using 64-bit integers for summing the result. Alternatively, report overflows as errors nicely.
The text was updated successfully, but these errors were encountered:
Currently the parser has no limit on numbers in expressions, leaving us vulnerable to overflows and attacks that aim to exhaust all memory.
I don't deem it realistic to want more than 100k dice in a throw nor modifier, so I think that is a sensible cap.
Also consider using 64-bit integers for summing the result. Alternatively, report overflows as errors nicely.
The text was updated successfully, but these errors were encountered: