Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg_resources is deprecated, don't import from there #13

Closed
Joshix-1 opened this issue Jan 31, 2024 · 2 comments · Fixed by #14
Closed

pkg_resources is deprecated, don't import from there #13

Joshix-1 opened this issue Jan 31, 2024 · 2 comments · Fixed by #14
Assignees
@Isotr0py

Comments

@Joshix-1
Copy link

Joshix-1 commented Jan 31, 2024 •
edited
Loading 

          pkg_resources is deprecated: https://setuptools.pypa.io/en/latest/pkg_resources.html
          and as setuptools isn't guaranteed to be installed, it may not even be there

Originally posted by @Joshix-1 in #12 (comment)
@Joshix-1 Joshix-1 changed the title pkg_resources is deprecated: https://setuptools.pypa.io/en/latest/pkg_resources.html pkg_resources is deprecated, don't import from there Jan 31, 2024
@Joshix-1
Copy link
Author

You should probably use https://pypi.org/project/packaging/ and their version parsing function: from packaging.version import parse

@Isotr0py Isotr0py self-assigned this Feb 1, 2024
@Isotr0py Isotr0py mentioned this issue Feb 1, 2024
Merged
@Isotr0py Isotr0py linked a pull request Feb 1, 2024 that will close this issue
Fix: Replace deprecated pkg_resources with packaging #14
Merged
@Isotr0py
Copy link
Owner

Isotr0py commented Feb 1, 2024

I have made a PR to replace pkg_resources.
This will be released in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Isotr0py Isotr0py

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Replace deprecated pkg_resources with packaging Isotr0py/pillow-jpegxl-plugin
2 participants
@Isotr0py @Joshix-1