memory leak checked

Author: Ismaxis

1-Lab/itmo-comp-arch22-lab1-Ismaxis

@@ -72,7 +72,6 @@ void ElfParser::parse() {
         }
     }
 
-    file.close();
     delete[] buff;
 }
 

1-Lab/logisim-evolution-3.8.0-all.jar

@@ -43,9 +43,8 @@ class Instruction {
 };
 
 template <typename T>
-std::string Instruction::toHexString(T number)
-{
+std::string Instruction::toHexString(T number) {
 	std::ostringstream ss;
 	ss << std::setfill('0') << std::setw(sizeof(T) * 2) << std::hex << number;
-	return ss.str();
+    return ss.str();
 }

3-Lab/ElfParser.cpp

@@ -30,17 +30,6 @@ class BType : public Instruction {
         return toHexString(address + imm);
     }
 
-    // static void printBin(uint32_t bits) {  // TODO remove
-    //     std::cout << '\n';
-    //     for (int i = 31; i >= 0; i--) {
-    //         if (i % 4 == 3) {
-    //             std::cout << ' ';
-    //         }
-    //         std::cout << isBitSet(bits, i) ? '1' : '0';
-    //     }
-    //     std::cout << '\n';
-    // }
-
     std::string getMnemonic() const {
         return mnemonics[parseFunct3(bits)];
     }

3-Lab/Instruction.h

@@ -3,7 +3,7 @@
 
 class JType : public Instruction {
    public:
-	explicit JType(uint32_t bits) : Instruction(bits) {}
+    explicit JType(uint32_t bits) : Instruction(bits) {}
     ~JType() override = default;
 
    private:
@@ -29,7 +29,7 @@ class JType : public Instruction {
         return toHexString(address + imm);
     }
 
-	std::string getMnemonic() const {
+    static std::string getMnemonic() {
         return "jal";
     }
 };

3-Lab/Types/BType.h

@@ -31,6 +31,7 @@ int main(const int argc, char const* argv[]) {
         std::cout << "Can't open input file";
         return 0;
     }
+
     ElfParser* parser = parseFile(input);
     input.close();
 
@@ -39,9 +40,11 @@ int main(const int argc, char const* argv[]) {
         std::cout << "Can't open output file";
         return 0;
     }
+
     parser->printDotText(output);
     fprintf(output, "\n");
     parser->printSymtab(output);
+
     fclose(output);
     delete parser;
     return 0;