Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window cannot be resized #1487

Open
ros-financial-com opened this issue Nov 20, 2024 · 51 comments
Open

Window cannot be resized #1487

ros-financial-com opened this issue Nov 20, 2024 · 51 comments
Labels
flatpak Issue related to flatpak build known issue/workaround Workaround available in the know_issues.md file wayland Related to wayland display protocol

Comments

@ros-financial-com
Copy link

After the update to v1.11.5, the window cannot be resized anymore. It can only be used in a preset size (too small for many use cases) or in full screen.

To Reproduce
Steps to reproduce the behavior:

  1. Start fresh session.
  2. Move mouse pointer to any edge or corner of the Teams window.
  3. The mouse pointer does not change to the expected "icon" (like the "corner" or "edge" icon) and the size cannot be changed.

Expected behavior
When moving the mouse pointer to any edge or corner of the Teams window, the mouse pointer should indicate that here, the size can be changed and the window size should be adjustable.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Linux 6.11.9-arch1-1 Zoomclick #1 SMP PREEMPT_DYNAMIC Sun, 17 Nov 2024 16:06:17 +0000 x86_64 GNU/Linux
  • Installation package: flatpak
  • Version: 1.11.5
  • Gnome-shell 47.1-1, Wayland, electron 32.2.5-1 and 33.2.0-1

Additional context
While the version from flatpak shows this behaviour, the one from the Arch Linux repository appears not to be affected and works as expected.

@alfsch
Copy link

alfsch commented Nov 20, 2024

I have this troubles with the flatpak version on ubunut 24.04 with wayland, too.

@IsmaelMartinez
Copy link
Owner

Hello @ros-financial-com and @alfsch, thanks for reporting.

Can you check if the previous version still works? flatpak and snap can be a pain with wayland, and they are tricky to find the reasons as they don't tend to be easy to reproduce.

@IsmaelMartinez IsmaelMartinez added the flatpak Issue related to flatpak build label Nov 20, 2024
@alfsch
Copy link

alfsch commented Nov 20, 2024

I downgraded with this command:

 sudo flatpak update \
      --commit=ed6e779dd7935b309daa4643e2423ab26613874ee401a238dc3296f931b0526a com.github.IsmaelMartinez.teams_for_linux

to this version:

    Commit: ed6e779dd7935b309daa4643e2423ab26613874ee401a238dc3296f931b0526a
   Subject: Update teams-for-linux module (72e25526)
      Date: 2024-11-15 06:15:23 +0000

now resizing of teams application window is possible without problems.

@treizexiii
Copy link

hi! I got the same problem with the last version of flatpak on fedora with wayland.
@alfsch 's solution solves it.

@IsmaelMartinez
Copy link
Owner

My suspicion is this PR I merged the other day. flathub/com.github.IsmaelMartinez.teams_for_linux#90

@Zeitsperre
Copy link

Just updated to the latest stable flatpak (was previously using the Wayland testing branch) and I am seeing no problems at all. Window is responsive to resizing and content is scaling/reorienting as needed.

Running on openSUSE Tumbleweed, KDE Plasma 6.2.3 with kwin_wayland_wr.

@IsmaelMartinez
Copy link
Owner

actually, it might be this one from electron electron/electron#44543 . That sound more plausible

@royborgen
Copy link

Seeing the same issue on Debian Testing. Reverting back to previous flatpak app version as mentoned by @alfsch fixed the issue

@martinlillebo
Copy link

martinlillebo commented Nov 27, 2024

For my laptop (ThinkBook 15 G2 ITL running Debian 12.8), the specific version that @alfsch mentioned didn't help. But an older one did the trick. I'm running x11 instead of Wayland, maybe that's relevant.

Step-by-step instruction for dummies like me:

  • See the full commit list like this: flatpak remote-info --log flathub com.github.IsmaelMartinez.teams_for_linux
  • "Update" to one of the previous versions: sudo flatpak update --commit=YOUR_CHOSEN_COMMIT_HASH com.github.IsmaelMartinez.teams_for_linux
  • In my case, I picked a random older version, the one from 2024-09-11, which had a working window resizing: sudo flatpak update --commit=2edae7411b74b27e91a8c18cc0ebc855887abc4d9c4979d145d37138d11da160 com.github.IsmaelMartinez.teams_for_linux

This doesn't solve the problem for @IsmaelMartinez of course, but at least it lets people avoid the bleeding edge while we wait for rescue... :)

Btw Ismael - thank you for maintaining this flatpak in general. It was a key piece that let me switch over to Linux full-time

@stephzero1
Copy link

stephzero1 commented Nov 28, 2024

Same here (wayland), i don't want to downgrade but i found a work around to resize:

  • ALT + F8 (on Gnome) to resize window via keyboard
  • left/up/right/down arrow key to resize

Better then nothing while waiting for the fix

@IsmaelMartinez
Copy link
Owner

Can some of you check the pre release 1.12.3? Upgraded the electron version and had some "draggable" fixes that might fix this (more of a wish, than anything)

@royborgen
Copy link

Can the flatpak be fetched somehow? If so, I can give it a go

@IsmaelMartinez
Copy link
Owner

Can the flatpak be fetched somehow? If so, I can give it a go

flatpak only get the latest version, and I only push it there and snap when is deemed stable, as there is quite a lot of people using this. Last time I checked more than 500K in flathub (but their numbers can be misleading as some updates count as install, and I don't know the ratio).

It is available in the majority of package managers https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.12.3 (even in windows and Mac as a few people randomly asked for it)

image

@royborgen
Copy link

tested the .deb, resizing works fine there

@martinlillebo
Copy link

Can some of you check the pre release 1.12.3? Upgraded the electron version and had some "draggable" fixes that might fix this (more of a wish, than anything)

Hi, I tried the .Appimage version of the 1.12.3 pre-release now. Works fine with resizing 👍

@phreed
Copy link

phreed commented Dec 5, 2024

Here is another application with the same issue:
https://github.com/flathub/im.riot.Riot/blob/d32d14a402665d0c7591a3ff8ce731a1c713a7d1/element.sh

So I am guessing the problem is around here:

// Wayland
if (process.env.XDG_SESSION_TYPE === 'wayland') {
console.info('Running under Wayland, switching to PipeWire...');
const features = app.commandLine.hasSwitch('enable-features') ? app.commandLine.getSwitchValue('enable-features').split(',') : [];
if (!features.includes('WebRTCPipeWireCapturer'))
features.push('WebRTCPipeWireCapturer');
app.commandLine.appendSwitch('enable-features', features.join(','));
app.commandLine.appendSwitch('use-fake-ui-for-media-stream');
}

@royborgen
Copy link

Did some further testing and found a workaround that lets us use the latest flatpak with window resizing working:

If you use flatseal and disable Socket Wayland windowing system:
image

and change environment variable ELECTRON_OZONE_PLATFORM_HINT=auto to ELECTRON_OZONE_PLATFORM_HINT=x11

image

Now resizing should work.

@alfsch
Copy link

alfsch commented Dec 6, 2024

With env var
ELECTRON_OZONE_PLATFORM_HINT=x11
set, teams is running in Xwayland emulation which leads to blurry app window. Turning off native wayland isn't a soltuion for me, since it worked before without any troubles.

BR

@royborgen
Copy link

royborgen commented Dec 6, 2024

With env var ELECTRON_OZONE_PLATFORM_HINT=x11 set, teams is running in Xwayland emulation which leads to blurry app window. Turning off native wayland isn't a soltuion for me, since it worked before without any troubles.

BR

Your right, this will run the app inside flatpak in x11, and should not be a permanent fix. Wayland > X11.
As for the blurry window, I don't see this problem myself.

On a separate note, I had a meeting on teams today where I also shared my screen. This works fine as well. As I not to this, I am running Gnome on Wayland.

@matheusgeres
Copy link

Same here, I'm running Gnome on Wayland (Fedora 41) and I can't resize my window.

But the tip of @stephzero1 works for me resize!

@IsmaelMartinez
Copy link
Owner

I have mark 1.12.3 a release. Hopefully it doesn't break a lot of other things. Can you guys test it? People did test it before but never got an answer about custom backgrounds, so left it on the "fridge" for a bit longer.

@IsmaelMartinez IsmaelMartinez added the known issue/workaround Workaround available in the know_issues.md file label Dec 9, 2024
@alfsch
Copy link

alfsch commented Dec 10, 2024

I have mark 1.12.3 a release. Hopefully it doesn't break a lot of other things. Can you guys test it? People did test it before but never got an answer about custom backgrounds, so left it on the "fridge" for a bit longer.

As soon as there is a 1.12.3 release on flathub, I will test it 👍

@IsmaelMartinez
Copy link
Owner

It normally take a while... like a day or 2 to get out. Is out of our control. sorry.

@royborgen
Copy link

I see a version 1.12.3 is out on flathub. I tested it and unfortunately the problem is the same.
Disabling Wayland windowing system and setting ELECTRON_OZONE_PLATFORM_HINT=x11 is still a functioning workaround for me.

@alfsch
Copy link

alfsch commented Dec 11, 2024

 flatpak list | grep teams
Portal for Teams	com.github.IsmaelMartinez.teams_for_linux	1.12.3	stable	system

Resizing still don't work :-(

Workaround from #1487 (comment) still works

@stephzero1
Copy link

1.12.3 here, still the same problem

@IsmaelMartinez
Copy link
Owner

IsmaelMartinez commented Dec 11, 2024 via email

@alfsch
Copy link

alfsch commented Dec 11, 2024

I will try it, as soon as we have the flatpak release :-) and don't worry if the release takes some time, since a workaround is there...

@alfsch
Copy link

alfsch commented Dec 13, 2024

I don't know what has changed, but currently resizing works with this version:

image

maybe some flatpak (gnome) lib's were updated. I'm on ubuntu 24.04.1 LTS with kernel 6.8.0-50-generic #51-Ubuntu SMP PREEMPT_DYNAMIC Sat Nov 9 17:58:29 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

@gza
Copy link

gza commented Dec 13, 2024

I don't know what has changed, but currently resizing works with this version:

I have same exact versions and flatpak freshly updated and it is still not working.

@IsmaelMartinez
Copy link
Owner

I wonder if it is not related to the app but either flatpak version or other libs around wayland or similar.

@stephzero1
Copy link

I don't know what has changed, but currently resizing works with this version:

image

maybe some flatpak (gnome) lib's were updated. I'm on ubuntu 24.04.1 LTS with kernel 6.8.0-50-generic #51-Ubuntu SMP PREEMPT_DYNAMIC Sat Nov 9 17:58:29 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

@alfsch how do you get this screen?

@alfsch
Copy link

alfsch commented Dec 13, 2024

I don't know what has changed, but currently resizing works with this version:
...
maybe some flatpak (gnome) lib's were updated. I'm on ubuntu 24.04.1 LTS with kernel 6.8.0-50-generic #51-Ubuntu SMP PREEMPT_DYNAMIC Sat Nov 9 17:58:29 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

@alfsch how do you get this screen?

teams-for-linux about dialog and screenshot app

@gza
Copy link

gza commented Dec 13, 2024

I did a bisect in old flatpak versions and the problem appears while switching between those 2 versions:

    Commit: 81e70b81b6a53868f031b2405fffd936fbdeda1880998204b2b189e573ce0c0c
   Subject: Update teams-for-linux module (4b81935c)
      Date: 2024-09-28 20:55:47 +0000

    Commit: 2edae7411b74b27e91a8c18cc0ebc855887abc4d9c4979d145d37138d11da160
   Subject: Update teams-for-linux module (0f416a62)
      Date: 2024-09-11 09:10:02 +0000

I did the same on vscodium (same issue) and it appears between those 2 versions:

    Commit: bb0dfac5e725c3bcee2fe2b3d9db0042731a2458a1e452ab64414f29d7a8f804
   Subject: :wrench: Fix com.vscodium.codium.yaml format (310cbd20)
      Date: 2024-11-05 07:44:22 +0000

    Commit: 33dbe633c25dd1ece5f188ac991090f5845cbd1fcfa8cb61ef3f068ecf1e7b96
   Subject: :bug: Fix indent_size for yaml files (27d1b639)
      Date: 2024-10-14 23:50:01 +0000

But, there is no real change only 🤔 linting. Is it possible that the root cause is an flatpak build tool both projects updated at different points in time ?

@IsmaelMartinez
Copy link
Owner

can you all provide what version of chromium/chrome you got in your systems? it could be an update on chromium (not from the app) has fixed it for some of you.

@alfsch
Copy link

alfsch commented Dec 16, 2024

Hmm, today it doesn't work again :-(

I think it's somehow a race condition on initializing wayland in electron framework.

@alfsch
Copy link

alfsch commented Dec 16, 2024

Chrome(s) used on my system just for completeness:

 flatpak list | grep chrom
Ungoogled Chromium	io.github.ungoogled_software.ungoogled_chromium	131.0.6778.139-1-1	stable	system
Codecs	io.github.ungoogled_software.ungoogled_chromium.Codecs		stable	system
Chromium Web Browser	org.chromium.Chromium	131.0.6778.139	stable	system
Codecs	org.chromium.Chromium.Codecs		stable	system

@royborgen
Copy link

I do not have chrome at all.

@IsmaelMartinez
Copy link
Owner

If you don't have chromium installed, your system will be using the one the app provides. In the app tray icon, if you click on the About section, it should tell you the chromium version.

In theory that should be the version everyone uses (the one from the app), but somehow I have seen using the whatever version users got installed for others.

@alfsch
Copy link

alfsch commented Dec 17, 2024

I tried also clearing the caches (quit clear storage). Still resizing don't work (except the workaround with Alt-F8).

My chrome version from about dialog 130.0.6723.137.

@royborgen
Copy link

If you don't have chromium installed, your system will be using the one the app provides. In the app tray icon, if you click on the About section, it should tell you the chromium version.

In theory that should be the version everyone uses (the one from the app), but somehow I have seen using the whatever version users got installed for others.

image

@picklesrein
Copy link

Alt + F8 to the rescue for me as well.
Fedora with no Chromium installed. App tray icon offers "App Details" which opens the Software dialog with generic info about the app. Settings --> About Teams tells me The client version is 1415/24120100211 along with notices & legal info. Not sure where to find the chrome version.

$ flatpak list | grep -ie teams -e chrom
Portal for Teams	com.github.IsmaelMartinez.teams_for_linux	1.12.3	stable	flathub	system

$ rpm -qa | grep -ie chrom -e teams
libchromaprint-1.5.1-22.fc41.x86_64
fedora-chromium-config-gnome-3.0-5.fc41.noarch
fedora-chromium-config-3.0-5.fc41.noarch

@Zeitsperre
Copy link

I still haven't had issues with my installation on two different openSUSE Tumbleweed desktops (recently reinstalled as well):

Client version: 1415/24110115724

Portal for Teams        com.github.IsmaelMartinez.teams_for_linux       1.12.3  stable  system

One system has Chromium installed via zypper and the other does not (no issues).

Sorry @IsmaelMartinez, I feel somewhat responsible for kicking off this X11/Wayland nightmare we're all having.

@royborgen
Copy link

I still haven't had issues with my installation on two different openSUSE Tumbleweed desktops (recently reinstalled as well)

Are you on wayland? I am pretty sure this is a Wayland issue

@Zeitsperre
Copy link

@royborgen Indeed: DE: Plasma 6.2.4 [KF 6.9.0] [Qt 6.8.1] (wayland)

@alfsch
Copy link

alfsch commented Dec 17, 2024

yes, it's a wayland issue, is it possible to add wayland to the title or add a label wayland?

@IsmaelMartinez IsmaelMartinez added the wayland Related to wayland display protocol label Dec 18, 2024
@treizexiii
Copy link

i try it on fedora KDE (wayland) without issue.
the problem seems to be specific on gnome wayland

@alfsch
Copy link

alfsch commented Dec 20, 2024

I'm on Ubunutu 24.04.1, maybe it's also more an ubuntu wayland issue.

@ros-financial-com
Copy link
Author

ros-financial-com commented Dec 20, 2024

Well, currently, I switched to Teams from the Arch repo, not using the Flatpak flavour. But I noticed the issue with Teams from Flatpak in Arch Linux with Gnome and wayland.

@IsmaelMartinez
Copy link
Owner

@ros-financial-com , does it work in arch? both Flatpak and snap tend to create the most issues, but flatpak tends to fail in some wayland configurations. I really don't know why but maybe looking at other flatpak apps might help

@royborgen
Copy link

Just installed flatpak 1.12.5 flatpak. Unfortunately the issue is still there. On the bright side, workaround is still working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flatpak Issue related to flatpak build known issue/workaround Workaround available in the know_issues.md file wayland Related to wayland display protocol
Projects
None yet
Development

No branches or pull requests