Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript is outdated #253

Open
RonaldZielaznicki opened this issue Aug 18, 2020 · 3 comments
Open

Typescript is outdated #253

RonaldZielaznicki opened this issue Aug 18, 2020 · 3 comments

Comments

@RonaldZielaznicki
Copy link

Good evening, I'm a developer that was considering using ForerunnerDB for a project of mine but hit a snag in that the typescript definitions included with the project are fairly outdated and the package.json lacks the typings property.

If I wasn't still learning Typescript myself, I'd offer to help get them up to speed. So, the next best thing is to let you all know that there is a problem.

@ragnarwestad
Copy link

ragnarwestad commented Mar 15, 2024

Hi all! I support this request.
I am currently working on upgrading a React project with ForerunnerDB v1.4.67, to latest and using TS. I found that the Collection.count() in the ForerunnerDB types.d.ts doesnt have a version with queries. Obviously this method is there since it works in v1.4.67 and also the doc says it is there. I can easily solve this technically by copying the Collection types declaration and add the count(query: any) but it is not an ideal solution. So I support the request to have the TS types file updated

@Irrelon
Copy link
Owner

Irrelon commented Mar 15, 2024

Hi folks, thanks for the info and request. I'll see if I can get an update for types into the application.

@Irrelon
Copy link
Owner

Irrelon commented Mar 15, 2024

In the mean-time however, if anyone wanted to take a stab at adding the required type via a PR that would be very much appreciated!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants