Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fdb-angular.js not added to dependencies when installing via bower #215

Open
sickrandir opened this issue Apr 27, 2017 · 2 comments
Open

Comments

@sickrandir
Copy link

sickrandir commented Apr 27, 2017

Hi,
I was tryng to use forerunnerdb along with its angular bindings.
My project is based on the yeoman generator_angular app and using grunt for development and build.
The problem I found is that the grunt wiredep task doesn't add the fdb-angular.js file to the dependencies and so the app fails to build or start.
A quick fix that I found is to modify the bower.json file of forerunnerdb anche change this line:
"main": "js/dist/fdb-all.js",
with this:
"main": ["js/dist/fdb-all.js","js/dist/fdb-angular.js"],

I don't know how to manage this in a configurable way without touching the forerunner dependency files.

@Irrelon
Copy link
Owner

Irrelon commented Apr 27, 2017

I think that is a fairly reasonable thing to do. It's difficult to know what the end user will use ForerunnerDB for and perhaps we need two bower projects, one called forerunnerdb and one called forerunnerdb-angular so it can include the required files.

@sickrandir
Copy link
Author

Either that or at least adding a section in the doc where this option is mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants