Fixed Download latest release button
#243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IraSoro
previously approved these changes
Jul 9, 2024
BUILDING.md
Outdated
| ``` | ||
|
|
||
| And run: | ||
| You can also create a development version of native `peri` using the `Docker` image. To to this you should run the following command: |
There was a problem hiding this comment.
"To to this ..." - maybe "To do this ..."
IraSoro
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #242
I tried all available options for
window.open'stargetparameter, such as_system,_blank,_self, but nothing worksI tried to use
@capacitor/browserinstead ofwindow.open, but it doesn't work. The browser is still opens page and nothing happensAlso I checked capacitor's github issues and didn't find anything useful to fix this behavior. so, instead I decided to replace our current download flow to the following flow, it's not as convenient as before, but at least it works:
For
@ionic/browserusing I upgradedionicandcapacitorto the latest versionsAs you can see also I placed
Dockerfilein the repository and changedBUILDING.mdfile