-
Notifications
You must be signed in to change notification settings - Fork 23
Bump to cardano-api 11.2.0.0 + migrate to Certificate API #1379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7a27c09
Bump cardano-api to 11.2.0.0
Jimbo4350 d3b06ff
Drop deprecated TxBody from TxBodyFile phantom
Jimbo4350 52b05f2
Migrate IncompleteTxBody and transaction commands to Exp.UnsignedTx
Jimbo4350 f2f7d4d
Remove non-Byron TxOut CtxTx/CtxUTxO usage from cardano-cli
Jimbo4350 966f30b
Migrate to experimental TxOut in createCompatibleTx
Jimbo4350 3f2af3d
Migrate to cardano-api 11.2.0.0 Certificate API
Jimbo4350 6a49ab3
Add herald changelog fragment for cardano-api 11.2.0.0 bump
Jimbo4350 40bc195
Address review comments from @palas
Jimbo4350 5f42bf5
Regenerate golden files for restored TxOut datum field
Jimbo4350 a0722ce
Fix inline-datum rendering in friendly transaction view
Jimbo4350 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
17 changes: 17 additions & 0 deletions
17
.changes/20260521_cardano_cli_bump_cardano_api_11_2_0_0.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| project: cardano-cli | ||
| pr: 1379 | ||
| kind: | ||
| - maintenance | ||
| description: | | ||
| Bump to cardano-api 11.2.0.0. Folds in three migrations that previously | ||
| lived in separate PRs / unreleased branches: | ||
|
|
||
| - Companion to cardano-api #1200: drop deprecated TxBody / TxBodyContent | ||
| uses (was #1375). | ||
| - Companion to cardano-api #1209: migrate createCompatibleTx, toTxOutInEra, | ||
| and toTxOutInShelleyBasedEra to the experimental TxOut plus supplemental | ||
| datum map (was #1376). | ||
| - Companion to cardano-api #1210: legacy Cardano.Api.Certificate module is | ||
| gone; migrate all imports to Cardano.Api.Experimental.Certificate / | ||
| Cardano.Api.Compatible.Certificate as appropriate, and drop vacuous | ||
| hiding clauses that became -Wdodgy-imports errors under -Werror. |
10 changes: 10 additions & 0 deletions
10
.changes/20260521_cardano_cli_fix_inline_datum_tx_view.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| project: cardano-cli | ||
| pr: 1379 | ||
| kind: | ||
| - bugfix | ||
| description: | | ||
| Fix `cardano-cli transaction view` rendering inline datums as a Haskell-`Show` | ||
| string instead of the structured JSON detailed-schema dict. The friendly tx | ||
| renderer's `L.Datum` branch in `friendlyTxOut` now routes through | ||
| `scriptDataToJson ScriptDataJsonDetailedSchema . fromAlonzoData`, restoring the | ||
| pre-#1374 output shape for inline-datum outputs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the datum here got removed. It seems originally it was only shown when present but, since this is Babbage onwards, I am guessing it is more consistent to show it as
nullif absent