Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jukebox_song data for music instead of disc items in versions 1.21+ #4556

Open
skedgyedgy opened this issue Dec 21, 2024 · 0 comments
Open
Labels
Enhancement New feature or request

Comments

@skedgyedgy
Copy link

What feature do you want to see added?

As of 1.21, music discs are now data driven, allowing data packs to add more music disc definitions. Instead of just prepending "music_disc_" to whatever id you provide and checking it as an item (that's what I assume this plugin does right now anyways) it should look up the jukebox_song data for a provided id in newer versions. This will make adding custom music to servers incredibly easy.

It would also be nice to be able to customize the music menu that appears when you run /plot music, but fortunately that's something that can easily be done with a custom menu running /plot flag set music anyways, so that's not as important. But the inability to add any sort of custom music to plots is really annoying and this could easily address that issue.

Are there any alternatives?

No.

Anything else?

jukebox_song data provides a sound event and song length, I assume the song length value is why this plugin requires music to be from music discs instead of just allowing any sound event.

@skedgyedgy skedgyedgy added the Enhancement New feature or request label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant