Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting to a server without password is impossible #35

Open
t0stiman opened this issue Nov 2, 2023 · 4 comments
Open

Connecting to a server without password is impossible #35

t0stiman opened this issue Nov 2, 2023 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@t0stiman
Copy link
Contributor

t0stiman commented Nov 2, 2023

The confirm button is deactivated unless a password is typed.

afbeelding

@Insprill Insprill added the bug Something isn't working label Nov 2, 2023
@Insprill Insprill moved this to Todo in DV Multiplayer Nov 2, 2023
@fauxnik
Copy link

fauxnik commented May 3, 2024

This affects the port dialog too. Empty should equate to the default (7777), but the Confirm button is disabled until something is typed into the field.

@Insprill
Copy link
Owner

Insprill commented May 3, 2024

There's a method in the text input popup class (forget the exact name) that marks the input as invalid when it's empty. Should be an easy fix if someone would like to make a PR.

@Insprill Insprill added the good first issue Good for newcomers label May 3, 2024
@fauxnik
Copy link

fauxnik commented May 7, 2024

I was looking into it the other day out of curiosity. I'll be unavailable for about a week, but if there's no rush I can take another look when I return.

@morm075
Copy link

morm075 commented Sep 22, 2024

#46 has this resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

4 participants