Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expect/Actual koin modules break in multi module project #166

Open
huibvv opened this issue Sep 5, 2024 · 3 comments
Open

Expect/Actual koin modules break in multi module project #166

huibvv opened this issue Sep 5, 2024 · 3 comments
Labels
status:checking Ticket is currently being checked

Comments

@huibvv
Copy link

huibvv commented Sep 5, 2024

Using koin annotations in a multi module setup with platform specific koin modules fails to compile with

Expected class KoinNativeModule does not have default constructor

I've added a test project, This project contains an Android app and two separate KMM modules. This links as App -> Shared -> Shared2

Removing the shared2 dependency from the module "shared" will build the app without issues. The IDEA still points out the issue, but it doesn't fail the compilation

image

Expected behavior
The compilation should not break, just as it doesn't break if the module is referenced directly by the app module

Koin project used and used version (please complete the following information):
koin = "3.6.0-Beta5"
koin-compose = "1.2.0-Beta5"
koin-annotations = "1.4.0-RC4"

test project.zip

@arnaudgiuliani arnaudgiuliani added the status:checking Ticket is currently being checked label Sep 17, 2024
@arnaudgiuliani
Copy link
Member

Difference with original project is that your iOS part seems not complete. Seems also the case in KMP-app-Template, but the final generation is not stopped by the error
image

Need to check for a second module example

@arnaudgiuliani
Copy link
Member

@huibvv
Copy link
Author

huibvv commented Sep 19, 2024

This way it still is App -> Module right? That structure did not have any issues for me. The issue arose when it has the structure App depends on ModuleA depends on ModuleB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:checking Ticket is currently being checked
Projects
None yet
Development

No branches or pull requests

2 participants