Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input component and styles bug #239

Open
InfinityZxc opened this issue Jul 26, 2023 · 0 comments
Open

Input component and styles bug #239

InfinityZxc opened this issue Jul 26, 2023 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@InfinityZxc
Copy link

InfinityZxc commented Jul 26, 2023

In Input init function self.button:set_style is called with argument self.button_style but self doesn't have such element. There is self.style.button_style, but including into account how set_style works, self.style should be passed. Furthermore, table that is passed to set_style should have elements with the same names, as components based on this, so every variable in default style and Input.on_style_change with the name button_style should be renamed into button.
Finally Input.on_style_change doesn't pass changes to the button component, something like self.button:set_style(self.style) at the end with relevant checks should fix this.

UPD: default input style already has correct field called button, but it doesn't work without fixing Input.on_style_change

@Insality Insality self-assigned this Aug 4, 2023
@Insality Insality added the bug Something isn't working label Aug 4, 2023
@Insality Insality added this to the 0.12.0 milestone Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants