Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit results #6

Open
dorohov7 opened this issue Nov 1, 2024 · 0 comments
Open

Audit results #6

dorohov7 opened this issue Nov 1, 2024 · 0 comments

Comments

@dorohov7
Copy link

dorohov7 commented Nov 1, 2024

  1. Arbitrage.sol. The smart contract implements functions that can be executed by anyone. The executeTrade function can be called by any external account, which could potentially lead to misuse and unintended consequences if not properly secured. Furthermore, nothing in the code validates if the token addresses or the flash loan conditions are safe and trusted for usage.
  2. Arbitrage.sol. There is a lack of access control for sensitive functions. The executeTrade function lacks authorization checks to restrict its execution to trusted addresses.
  3. Arbitrage.sol .The contract makes use of an external flash loan vault from the Balancer protocol, but does not include mechanisms to ensure expected conditions of the flash loan are met, such as the correct token balances after trades. This lacks a check or require statement ensuring the arbitrage was profitable before returning funds or profits to the contract owner.
  4. Arbitrage.sol. Unchecked return values from low-level calls. The approve function calls in _swapOnUniswap and _swapOnSushiswap functions have no safety check to prevent unexpected failure in token transfer approval process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant