fix/fix_manual_tx_generation (#296)

* fix: fixed the manual TX generation and signing to receive the gas price

* fix: solve issues in pre-commit workflow caused by using deprecated components

* fix: solve issues in pre-commit workflow caused by using deprecated components

Author: aarmoa

.github/workflows/golangci-lint.yml

@@ -0,0 +1,38 @@
+name: golangci-lint
+on:
+  pull_request:
+  push:
+    branches: [master, dev]
+permissions:
+  contents: read
+  # Optional: allow read access to pull request. Use with `only-new-issues` option.
+  pull-requests: read
+
+jobs:
+  golangci:
+    name: lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-go@v5
+        with:
+          go-version-file: "go.mod"
+          check-latest: true
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v6
+        with:
+          # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
+          version: latest
+
+          # Optional: working directory, useful for monorepos
+          # working-directory: somedir
+
+          # Optional: golangci-lint command line arguments.
+          args: --timeout=15m -v
+
+          # Optional: show only new issues if it's a pull request. The default value is `false`.
+          only-new-issues: true
+
+          # Optional: if set to true then the all caching functionality will be complete disabled,
+          #           takes precedence over all other caching options.
+          # skip-cache: true

.github/workflows/pre-commit.yml

@@ -8,14 +8,11 @@ jobs:
   pre-commit:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/setup-python@v4
       - uses: actions/checkout@master
         with:
           fetch-depth: 2
       - uses: actions/setup-go@v5
         with:
           go-version-file: "go.mod"
           check-latest: true
-      - run: go install golang.org/x/tools/cmd/goimports@latest
-      - run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.59.0
       - uses: pre-commit/[email protected]

.golangci.yml

@@ -1,60 +1,62 @@
-{
-  "run": {
-    "tests": false,
-    "skip-dirs": [
-      "chain",
-      "exchange",
-      "proto",
-      "client/keyring/testdata"
-    ]
-  },
-  "linters": {
-    "fast": false,
-    "enable": [
-      "errcheck",
-      "errorlint",
-      "gas",
-      "gocritic",
-      "gosimple",
-      "govet",
-      "ineffassign",
-      "megacheck",
-      "misspell",
-      "nakedret",
-      "prealloc",
-      "revive",
-      "staticcheck",
-      "unconvert",
-      "unparam",
-    ],
-    "disable": [
-      "unused",
-    ]
-  },
-  "linters-settings": {
-    "revive": {
-      "enableAllRules": true,
-      "rules": [
-        {
-          "name": "var-naming",
-          "arguments": [
-            ["ID"]
-          ]
-        }
-      ]
-    },
-    "gocritic": {
-      "enabled-tags": [
-        "diagnostic",
-        "experimental",
-        "opinionated",
-        "performance",
-        "style",
-      ],
-      "disabled-checks": [
-        "hugeParam",
-        "unnamedResult",
-      ]
-    }
-  },
-}
+linters:
+  fast: false
+  enable:
+    - errcheck
+    - errorlint
+    - gas
+    - gocritic
+    - gofmt
+    - goimports
+    - gosimple
+    - govet
+    - ineffassign
+    - megacheck
+    - misspell
+    - nakedret
+    - prealloc
+    - revive
+    - staticcheck
+    - unconvert
+    - unparam
+  disable:
+    - unused
+
+linters-settings:
+  revive:
+    enable-all-rules: true
+    rules:
+      - name: var-naming
+        arguments:
+          - ["ID"]
+      - name: add-constant
+        disabled: true
+      - name: line-length-limit
+        arguments:
+          - 140
+  gocritic:
+    enabled-tags:
+      - performance
+      - diagnostic
+      - style
+      - opinionated
+      - experimental
+    disabled-checks:
+      - singleCaseSwitch
+      - deferInLoop
+      - hugeParam
+      - unnamedResult
+issues:
+  exclude-rules:
+    - linters:
+        - revive
+      text: ALL_CAPS
+  exclude-dirs:
+    - chain
+    - exchange
+    - injective_data
+    - proto
+    - client/keyring/testdata
+  max-issues-per-linter: 0
+
+run:
+  tests: false

.pre-commit-config.yaml

@@ -13,10 +13,3 @@ repos:
         -   id: end-of-file-fixer
         -   id: end-of-file-fixer
         -   id: check-yaml
-  -   repo: https://github.com/dnephin/pre-commit-golang
-      rev: master
-      hooks:
-        - id: go-fmt
-        - id: go-imports
-        - id: golangci-lint
-          args: [--timeout=15m]

Makefile

@@ -151,4 +151,16 @@ tests:
 coverage:
 	go test -race -coverprofile=coverage.out -covermode=atomic ./client/... ./ethereum/...
 
-.PHONY: copy-exchange-client tests coverage
+lint: export GOPROXY=direct
+lint:
+	golangci-lint run --timeout=15m -v --new-from-rev=dev
+
+lint-last-commit: export GOPROXY=direct
+lint-last-commit:
+	golangci-lint run --timeout=15m -v --new-from-rev=HEAD~
+
+lint-master: export GOPROXY=direct
+lint-master:
+	golangci-lint run --timeout=15m -v --new-from-rev=master
+
+.PHONY: copy-exchange-client tests coverage lint lint-last-commit lint-master