From f387d90ac883834726c9f5098967df66fb76b474 Mon Sep 17 00:00:00 2001 From: Dusan Brajovic Date: Thu, 30 May 2024 15:59:03 +0200 Subject: [PATCH] comment out Ledger sig verification --- crypto/keyring/keyring.go | 7 ++++--- simapp/go.mod | 2 +- simapp/go.sum | 1 + tests/go.mod | 2 +- tests/go.sum | 1 + 5 files changed, 8 insertions(+), 5 deletions(-) diff --git a/crypto/keyring/keyring.go b/crypto/keyring/keyring.go index 554ff61e43a7..d1e8221adf4f 100644 --- a/crypto/keyring/keyring.go +++ b/crypto/keyring/keyring.go @@ -658,9 +658,10 @@ func SignWithLedger(k *Record, msg []byte, signMode signing.SignMode) (sig []byt return nil, nil, errorsmod.Wrap(ErrInvalidSignMode, fmt.Sprintf("%v", signMode)) } - if !priv.PubKey().VerifySignature(msg, sig) { - return nil, nil, ErrLedgerInvalidSignature - } + // moved to injective-core as part of Ledger signing (PR #1557) + //if !priv.PubKey().VerifySignature(msg, sig) { + // return nil, nil, ErrLedgerInvalidSignature + //} return sig, priv.PubKey(), nil } diff --git a/simapp/go.mod b/simapp/go.mod index 11cd84c124fa..3d63b0dc1a80 100644 --- a/simapp/go.mod +++ b/simapp/go.mod @@ -18,7 +18,7 @@ require ( cosmossdk.io/x/nft v0.1.0 cosmossdk.io/x/tx v0.13.2 cosmossdk.io/x/upgrade v0.1.1 - github.com/cometbft/cometbft v0.38.6 + github.com/cometbft/cometbft v0.38.7 github.com/cosmos/cosmos-db v1.0.2 // this version is not used as it is always replaced by the latest Cosmos SDK version github.com/cosmos/cosmos-sdk v0.50.3 diff --git a/simapp/go.sum b/simapp/go.sum index bc2fe2a6daf9..f468cd6c5ae0 100644 --- a/simapp/go.sum +++ b/simapp/go.sum @@ -343,6 +343,7 @@ github.com/cockroachdb/tokenbucket v0.0.0-20230807174530-cc333fc44b06/go.mod h1: github.com/codahale/hdrhistogram v0.0.0-20161010025455-3a0bb77429bd/go.mod h1:sE/e/2PUdi/liOCUjSTXgM1o87ZssimdTWN964YiIeI= github.com/cometbft/cometbft v0.38.6 h1:QSgpCzrGWJ2KUq1qpw+FCfASRpE27T6LQbfEHscdyOk= github.com/cometbft/cometbft v0.38.6/go.mod h1:8rSPxzUJYquCN8uuBgbUHOMg2KAwvr7CyUw+6ukO4nw= +github.com/cometbft/cometbft v0.38.7/go.mod h1:HIyf811dFMI73IE0F7RrnY/Fr+d1+HuJAgtkEpQjCMY= github.com/cometbft/cometbft-db v0.9.1 h1:MIhVX5ja5bXNHF8EYrThkG9F7r9kSfv8BX4LWaxWJ4M= github.com/cometbft/cometbft-db v0.9.1/go.mod h1:iliyWaoV0mRwBJoizElCwwRA9Tf7jZJOURcRZF9m60U= github.com/containerd/continuity v0.3.0 h1:nisirsYROK15TAMVukJOUyGJjz4BNQJBVsNvAXZJ/eg= diff --git a/tests/go.mod b/tests/go.mod index 278f7a2bffc5..adf979933955 100644 --- a/tests/go.mod +++ b/tests/go.mod @@ -16,7 +16,7 @@ require ( cosmossdk.io/x/nft v0.1.0 // indirect cosmossdk.io/x/tx v0.13.2 cosmossdk.io/x/upgrade v0.1.1 - github.com/cometbft/cometbft v0.38.6 + github.com/cometbft/cometbft v0.38.7 github.com/cosmos/cosmos-db v1.0.2 github.com/cosmos/cosmos-proto v1.0.0-beta.5 // this version is not used as it is always replaced by the latest Cosmos SDK version diff --git a/tests/go.sum b/tests/go.sum index 04cdc84ed881..79f5dc85f654 100644 --- a/tests/go.sum +++ b/tests/go.sum @@ -341,6 +341,7 @@ github.com/cockroachdb/tokenbucket v0.0.0-20230807174530-cc333fc44b06/go.mod h1: github.com/codahale/hdrhistogram v0.0.0-20161010025455-3a0bb77429bd/go.mod h1:sE/e/2PUdi/liOCUjSTXgM1o87ZssimdTWN964YiIeI= github.com/cometbft/cometbft v0.38.6 h1:QSgpCzrGWJ2KUq1qpw+FCfASRpE27T6LQbfEHscdyOk= github.com/cometbft/cometbft v0.38.6/go.mod h1:8rSPxzUJYquCN8uuBgbUHOMg2KAwvr7CyUw+6ukO4nw= +github.com/cometbft/cometbft v0.38.7/go.mod h1:HIyf811dFMI73IE0F7RrnY/Fr+d1+HuJAgtkEpQjCMY= github.com/cometbft/cometbft-db v0.9.1 h1:MIhVX5ja5bXNHF8EYrThkG9F7r9kSfv8BX4LWaxWJ4M= github.com/cometbft/cometbft-db v0.9.1/go.mod h1:iliyWaoV0mRwBJoizElCwwRA9Tf7jZJOURcRZF9m60U= github.com/containerd/continuity v0.3.0 h1:nisirsYROK15TAMVukJOUyGJjz4BNQJBVsNvAXZJ/eg=