From b960a687d8fb40d6725b23a76a3bf5323f0305f2 Mon Sep 17 00:00:00 2001 From: Farhan Kathawala <37834439+farhaninfyom@users.noreply.github.com> Date: Tue, 10 Sep 2019 17:57:17 +0530 Subject: [PATCH 01/23] docs: add doc for deleted by property (#346) --- app/Models/ActivityType.php | 6 +++++- app/Models/Client.php | 20 +++++++++++--------- app/Models/Project.php | 2 ++ app/Models/Tag.php | 1 + app/Models/User.php | 17 +++++++++-------- 5 files changed, 28 insertions(+), 18 deletions(-) diff --git a/app/Models/ActivityType.php b/app/Models/ActivityType.php index 61eeca2c8..a2a7893a8 100644 --- a/app/Models/ActivityType.php +++ b/app/Models/ActivityType.php @@ -11,6 +11,7 @@ * @property int $id * @property string $name * @property int|null $created_by + * @property int $deleted_by * @property \Illuminate\Support\Carbon|null $created_at * @property \Illuminate\Support\Carbon|null $updated_at * @property-read \App\Models\User|null $createdUser @@ -31,7 +32,9 @@ class ActivityType extends Model public $table = 'activity_types'; public $fillable = [ - 'name', 'created_by', 'deleted_by', + 'name', + 'created_by', + 'deleted_by', ]; /** @@ -43,6 +46,7 @@ class ActivityType extends Model 'id' => 'integer', 'name' => 'string', 'created_by' => 'integer', + 'deleted_by' => 'integer', ]; const ACTIVITY_TYPES = [ diff --git a/app/Models/Client.php b/app/Models/Client.php index 06b129831..4ffbb200c 100644 --- a/app/Models/Client.php +++ b/app/Models/Client.php @@ -12,6 +12,7 @@ * @property string $name * @property string $email * @property string $website + * @property int $deleted_by * @property int|null $created_by * @property \Illuminate\Support\Carbon|null $created_at * @property \Illuminate\Support\Carbon|null $updated_at @@ -48,10 +49,11 @@ class Client extends Model * @var array */ protected $casts = [ - 'id' => 'integer', - 'name' => 'string', - 'email' => 'string', - 'website' => 'string', + 'id' => 'integer', + 'name' => 'string', + 'email' => 'string', + 'website' => 'string', + 'deleted_by' => 'integer', ]; /** @@ -60,14 +62,14 @@ class Client extends Model * @var array */ public static $rules = [ - 'name' => 'required|unique:clients,name', - 'email' => 'nullable|email|regex:/^[\w\-\.\+]+\@[a-zA-Z0-9\.\-]+\.[a-zA-z0-9]{2,4}$/', - 'website' => 'nullable|regex:/^(https?:\/\/)?([\da-z\.-]+)\.([a-z\.]{2,6})([\/\w \.-]*)*\/?$/', + 'name' => 'required|unique:clients,name', + 'email' => 'nullable|email|regex:/^[\w\-\.\+]+\@[a-zA-Z0-9\.\-]+\.[a-zA-z0-9]{2,4}$/', + 'website' => 'nullable|regex:/^(https?:\/\/)?([\da-z\.-]+)\.([a-z\.]{2,6})([\/\w \.-]*)*\/?$/', ]; public static $editRules = [ - 'email' => 'nullable|email|regex:/^[\w\-\.\+]+\@[a-zA-Z0-9\.\-]+\.[a-zA-z0-9]{2,4}$/', - 'website' => 'nullable|regex:/^(https?:\/\/)?([\da-z\.-]+)\.([a-z\.]{2,6})([\/\w \.-]*)*\/?$/', + 'email' => 'nullable|email|regex:/^[\w\-\.\+]+\@[a-zA-Z0-9\.\-]+\.[a-zA-z0-9]{2,4}$/', + 'website' => 'nullable|regex:/^(https?:\/\/)?([\da-z\.-]+)\.([a-z\.]{2,6})([\/\w \.-]*)*\/?$/', ]; public static $messages = [ diff --git a/app/Models/Project.php b/app/Models/Project.php index bf2ea001a..b6e062427 100644 --- a/app/Models/Project.php +++ b/app/Models/Project.php @@ -18,6 +18,7 @@ * @property-read \App\Models\Client|null $client * @property-read \App\Models\User|null $createdUser * @property-read \Illuminate\Database\Eloquent\Collection|\App\Models\User[] $users + * @property int $deleted_by * * @method static \Illuminate\Database\Eloquent\Builder|\App\Models\Project newModelQuery() * @method static \Illuminate\Database\Eloquent\Builder|\App\Models\Project newQuery() @@ -64,6 +65,7 @@ class Project extends Model 'description' => 'string', 'client_id' => 'integer', 'created_by' => 'integer', + 'deleted_by' => 'integer', ]; /** diff --git a/app/Models/Tag.php b/app/Models/Tag.php index 48421f835..8bd9d9d41 100644 --- a/app/Models/Tag.php +++ b/app/Models/Tag.php @@ -11,6 +11,7 @@ * @property int $id * @property string $name * @property int|null $created_by + * @property int $deleted_by * @property \Illuminate\Support\Carbon|null $created_at * @property \Illuminate\Support\Carbon|null $updated_at * @property-read \App\Models\User|null $createdUser diff --git a/app/Models/User.php b/app/Models/User.php index 24b5d7922..1ee92b9d8 100644 --- a/app/Models/User.php +++ b/app/Models/User.php @@ -24,6 +24,7 @@ * @property string|null $activation_code * @property int|null $created_by * @property string|null $remember_token + * @property int $deleted_by * @property \Illuminate\Support\Carbon|null $created_at * @property \Illuminate\Support\Carbon|null $updated_at * @property-read \App\Models\User|null $createdUser @@ -120,17 +121,17 @@ class User extends Authenticatable * @var array */ public static $rules = [ - 'name' => 'required|unique:users,name', - 'email' => 'required|email|unique:users,email|regex:/^[\w\-\.\+]+\@[a-zA-Z0-9\.\-]+\.[a-zA-z0-9]{2,4}$/', - 'phone' => 'nullable|numeric|digits:10', - 'role_id' => 'required', + 'name' => 'required|unique:users,name', + 'email' => 'required|email|unique:users,email|regex:/^[\w\-\.\+]+\@[a-zA-Z0-9\.\-]+\.[a-zA-z0-9]{2,4}$/', + 'phone' => 'nullable|numeric|digits:10', + 'role_id' => 'required', ]; public static $messages = [ - 'phone.digits' => 'The phone number must be 10 digits long.', - 'email.regex' => 'Please enter valid email.', - 'photo.mimes' => 'The profile image must be a file of type: jpeg, jpg, png.', - 'role_id.required' => 'Please select user role.', + 'phone.digits' => 'The phone number must be 10 digits long.', + 'email.regex' => 'Please enter valid email.', + 'photo.mimes' => 'The profile image must be a file of type: jpeg, jpg, png.', + 'role_id.required' => 'Please select user role.', ]; public static $setPasswordRules = [ From 0ea87d86648936d35122fef8ca94eb6de412d54d Mon Sep 17 00:00:00 2001 From: Farhan Kathawala <37834439+farhaninfyom@users.noreply.github.com> Date: Tue, 10 Sep 2019 17:59:05 +0530 Subject: [PATCH 02/23] test(time-entry): test case for time entry (#349) --- tests/Controllers/TimeEntryControllerTest.php | 33 ++++++++++++++++++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/tests/Controllers/TimeEntryControllerTest.php b/tests/Controllers/TimeEntryControllerTest.php index 3b0aab799..80ef68588 100644 --- a/tests/Controllers/TimeEntryControllerTest.php +++ b/tests/Controllers/TimeEntryControllerTest.php @@ -4,6 +4,7 @@ use App\Models\Task; use App\Models\TimeEntry; +use App\Models\User; use Illuminate\Foundation\Testing\DatabaseTransactions; use Tests\TestCase; use Tests\Traits\MockRepositories; @@ -39,7 +40,7 @@ public function test_can_filter_time_entries_by_activity_type() } /** @test */ - public function test_can_filter_time_entries_by_project() + public function test_can_filter_time_entries_by_project_with_permission() { $this->withHeaders(['X-Requested-With' => 'XMLHttpRequest']); @@ -65,6 +66,36 @@ public function test_can_filter_time_entries_by_project() $this->assertEquals($task->project_id, $data[0]['task']['project_id']); } + /** @test */ + public function test_can_filter_time_entries_by_project() + { + $this->withHeaders(['X-Requested-With' => 'XMLHttpRequest']); + + $user = factory(User::class)->create(); + $this->actingAs($user); + + /** @var Task $task */ + $task = factory(Task::class)->create(); + $task->taskAssignee()->sync([$user->id]); + + /** @var TimeEntry $firstTimeEntry */ + $firstTimeEntry = factory(TimeEntry::class)->create([ + 'task_id' => $task->id, + 'user_id' => $user->id, + ]); + $secondTimeEntry = factory(TimeEntry::class)->create(); + + $response = $this->getJson(route('time-entries.index', [ + 'filter_project' => $task->project_id, + ])); + + $data = $response->original['data']; + $this->assertCount(1, $data); + $this->assertEquals($firstTimeEntry->id, $data[0]['id']); + $this->assertEquals($task->project_id, $data[0]['task']['project_id']); + $this->assertEquals($user->id, $data[0]['user_id']); + } + /** @test */ public function test_can_filter_time_entries_by_user() { From 49c8ecf40bff65a8084076387f8e7652a5a5132c Mon Sep 17 00:00:00 2001 From: Farhan Kathawala <37834439+farhaninfyom@users.noreply.github.com> Date: Tue, 10 Sep 2019 18:53:53 +0530 Subject: [PATCH 03/23] test: test cases for latest merged PRs (#351) --- app/Repositories/ClientRepository.php | 1 + app/Repositories/ProjectRepository.php | 1 + tests/Controllers/ClientControllerTest.php | 43 +++++--------------- tests/Controllers/ProjectControllerTest.php | 24 +++-------- tests/Repositories/ClientRepositoryTest.php | 29 +++++++++++++ tests/Repositories/ProjectRepositoryTest.php | 21 ++++++++++ 6 files changed, 67 insertions(+), 52 deletions(-) diff --git a/app/Repositories/ClientRepository.php b/app/Repositories/ClientRepository.php index daf80dd19..8f0f70977 100644 --- a/app/Repositories/ClientRepository.php +++ b/app/Repositories/ClientRepository.php @@ -60,6 +60,7 @@ public function getClientList() */ public function delete($clientId) { + /** @var Client $client */ $client = $this->find($clientId); $projectIds = Project::where('client_id', '=', $client->id)->get()->pluck('id'); diff --git a/app/Repositories/ProjectRepository.php b/app/Repositories/ProjectRepository.php index f55207124..cfe83c0a8 100644 --- a/app/Repositories/ProjectRepository.php +++ b/app/Repositories/ProjectRepository.php @@ -100,6 +100,7 @@ public function getProjectsList($clientId = null) */ public function delete($id) { + /** @var Project $project */ $project = $this->find($id); $taskIds = Task::whereProjectId($project->id)->pluck('id')->toArray(); diff --git a/tests/Controllers/ClientControllerTest.php b/tests/Controllers/ClientControllerTest.php index 06bb36928..aec5ad498 100644 --- a/tests/Controllers/ClientControllerTest.php +++ b/tests/Controllers/ClientControllerTest.php @@ -83,20 +83,18 @@ public function it_can_update_client() } /** @test */ - public function it_can_delete_client() + public function test_can_delete_client_with_all_its_child_records() { - /** @var Client $client */ - $client = factory(Client::class)->create(); - $project = factory(Project::class)->create(['client_id' => $client->id]); + /** @var Project $project */ + $project = factory(Project::class)->create(); $task = factory(Task::class)->create(['project_id' => $project->id]); $timeEntry = factory(TimeEntry::class)->create(['task_id' => $task->id]); - $response = $this->deleteJson(route('clients.destroy', $client->id)); + $response = $this->deleteJson(route('clients.destroy', $project->client_id)); $this->assertSuccessMessageResponse($response, 'Client deleted successfully.'); - //testing client deleted or not. - $response = $this->getJson(route('clients.edit', $client->id)); + $response = $this->getJson(route('clients.edit', $project->client_id)); $response->assertStatus(404); $response->assertJson([ @@ -104,32 +102,11 @@ public function it_can_delete_client() 'message' => 'Client not found.', ]); - //testing project deleted or not. - $response = $this->getJson(route('projects.edit', $project->id)); - - $response->assertStatus(404); - $response->assertJson([ - 'success' => false, - 'message' => 'Project not found.', - ]); - - //testing task deleted or not. - $response = $this->getJson(route('tasks.edit', $task->id)); - - $response->assertStatus(404); - $response->assertJson([ - 'success' => false, - 'message' => 'Task not found.', - ]); - - //testing timeEntry deleted or not. - $response = $this->getJson(route('time-entries.edit', $timeEntry->id)); - - $response->assertStatus(404); - $response->assertJson([ - 'success' => false, - 'message' => 'TimeEntry not found.', - ]); + $this->assertEmpty(Project::whereClientId($project->client_id)->first()); + $task = Task::withTrashed()->find($task->id); + $this->assertEquals($this->loggedInUserId, $task->deleted_by); + $timeEntry = TimeEntry::withTrashed()->find($timeEntry->id); + $this->assertEquals($this->loggedInUserId, $timeEntry->deleted_by); } /** @test */ diff --git a/tests/Controllers/ProjectControllerTest.php b/tests/Controllers/ProjectControllerTest.php index 192b78b3e..80c8c6213 100644 --- a/tests/Controllers/ProjectControllerTest.php +++ b/tests/Controllers/ProjectControllerTest.php @@ -82,7 +82,7 @@ public function it_can_retrieve_project() } /** @test */ - public function test_can_delete_project() + public function test_can_delete_project_with_all_its_child_records() { /** @var Project $project */ $project = factory(Project::class)->create(); @@ -93,7 +93,6 @@ public function test_can_delete_project() $this->assertSuccessMessageResponse($response, 'Project deleted successfully.'); - //testing project deleted or not. $response = $this->getJson(route('projects.edit', $project->id)); $response->assertStatus(404); @@ -102,23 +101,10 @@ public function test_can_delete_project() 'message' => 'Project not found.', ]); - //testing task deleted or not. - $response = $this->getJson(route('tasks.edit', $task->id)); - - $response->assertStatus(404); - $response->assertJson([ - 'success' => false, - 'message' => 'Task not found.', - ]); - - //testing timeEntry deleted or not. - $response = $this->getJson(route('time-entries.edit', $timeEntry->id)); - - $response->assertStatus(404); - $response->assertJson([ - 'success' => false, - 'message' => 'TimeEntry not found.', - ]); + $task = Task::withTrashed()->find($task->id); + $this->assertEquals($this->loggedInUserId, $task->deleted_by); + $timeEntry = TimeEntry::withTrashed()->find($timeEntry->id); + $this->assertEquals($this->loggedInUserId, $timeEntry->deleted_by); } /** @test */ diff --git a/tests/Repositories/ClientRepositoryTest.php b/tests/Repositories/ClientRepositoryTest.php index 9a439c305..d13438158 100644 --- a/tests/Repositories/ClientRepositoryTest.php +++ b/tests/Repositories/ClientRepositoryTest.php @@ -3,6 +3,9 @@ namespace Tests\Repositories; use App\Models\Client; +use App\Models\Project; +use App\Models\Task; +use App\Models\TimeEntry; use App\Repositories\ClientRepository; use Illuminate\Foundation\Testing\DatabaseTransactions; use Tests\TestCase; @@ -36,4 +39,30 @@ public function it_can_retrieve_clients_list() $this->assertContains($client, $clients); }); } + + /** @test */ + public function test_can_delete_client_with_all_its_child_records() + { + /** @var Client $client */ + $client = factory(Client::class)->create(); + + $projects = factory(Project::class)->times(2)->create(['client_id' => $client->id]); + + /** @var Task $firstTask */ + $firstTask = factory(Task::class)->create(['project_id' => $projects[0]->id]); + $secondTask = factory(Task::class)->create(['project_id' => $projects[1]->id]); + + $timeEntry = factory(TimeEntry::class)->create(['task_id' => $firstTask->id]); + + $this->clientRepo->delete($client->id); + + $this->assertEmpty(Client::find($client->id)); + $this->assertEmpty(Project::whereClientId($client->id)->first()); + + $task = Task::withTrashed()->find($firstTask->id); + $this->assertEquals($this->loggedInUserId, $task->deleted_by); + + $timeEntry = TimeEntry::withTrashed()->find($timeEntry->id); + $this->assertEquals($this->loggedInUserId, $timeEntry->deleted_by); + } } diff --git a/tests/Repositories/ProjectRepositoryTest.php b/tests/Repositories/ProjectRepositoryTest.php index 45720589e..46e89c235 100644 --- a/tests/Repositories/ProjectRepositoryTest.php +++ b/tests/Repositories/ProjectRepositoryTest.php @@ -4,6 +4,8 @@ use App\Models\Client; use App\Models\Project; +use App\Models\Task; +use App\Models\TimeEntry; use App\Models\User; use App\Repositories\ProjectRepository; use Illuminate\Foundation\Testing\DatabaseTransactions; @@ -120,4 +122,23 @@ public function it_can_retrieve_assigned_projects_list_array_of_logged_in_user() $this->assertCount(1, $allProjects); $this->assertContains($projectOfLoggedInUser->id, array_keys($allProjects)); } + + /** @test */ + public function test_can_delete_project_with_all_its_child_records() + { + $project = factory(Project::class)->create(); + /** @var Task $firstTask */ + $firstTask = factory(Task::class)->create(['project_id' => $project->id]); + $secondTask = factory(Task::class)->create(['project_id' => $project->id]); + $timeEntry = factory(TimeEntry::class)->create(['task_id' => $firstTask->id]); + + $this->projectRepo->delete($firstTask->project_id); + + $this->assertEmpty(Project::find($project->id)); + $task = Task::withTrashed()->find($firstTask->id); + $this->assertEquals($this->loggedInUserId, $task->deleted_by); + + $timeEntry = TimeEntry::withTrashed()->find($timeEntry->id); + $this->assertEquals($this->loggedInUserId, $timeEntry->deleted_by); + } } From 2f67a19a01d11a5633d3ea198c6195b919ea81f5 Mon Sep 17 00:00:00 2001 From: Monika Vaghasiya <51854283+MonikaInfyOm@users.noreply.github.com> Date: Wed, 11 Sep 2019 14:33:38 +0530 Subject: [PATCH 04/23] fix(time-entry): in time entry table - duration format change,, notes as collapsible field, removed created at field (#353) --- resources/assets/js/custom.js | 32 ++++++++ resources/assets/js/task/task.js | 6 -- resources/assets/js/task/task_time_entry.js | 14 ++-- .../assets/js/time_entries/time_entry.js | 74 +++++++++++-------- .../views/tasks/time_tracking_modal.blade.php | 2 +- resources/views/time_entries/table.blade.php | 3 +- 6 files changed, 83 insertions(+), 48 deletions(-) diff --git a/resources/assets/js/custom.js b/resources/assets/js/custom.js index c39c18dea..a3405368a 100644 --- a/resources/assets/js/custom.js +++ b/resources/assets/js/custom.js @@ -229,3 +229,35 @@ $(function () { },150); }); }); + +window.roundToQuarterHourAll = function (minuts) { + var hours = Math.floor(minuts / 60); + var minutes = minuts % 60; + if (hours > 0) { + return pad(hours) + ":" + pad(minutes) + ' h'; + } else { + return pad(hours) + ":" + pad(minutes) + ' m'; + } +}; + +window.pad = function (d) { + return (d < 10) ? '0' + d : d; +}; + +window.nl2br = function (str, is_xhtml) { + if (typeof str === 'undefined' || str === null) { + return ''; + } + var breakTag = (is_xhtml || typeof is_xhtml === 'undefined') ? '
' : '
'; + return (str + '').replace(/([^>\r\n]?)(\r\n|\n\r|\r|\n)/g, '$1' + breakTag + '$2'); +}; + +$(document).on('click', '.collapse-icon', function () { + let isShow = $(this).parent().parent().hasClass('shown'); + if (isShow) { + $(this).children().removeClass('fa-plus-circle').addClass("fa-minus-circle"); + } else { + $(this).children().removeClass('fa-minus-circle').addClass("fa-plus-circle"); + } +}); + diff --git a/resources/assets/js/task/task.js b/resources/assets/js/task/task.js index 79bfafb4c..6e2da1c1a 100644 --- a/resources/assets/js/task/task.js +++ b/resources/assets/js/task/task.js @@ -79,12 +79,6 @@ $(function () { $('[data-toggle="tooltip"]').tooltip(); }); -function getRandomColor() { - let num = Math.floor(Math.random() * 12) + 1; - let coloCodes = ['0095ff', '9594fe', 'da4342', '8e751c', 'ac1f87', 'c86069', '370e1c', 'ca4e7d', 'c02bd8', '289e05', '3aad14', '0D8ABC', '511852']; - return coloCodes[num]; -} - var tbl = $('#task_table').DataTable({ processing: true, serverSide: true, diff --git a/resources/assets/js/task/task_time_entry.js b/resources/assets/js/task/task_time_entry.js index bfdbfafc9..3f43964a6 100644 --- a/resources/assets/js/task/task_time_entry.js +++ b/resources/assets/js/task/task_time_entry.js @@ -1,13 +1,5 @@ $('#task_users').select2({ width: '100%', placeholder: "All", minimumResultsForSearch: -1 }); -function nl2br (str, is_xhtml) { - if (typeof str === 'undefined' || str === null) { - return ''; - } - var breakTag = (is_xhtml || typeof is_xhtml === 'undefined') ? '
' : '
'; - return (str + '').replace(/([^>\r\n]?)(\r\n|\n\r|\r|\n)/g, '$1' + breakTag + '$2'); -} - // open detail confirmation model $(document).on('click', '.taskDetails', function (event) { let id = $(event.currentTarget).data('id'); @@ -91,7 +83,11 @@ window.drawTaskDetailTable = function (data) { {data: "user.name"}, {data: "start_time"}, {data: "end_time"}, - {data: "duration"}, + { + data: function (row) { + return roundToQuarterHourAll(row.duration); + } + }, { orderable: false, data: function (data) { diff --git a/resources/assets/js/time_entries/time_entry.js b/resources/assets/js/time_entries/time_entry.js index 1b526ba40..3a99b218c 100644 --- a/resources/assets/js/time_entries/time_entry.js +++ b/resources/assets/js/time_entries/time_entry.js @@ -22,7 +22,7 @@ let editTaskId, editProjectId = null; let tbl = $('#timeEntryTable').DataTable({ processing: true, serverSide: true, - "order": [[7, "desc"]], + "order": [[9, "desc"]], ajax: { url: timeEntryUrl, data: function (data) { @@ -33,42 +33,45 @@ let tbl = $('#timeEntryTable').DataTable({ }, columnDefs: [ { - "targets": [8], - "orderable": false, + "targets": [9], + "width": "7%", "className": 'text-center', - "width": '5%' - }, - { - "targets": [10, 9], - "visible": false, + "visible": false }, { - "targets": [5], + "targets": [6], "width": "9%" }, { - "targets": [6], + "targets": [7], "width": "4%" }, { - "targets": [3, 4], + "targets": [4, 5], "width": "10%" }, { - "targets": [7], - "width": "7%", + "targets": [8], + "orderable": false, "className": 'text-center', + "width": '5%' }, { - "targets": [2], + "targets": [3], "width": "8%" }, { - "targets": [0], + "targets": [0, 1], "width": "3%" }, ], columns: [ + { + className: 'details-control', + defaultContent: "", + data: null, + orderable: false, + }, { data: function (row) { if (row.user) { @@ -102,7 +105,9 @@ let tbl = $('#timeEntryTable').DataTable({ name: 'end_time' }, { - data: 'duration', + data: function (row) { + return roundToQuarterHourAll(row.duration); + }, name: 'duration' }, { @@ -117,15 +122,6 @@ let tbl = $('#timeEntryTable').DataTable({ }, name: 'entry_type' }, - { - data: function (row) { - return row; - }, - render: function (row) { - return '' + format(row.created_at) + ''; - }, - name: 'created_at' - }, { data: function (row) { return '' + @@ -135,12 +131,13 @@ let tbl = $('#timeEntryTable').DataTable({ }, name: 'id' }, { - data: 'task.project.prefix', - name: 'task.project.prefix' - }, - { - data: 'task.task_number', - name: 'task.task_number' + data: function (row) { + return row; + }, + render: function (row) { + return '' + format(row.created_at) + ''; + }, + name: 'created_at' }, ], "fnInitComplete": function () { @@ -149,6 +146,21 @@ let tbl = $('#timeEntryTable').DataTable({ }); } }); + +$('#timeEntryTable tbody').off('click', 'tr td.details-control'); +$('#timeEntryTable tbody').on('click', 'tr td.details-control', function () { + var tr = $(this).closest('tr'); + var row = tbl.row(tr); + + if (row.child.isShown()) { + row.child.hide(); + tr.removeClass('shown'); + } else { + row.child('
' + nl2br(row.data().note) + '
').show(); + tr.addClass('shown'); + } +}); + if (!canManageEntries) { tbl.columns([0]).visible(false); } diff --git a/resources/views/tasks/time_tracking_modal.blade.php b/resources/views/tasks/time_tracking_modal.blade.php index 89aac68b6..809a8fd4b 100644 --- a/resources/views/tasks/time_tracking_modal.blade.php +++ b/resources/views/tasks/time_tracking_modal.blade.php @@ -23,7 +23,7 @@ {!! nl2br($entry->note) !!} {{$entry->activityType->name}} - {{$entry->duration}} + {{roundToQuarterHour($entry->duration)}} @endforeach diff --git a/resources/views/time_entries/table.blade.php b/resources/views/time_entries/table.blade.php index 362a6f4fc..0b31296ae 100644 --- a/resources/views/time_entries/table.blade.php +++ b/resources/views/time_entries/table.blade.php @@ -1,6 +1,7 @@ + @@ -8,8 +9,8 @@ - + From 220472b56fde090b6849aeb355289333fca5deb9 Mon Sep 17 00:00:00 2001 From: Monika Vaghasiya <51854283+MonikaInfyOm@users.noreply.github.com> Date: Wed, 11 Sep 2019 14:40:17 +0530 Subject: [PATCH 05/23] fiz(profile): Hidden icon for passwords on profile screen (#348) --- resources/assets/js/profile/profile.js | 4 ++++ resources/assets/style/sass/style.scss | 4 ++++ resources/views/profile/edit_profile.blade.php | 8 ++++---- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/resources/assets/js/profile/profile.js b/resources/assets/js/profile/profile.js index a01fd1513..fc242ed3e 100644 --- a/resources/assets/js/profile/profile.js +++ b/resources/assets/js/profile/profile.js @@ -126,8 +126,12 @@ $(".changeType").click(function () { let inputField = $(this).parent().siblings(); let oldType = inputField.attr('type'); if(oldType == 'password') { + $(this).children().addClass('icon-eye'); + $(this).children().removeClass('icon-ban'); inputField.attr('type', 'text'); } else { + $(this).children().removeClass('icon-eye'); + $(this).children().addClass('icon-ban'); inputField.attr('type', 'password'); } }); diff --git a/resources/assets/style/sass/style.scss b/resources/assets/style/sass/style.scss index 20e23ee10..20e29799e 100644 --- a/resources/assets/style/sass/style.scss +++ b/resources/assets/style/sass/style.scss @@ -578,3 +578,7 @@ table.dataTable { top: 23px!important; } + +.input-group__icon { + cursor: pointer; +} \ No newline at end of file diff --git a/resources/views/profile/edit_profile.blade.php b/resources/views/profile/edit_profile.blade.php index 33e8696d0..640d61b21 100644 --- a/resources/views/profile/edit_profile.blade.php +++ b/resources/views/profile/edit_profile.blade.php @@ -45,9 +45,9 @@ {!! Form::label('password', 'New Password') !!}*
-
+
- +
@@ -56,9 +56,9 @@ {!! Form::label('password_confirmation', 'Confirm Password') !!}*
-
+
- +
From 23776e76e7b7719b8826c0952046dfc5903154de Mon Sep 17 00:00:00 2001 From: Monika Vaghasiya <51854283+MonikaInfyOm@users.noreply.github.com> Date: Wed, 11 Sep 2019 14:55:40 +0530 Subject: [PATCH 06/23] fix(task): assignee will be remain if change project (#345) --- resources/assets/js/task/task.js | 15 +++++++++++++-- resources/assets/js/task/task_detail.js | 7 +++++++ 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/resources/assets/js/task/task.js b/resources/assets/js/task/task.js index 6e2da1c1a..ff36476dc 100644 --- a/resources/assets/js/task/task.js +++ b/resources/assets/js/task/task.js @@ -79,6 +79,14 @@ $(function () { $('[data-toggle="tooltip"]').tooltip(); }); +let taskAssignees = []; + +function getRandomColor() { + let num = Math.floor(Math.random() * 12) + 1; + let coloCodes = ['0095ff', '9594fe', 'da4342', '8e751c', 'ac1f87', 'c86069', '370e1c', 'ca4e7d', 'c02bd8', '289e05', '3aad14', '0D8ABC', '511852']; + return coloCodes[num]; +} + var tbl = $('#task_table').DataTable({ processing: true, serverSide: true, @@ -233,11 +241,13 @@ $(document).on('click', '.edit-btn', function (event) { var tagsIds = []; var userIds = []; + taskAssignees = []; $(task.tags).each(function (i, e) { tagsIds.push(e.id); }); $(task.task_assignee).each(function (i, e) { userIds.push(e.id); + taskAssignees.push(e.id); }); $("#editTagIds").val(tagsIds).trigger('change'); @@ -265,8 +275,6 @@ $(document).on('click', '.delete-btn', function (event) { deleteItem(taskUrl + id, '#task_table', 'Task'); }); - - $('#addNewForm').submit(function (event) { event.preventDefault(); let loadingButton = jQuery(this).find("#btnTaskSave"); @@ -464,6 +472,9 @@ $(document).on('change', '#projectId', function (event) { $(document).on('change', '#editProjectId', function (event) { let projectId = $(this).val(); loadProjectAssignees(projectId, 'editAssignee') + setTimeout(function () { + $("#editAssignee").val(taskAssignees).trigger('change'); + }, 1500) }); function loadProjectAssignees(projectId, selector) { diff --git a/resources/assets/js/task/task_detail.js b/resources/assets/js/task/task_detail.js index 967912d91..3df10706a 100644 --- a/resources/assets/js/task/task_detail.js +++ b/resources/assets/js/task/task_detail.js @@ -59,6 +59,8 @@ $(function () { $('[data-toggle="tooltip"]').tooltip() }); +let taskAssignees = []; + // open edit user model $(document).on('click', '.edit-btn', function (event) { let id = $(event.currentTarget).data('id'); @@ -80,11 +82,13 @@ $(document).on('click', '.edit-btn', function (event) { $('#editStatus').val(task.status); var tagsIds = []; var userIds = []; + taskAssignees = []; $(task.tags).each(function (i, e) { tagsIds.push(e.id); }); $(task.task_assignee).each(function (i, e) { userIds.push(e.id); + taskAssignees.push(e.id); }); $("#editTagIds").val(tagsIds).trigger('change'); @@ -110,6 +114,9 @@ $(document).on('click', '.edit-btn', function (event) { $(document).on('change', '#editProjectId', function (event) { let projectId = $(this).val(); loadProjectAssignees(projectId, 'editAssignee') + setTimeout(function () { + $("#editAssignee").val(taskAssignees).trigger('change'); + }, 1500) }); function loadProjectAssignees(projectId, selector) { From c1426e1658054efa298ba3f3e3cff20da1c4a9fe Mon Sep 17 00:00:00 2001 From: Monika Vaghasiya <51854283+MonikaInfyOm@users.noreply.github.com> Date: Wed, 11 Sep 2019 15:01:38 +0530 Subject: [PATCH 07/23] fix(report): in time entry pop up time entry will come between report start and end date only (#352) --- app/Repositories/TaskRepository.php | 20 ++++++++++++--- resources/assets/js/task/task.js | 9 ------- resources/assets/js/task/task_time_entry.js | 27 ++++++++++++--------- resources/views/reports/create.blade.php | 2 +- resources/views/reports/edit.blade.php | 2 +- resources/views/reports/show.blade.php | 4 ++- resources/views/tasks/index.blade.php | 2 ++ 7 files changed, 40 insertions(+), 26 deletions(-) diff --git a/app/Repositories/TaskRepository.php b/app/Repositories/TaskRepository.php index 821303be3..ee0712087 100644 --- a/app/Repositories/TaskRepository.php +++ b/app/Repositories/TaskRepository.php @@ -272,12 +272,26 @@ public function getTaskDetails($id, $input = []) if (isset($input['user_id']) && $input['user_id'] > 0) { $task = Task::with([ 'timeEntries' => function (HasMany $query) use ($input) { - $query->where('time_entries.user_id', '=', $input['user_id']) - ->with('user'); + $query->where('time_entries.user_id', '=', $input['user_id']); + if (isset($input['start_time']) && isset($input['end_time']) && !empty($input['start_time']) && !empty($input['end_time'])) { + $query->whereBetween('start_time', [$input['start_time'], $input['end_time']]); + } + $query->with('user'); }, ])->findOrFail($id); } else { - $task = Task::with('timeEntries.user')->findOrFail($id); + if (isset($input['start_time']) && isset($input['end_time']) && !empty($input['start_time']) && !empty($input['end_time'])) { + $task = Task::with([ + 'timeEntries' => function (HasMany $query) use ($input) { + if (isset($input['start_time']) && isset($input['end_time']) && !empty($input['start_time']) && !empty($input['end_time'])) { + $query->whereBetween('start_time', [$input['start_time'], $input['end_time']]); + } + $query->with('user'); + }, + ])->findOrFail($id); + } else { + $task = Task::with('timeEntries.user')->findOrFail($id); + } } $minutes = $task->timeEntries->pluck('duration')->sum(); diff --git a/resources/assets/js/task/task.js b/resources/assets/js/task/task.js index ff36476dc..e9c9a7ac8 100644 --- a/resources/assets/js/task/task.js +++ b/resources/assets/js/task/task.js @@ -376,15 +376,6 @@ $(function () { } }); -$(document).on('click', '.collapse-icon', function () { - let isShow = $(this).parent().parent().hasClass('shown'); - if(isShow) { - $(this).children().removeClass('fa-plus-circle').addClass("fa-minus-circle"); - } else { - $(this).children().removeClass('fa-minus-circle').addClass("fa-plus-circle"); - } -}); - window.manageCollapseIcon = function (id) { var isExpanded = $('#tdCollapse' + id).attr('aria-expanded'); if (isExpanded == 'true') { diff --git a/resources/assets/js/task/task_time_entry.js b/resources/assets/js/task/task_time_entry.js index 3f43964a6..44ee90f71 100644 --- a/resources/assets/js/task/task_time_entry.js +++ b/resources/assets/js/task/task_time_entry.js @@ -22,17 +22,6 @@ $(document).on('click', '.taskDetails', function (event) { }); } }); - - $.ajax({ - url: taskDetailUrl + '/' + id, - type: 'GET', - success: function (result) { - if (result.success) { - let data = result.data; - drawTaskDetailTable(data); - } - } - }); }); $(document).on('change', '#task_users', function () { @@ -44,9 +33,14 @@ $(document).on('change', '#task_users', function () { userId = taskUserId[0]; } let url = taskDetailUrl + '/' + taskId; + let startSymbol = '?'; if (userId !== 0) { + startSymbol = '&'; url = url + '?user_id=' + userId; } + if (reportStartDate != '' && reportEndDate != '') { + url = url + startSymbol + 'start_time=' + reportStartDate + '&end_time=' + reportEndDate; + } $.ajax({ url: url, type: 'GET', @@ -99,6 +93,8 @@ window.drawTaskDetailTable = function (data) { ], }); + $('#taskDetailsTable th:first').removeClass('sorting_asc'); + $('.time-entry-data').show(); $('#taskDetailsTable').show(); $('#user-drop-down-body').show(); @@ -124,3 +120,12 @@ window.drawTaskDetailTable = function (data) { $("#taskDetailsTable_wrapper").css('width', "100%"); $("#total-duration").html("Total duration: " + data.totalDuration + " || " + data.totalDurationMin + " Minutes"); }; + +$(document).on('click', '.collapse-icon', function () { + let isShow = $(this).parent().parent().hasClass('shown'); + if(isShow) { + $(this).children().removeClass('fa-plus-circle').addClass("fa-minus-circle"); + } else { + $(this).children().removeClass('fa-minus-circle').addClass("fa-plus-circle"); + } +}); diff --git a/resources/views/reports/create.blade.php b/resources/views/reports/create.blade.php index b9a808ac1..66a04c15d 100644 --- a/resources/views/reports/create.blade.php +++ b/resources/views/reports/create.blade.php @@ -14,7 +14,7 @@

New Report

- Back + Back
diff --git a/resources/views/reports/edit.blade.php b/resources/views/reports/edit.blade.php index de8dcd4af..a89717c93 100644 --- a/resources/views/reports/edit.blade.php +++ b/resources/views/reports/edit.blade.php @@ -15,7 +15,7 @@

Edit Report

- Back + Back
diff --git a/resources/views/reports/show.blade.php b/resources/views/reports/show.blade.php index 5da00202a..56363fb95 100644 --- a/resources/views/reports/show.blade.php +++ b/resources/views/reports/show.blade.php @@ -19,7 +19,7 @@ class="btn btn-primary filter-container__btn mr-1"> Edit - Back + Back
@@ -55,6 +55,8 @@ class="btn btn-primary filter-container__btn mr-1"> let taskUrl = '{{url('tasks')}}/'; let taskDetailUrl = '{{url('task-details')}}'; let taskDetailActionColumnIsVisible = false; + let reportStartDate = '{{$report->start_date->startOfDay()}}'; + let reportEndDate = '{{$report->end_date->endOfDay()}}'; diff --git a/resources/views/tasks/index.blade.php b/resources/views/tasks/index.blade.php index 39be2b106..843e23fb2 100644 --- a/resources/views/tasks/index.blade.php +++ b/resources/views/tasks/index.blade.php @@ -76,6 +76,8 @@ let taskBadgesJson = '{!! json_encode($taskBadges) !!}'; let taskBadges = $.parseJSON(taskBadgesJson); let taskDetailActionColumnIsVisible = true; + let reportStartDate = ''; + let reportEndDate = ''; From 5ec595fdc314ef609602d4d96ff0368a59598432 Mon Sep 17 00:00:00 2001 From: Monika Vaghasiya <51854283+MonikaInfyOm@users.noreply.github.com> Date: Wed, 11 Sep 2019 15:03:56 +0530 Subject: [PATCH 08/23] fix(modal): fix allignment issue in modal (#350) --- resources/assets/style/sass/style.scss | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/resources/assets/style/sass/style.scss b/resources/assets/style/sass/style.scss index 20e29799e..c3336792c 100644 --- a/resources/assets/style/sass/style.scss +++ b/resources/assets/style/sass/style.scss @@ -578,7 +578,11 @@ table.dataTable { top: 23px!important; } +.modal-header .close { + padding: 19px; +} .input-group__icon { cursor: pointer; -} \ No newline at end of file +} + From 0cb28fc64f4bf1c96afc41080d3b9889dcb59f7a Mon Sep 17 00:00:00 2001 From: Monika vaghasiya Date: Wed, 11 Sep 2019 16:28:43 +0530 Subject: [PATCH 09/23] fix(time-entry): change column heading --- resources/views/tasks/index.blade.php | 1 - resources/views/tasks/time_tracking_modal.blade.php | 2 +- resources/views/time_entries/table.blade.php | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/resources/views/tasks/index.blade.php b/resources/views/tasks/index.blade.php index 843e23fb2..ebf43cc2b 100644 --- a/resources/views/tasks/index.blade.php +++ b/resources/views/tasks/index.blade.php @@ -83,4 +83,3 @@ @endsection - diff --git a/resources/views/tasks/time_tracking_modal.blade.php b/resources/views/tasks/time_tracking_modal.blade.php index 809a8fd4b..fb031c7ae 100644 --- a/resources/views/tasks/time_tracking_modal.blade.php +++ b/resources/views/tasks/time_tracking_modal.blade.php @@ -14,7 +14,7 @@
- + diff --git a/resources/views/time_entries/table.blade.php b/resources/views/time_entries/table.blade.php index 0b31296ae..e03efea6f 100644 --- a/resources/views/time_entries/table.blade.php +++ b/resources/views/time_entries/table.blade.php @@ -7,7 +7,7 @@ - + From c68d81fa63bbeed47a3e0f834609bd284a37e5d4 Mon Sep 17 00:00:00 2001 From: Shailesh Ladumor Date: Wed, 11 Sep 2019 17:35:51 +0530 Subject: [PATCH 10/23] fix: remove label from chart --- resources/assets/js/dashboard/developers-daily-report.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/resources/assets/js/dashboard/developers-daily-report.js b/resources/assets/js/dashboard/developers-daily-report.js index a763e45cc..4380db1e6 100644 --- a/resources/assets/js/dashboard/developers-daily-report.js +++ b/resources/assets/js/dashboard/developers-daily-report.js @@ -84,7 +84,8 @@ window.prepareDeveloperWorkReport = function (result) { labelString: 'Hours' }, }] - } + }, + legend: { display: false } } }); }; From 4d737a90425a958f51bedfd66389ecab58a2bd7b Mon Sep 17 00:00:00 2001 From: Monika Vaghasiya <51854283+MonikaInfyOm@users.noreply.github.com> Date: Wed, 11 Sep 2019 17:48:38 +0530 Subject: [PATCH 11/23] fix(UI): added first focus for input fields only (#354) --- resources/assets/js/custom.js | 8 +++++--- resources/views/tasks/edit_modal.blade.php | 8 ++++---- resources/views/tasks/modal.blade.php | 8 ++++---- resources/views/time_entries/edit_modal.blade.php | 2 +- resources/views/time_entries/modal.blade.php | 2 +- 5 files changed, 15 insertions(+), 13 deletions(-) diff --git a/resources/assets/js/custom.js b/resources/assets/js/custom.js index a3405368a..fe3103060 100644 --- a/resources/assets/js/custom.js +++ b/resources/assets/js/custom.js @@ -224,9 +224,11 @@ $(document).on('focus', '.select2-selection.select2-selection--single', function $(function () { $(".modal").on('shown.bs.modal', function () { - setTimeout(function () { - $(".modal").find('input:text, .select2-selection.select2-selection--single').first().focus(); - },150); + if($(this).find('.timeEntryAddForm').hasClass('timeEntryAddForm') || $(this).find('.editTimeEntryForm').hasClass('editTimeEntryForm')){ + $(this).find('textarea').first().focus(); + } else { + $(this).find('input:text').first().focus(); + } }); }); diff --git a/resources/views/tasks/edit_modal.blade.php b/resources/views/tasks/edit_modal.blade.php index 7c454cd54..8fe069df8 100644 --- a/resources/views/tasks/edit_modal.blade.php +++ b/resources/views/tasks/edit_modal.blade.php @@ -11,14 +11,14 @@ {!! Form::hidden('tag_id',null,['id'=>'tagId']) !!}
-
- {!! Form::label('project_id', 'Project') !!}* - {!! Form::select('project_id', $projects, null, ['class' => 'form-control','required', 'id' => 'editProjectId', 'placeholder'=>'Select Project']) !!} -
{!! Form::label('title', 'Title') !!}* {!! Form::text('title', null, ['id'=>'editTitle','class' => 'form-control','required']) !!}
+
+ {!! Form::label('project_id', 'Project') !!}* + {!! Form::select('project_id', $projects, null, ['class' => 'form-control','required', 'id' => 'editProjectId', 'placeholder'=>'Select Project']) !!} +
diff --git a/resources/views/tasks/modal.blade.php b/resources/views/tasks/modal.blade.php index 879a88e09..76b21d3e2 100644 --- a/resources/views/tasks/modal.blade.php +++ b/resources/views/tasks/modal.blade.php @@ -10,14 +10,14 @@
-
- {!! Form::label('project_id', 'Project') !!}* - {!! Form::select('project_id', $projects, null, ['class' => 'form-control','required', 'id' => 'projectId', 'placeholder'=>'Select Project']) !!} -
{!! Form::label('title', 'Title') !!}* {!! Form::text('title', null, ['id'=>'title','class' => 'form-control','required']) !!}
+
+ {!! Form::label('project_id', 'Project') !!}* + {!! Form::select('project_id', $projects, null, ['class' => 'form-control','required', 'id' => 'projectId', 'placeholder'=>'Select Project']) !!} +
diff --git a/resources/views/time_entries/edit_modal.blade.php b/resources/views/time_entries/edit_modal.blade.php index df5024055..5e3253147 100644 --- a/resources/views/time_entries/edit_modal.blade.php +++ b/resources/views/time_entries/edit_modal.blade.php @@ -6,7 +6,7 @@
Edit Time Entry
- {!! Form::open(['id'=>'editTimeEntryForm','files'=>true]) !!} + {!! Form::open(['id'=>'editTimeEntryForm','class'=>'editTimeEntryForm','files'=>true]) !!}
{!! Form::hidden('entry_id',null,['id'=>'entryId']) !!} diff --git a/resources/views/time_entries/modal.blade.php b/resources/views/time_entries/modal.blade.php index a11b81e78..1c6ec7c06 100644 --- a/resources/views/time_entries/modal.blade.php +++ b/resources/views/time_entries/modal.blade.php @@ -6,7 +6,7 @@
New Time Entry
- {!! Form::open(['id'=>'timeEntryAddForm']) !!} + {!! Form::open(['id'=>'timeEntryAddForm', 'class'=>'timeEntryAddForm']) !!}
From 2a627918557f85e580d374872c839cfb82b2a243 Mon Sep 17 00:00:00 2001 From: Farhan Kathawala <37834439+farhaninfyom@users.noreply.github.com> Date: Thu, 12 Sep 2019 13:20:47 +0530 Subject: [PATCH 12/23] test: test cases for helper (#340) --- tests/Unit/Helpers/HelpersTest.php | 41 ++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/tests/Unit/Helpers/HelpersTest.php b/tests/Unit/Helpers/HelpersTest.php index ebf189201..3576e8a2b 100644 --- a/tests/Unit/Helpers/HelpersTest.php +++ b/tests/Unit/Helpers/HelpersTest.php @@ -2,10 +2,14 @@ namespace Tests\Unit\Helpers; +use App\Models\User; +use Illuminate\Foundation\Testing\DatabaseTransactions; use Tests\TestCase; class HelpersTest extends TestCase { + use DatabaseTransactions; + /** @test */ public function explode_trim_remove_empty_values_from_array() { @@ -24,4 +28,41 @@ public function explode_trim_remove_empty_values_from_array() $result = explode_trim_remove_empty_values_from_array(' hello ,, ,0, test '); $this->assertEquals(['hello', '0', 'test'], $result); } + + /** @test */ + public function test_return_user_avatar_url() + { + /** @var User $user */ + $user = factory(User::class)->create(); + + $response = getUserImageInitial($user->id, $user->name); + + $this->assertNotEmpty($response); + $this->assertStringContainsString($user->name, $response); + } + + /** @test */ + public function test_return_true_when_user_has_permission() + { + /** @var User $user */ + $user = factory(User::class)->create(); + $this->actingAs($user); + $this->attachPermissions($user->id, ['manage_users']); + + $response = authUserHasPermission('manage_users'); + + $this->assertTrue($response); + } + + /** @test */ + public function test_return_false_when_user_has_no_permission() + { + /** @var User $user */ + $user = factory(User::class)->create(); + $this->actingAs($user); + + $response = authUserHasPermission('manage_users'); + + $this->assertFalse($response); + } } From 19a49aaac9f35a8544d2b877732fab628724f2c9 Mon Sep 17 00:00:00 2001 From: vishalinfyom Date: Thu, 12 Sep 2019 13:29:55 +0530 Subject: [PATCH 13/23] test: Permissions namespace refactored --- .../ActivityTypeControllerPermissionTest.php | 2 ++ .../ClientControllerPermissionTest.php | 2 ++ .../ProjectControllerPermissionTest.php | 2 ++ .../ReportControllerPermissionTest.php | 2 ++ .../RoleControllerPermissionTest.php | 2 ++ .../TagControllerPermissionTest.php | 2 ++ .../TaskControllerPermissionTest.php | 2 ++ .../UserControllerPermissionTest.php | 2 ++ 8 files changed, 16 insertions(+) rename tests/{Permissiion => Permissions}/ActivityTypeControllerPermissionTest.php (99%) rename tests/{Permissiion => Permissions}/ClientControllerPermissionTest.php (99%) rename tests/{Permissiion => Permissions}/ProjectControllerPermissionTest.php (99%) rename tests/{Permissiion => Permissions}/ReportControllerPermissionTest.php (99%) rename tests/{Permissiion => Permissions}/RoleControllerPermissionTest.php (99%) rename tests/{Permissiion => Permissions}/TagControllerPermissionTest.php (99%) rename tests/{Permissiion => Permissions}/TaskControllerPermissionTest.php (99%) rename tests/{Permissiion => Permissions}/UserControllerPermissionTest.php (99%) diff --git a/tests/Permissiion/ActivityTypeControllerPermissionTest.php b/tests/Permissions/ActivityTypeControllerPermissionTest.php similarity index 99% rename from tests/Permissiion/ActivityTypeControllerPermissionTest.php rename to tests/Permissions/ActivityTypeControllerPermissionTest.php index 52837ed81..ff75cf66f 100644 --- a/tests/Permissiion/ActivityTypeControllerPermissionTest.php +++ b/tests/Permissions/ActivityTypeControllerPermissionTest.php @@ -1,5 +1,7 @@ Date: Fri, 13 Sep 2019 11:01:27 +0530 Subject: [PATCH 14/23] fix(time-entry): admin can add/ update time entry on any task (#357) --- app/Http/Controllers/TimeEntryController.php | 13 ++++++---- app/Repositories/TaskRepository.php | 10 +++++--- app/Repositories/TimeEntryRepository.php | 7 ++++-- .../TimeEntryControllerValidationTest.php | 19 ++++++++++++++- tests/Repositories/TaskRepositoryTest.php | 24 ++++++++++++++++++- .../Repositories/TimeEntryRepositoryTest.php | 19 +++++++++++++++ 6 files changed, 80 insertions(+), 12 deletions(-) diff --git a/app/Http/Controllers/TimeEntryController.php b/app/Http/Controllers/TimeEntryController.php index 8ed2c93c2..c767b9f31 100644 --- a/app/Http/Controllers/TimeEntryController.php +++ b/app/Http/Controllers/TimeEntryController.php @@ -89,12 +89,15 @@ public function edit(TimeEntry $timeEntry) */ public function update(TimeEntry $timeEntry, UpdateTimeEntryRequest $request) { - $entry = TimeEntry::ofCurrentUser()->find($timeEntry->id); - if (empty($entry)) { + $user = getLoggedInUser(); + if (!$user->can('manage_projects')) { + $timeEntry = TimeEntry::ofCurrentUser()->find($timeEntry->id); + } + if (empty($timeEntry)) { return $this->sendError('Time Entry not found.', Response::HTTP_NOT_FOUND); } $input = $this->validateInput($request->all(), $timeEntry->id); - $existEntry = $entry->only([ + $existEntry = $timeEntry->only([ 'id', 'task_id', 'activity_type_id', @@ -106,8 +109,8 @@ public function update(TimeEntry $timeEntry, UpdateTimeEntryRequest $request) ]); $inputDiff = array_diff($existEntry, $input); if (!empty($inputDiff)) { - Log::info('Entry Id: '.$entry->id); - Log::info('Task Id: '.$entry->task_id); + Log::info('Entry Id: '.$timeEntry->id); + Log::info('Task Id: '.$timeEntry->task_id); Log::info('fields changed: ', $inputDiff); Log::info('Entry updated by: '.Auth::user()->name); } diff --git a/app/Repositories/TaskRepository.php b/app/Repositories/TaskRepository.php index ee0712087..bd8e80e76 100644 --- a/app/Repositories/TaskRepository.php +++ b/app/Repositories/TaskRepository.php @@ -312,10 +312,14 @@ public function getTaskDetails($id, $input = []) */ public function myTasks($input = []) { + $user = getLoggedInUser(); /** @var Builder|Task $query */ - $query = Task::whereHas('taskAssignee', function (Builder $query) { - $query->where('user_id', getLoggedInUserId()); - })->whereNotIn('status', [Task::STATUS_COMPLETED]); + $query = Task::whereNotIn('status', [Task::STATUS_COMPLETED]); + if (!$user->can('manage_projects')) { + $query = $query->whereHas('taskAssignee', function (Builder $query) { + $query->where('user_id', getLoggedInUserId()); + }); + } if (!empty($input['project_id'])) { $query->ofProject($input['project_id']); diff --git a/app/Repositories/TimeEntryRepository.php b/app/Repositories/TimeEntryRepository.php index 33d8fdd12..1f85bc765 100644 --- a/app/Repositories/TimeEntryRepository.php +++ b/app/Repositories/TimeEntryRepository.php @@ -98,12 +98,15 @@ public function myLastTask() */ public function getTasksByProject($projectId, $taskId = null) { + $user = getLoggedInUser(); /** @var Builder $query */ $query = Task::ofProject($projectId) - ->where('status', '=', Task::STATUS_ACTIVE) - ->whereHas('taskAssignee', function (Builder $query) { + ->where('status', '=', Task::STATUS_ACTIVE); + if (!$user->can('manage_projects')) { + $query = $query->whereHas('taskAssignee', function (Builder $query) { $query->where('user_id', getLoggedInUserId()); }); + } if (!empty($taskId)) { $query->orWhere('id', $taskId); diff --git a/tests/Controllers/Validations/TimeEntryControllerValidationTest.php b/tests/Controllers/Validations/TimeEntryControllerValidationTest.php index 6833c21a9..9458d7fd4 100644 --- a/tests/Controllers/Validations/TimeEntryControllerValidationTest.php +++ b/tests/Controllers/Validations/TimeEntryControllerValidationTest.php @@ -5,6 +5,7 @@ use App\Models\ActivityType; use App\Models\Task; use App\Models\TimeEntry; +use App\Models\User; use Illuminate\Foundation\Testing\DatabaseTransactions; use Tests\TestCase; @@ -146,8 +147,24 @@ public function test_update_time_entry_fails_when_task_id_is_not_passed() } /** @test */ - public function test_update_time_entry_fails_when_user_try_to_update_another_users_entry() + public function test_user_with_valid_permission_can_update_other_users_time_entry() { + $this->attachPermissions(getLoggedInUserId(), ['manage_projects']); + /** @var TimeEntry $timeEntry1 */ + $timeEntry1 = factory(TimeEntry::class)->create(); + $timeEntry2 = factory(TimeEntry::class)->create(['user_id' => $this->defaultUserId]); + + $response = $this->put(route('time-entries.update', $timeEntry1->id), $this->timeEntryInputs()); + + $this->assertSuccessMessageResponse($response, 'Time Entry updated successfully.'); + } + + /** @test */ + public function test_user_can_not_update_other_users_time_entry_without_valid_permission() + { + $monika = factory(User::class)->create(); + $this->actingAs($monika); + /** @var TimeEntry $timeEntry1 */ $timeEntry1 = factory(TimeEntry::class)->create(); $timeEntry2 = factory(TimeEntry::class)->create(['user_id' => $this->defaultUserId]); diff --git a/tests/Repositories/TaskRepositoryTest.php b/tests/Repositories/TaskRepositoryTest.php index 60ab92498..a81d33b6c 100644 --- a/tests/Repositories/TaskRepositoryTest.php +++ b/tests/Repositories/TaskRepositoryTest.php @@ -201,13 +201,35 @@ public function test_can_get_active_task_of_logged_in_user() $completedTask = factory(Task::class)->create(['status' => Task::STATUS_COMPLETED]); $completedTask->taskAssignee()->sync([$this->defaultUserId]); + $this->actingAs($farhan); + $myTasks = $this->taskRepo->myTasks(); $this->assertCount(1, $myTasks['tasks']); - $this->assertEquals($activeTask->id, $myTasks['tasks'][0]->id); + $this->assertEquals($task->id, $myTasks['tasks'][0]->id); $this->assertEquals(Task::STATUS_ACTIVE, $myTasks['tasks'][0]->status); } + /** @test */ + public function test_user_with_manage_project_permission_can_get_all_active_tasks() + { + $monika = factory(User::class)->create(); + $task = factory(Task::class)->create(); + $task->taskAssignee()->sync([$monika->id]); + + $activeTask = factory(Task::class)->create(); + $activeTask->taskAssignee()->sync([$monika->id]); + + $this->attachPermissions($this->defaultUserId, ['manage_projects']); + + $completedTask = factory(Task::class)->create(['status' => Task::STATUS_COMPLETED]); + $completedTask->taskAssignee()->sync([$monika->id]); + + $myTasks = $this->taskRepo->myTasks(); + + $this->assertCount(2, $myTasks['tasks']); + } + /** @test */ public function test_can_get_task_details_with_task_duration() { diff --git a/tests/Repositories/TimeEntryRepositoryTest.php b/tests/Repositories/TimeEntryRepositoryTest.php index 6f2129007..e179d38a6 100644 --- a/tests/Repositories/TimeEntryRepositoryTest.php +++ b/tests/Repositories/TimeEntryRepositoryTest.php @@ -90,6 +90,25 @@ public function test_can_get_specific_active_task_of_logged_in_user_for_given_pr $this->assertContains($task2->id, $result->keys()); } + /** @test */ + public function test_can_get_active_task_of_logged_in_user_having_manage_projects_permission_for_given_project() + { + $monika = factory(User::class)->create(); + + $task1 = factory(Task::class)->create(['status' => Task::STATUS_ACTIVE]); + $task1->taskAssignee()->attach($monika->id); + + $task2 = factory(Task::class)->create(['status' => Task::STATUS_ACTIVE, 'project_id' => $task1->project_id]); + $task2->taskAssignee()->attach($this->defaultUserId); + $completedTask = factory(Task::class)->create(['status' => Task::STATUS_COMPLETED]); // this should not return + $completedTask->taskAssignee()->attach($this->defaultUserId); + + $result = $this->timeEntryRepo->getTasksByProject($task2->project_id); + + $this->assertCount(2, $result); + $this->assertContains($task2->id, $result->keys()); + } + /** @test */ public function test_can_update_duration_of_time_entry_and_make_start_and_end_time_to_empty() { From 255189613cfab4eaaa811c5bdeef1e00a2895633 Mon Sep 17 00:00:00 2001 From: Monika Vaghasiya <51854283+MonikaInfyOm@users.noreply.github.com> Date: Fri, 13 Sep 2019 11:09:35 +0530 Subject: [PATCH 15/23] fix(task-detail): task title added as a time entry model header in task screen (#355) --- app/Repositories/TaskRepository.php | 4 +++- resources/assets/js/task/task_time_entry.js | 9 +++++++-- resources/views/tasks/task_details.blade.php | 1 + 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/app/Repositories/TaskRepository.php b/app/Repositories/TaskRepository.php index bd8e80e76..e07e026ab 100644 --- a/app/Repositories/TaskRepository.php +++ b/app/Repositories/TaskRepository.php @@ -278,6 +278,7 @@ public function getTaskDetails($id, $input = []) } $query->with('user'); }, + 'project', ])->findOrFail($id); } else { if (isset($input['start_time']) && isset($input['end_time']) && !empty($input['start_time']) && !empty($input['end_time'])) { @@ -288,9 +289,10 @@ public function getTaskDetails($id, $input = []) } $query->with('user'); }, + 'project', ])->findOrFail($id); } else { - $task = Task::with('timeEntries.user')->findOrFail($id); + $task = Task::with('timeEntries.user', 'project')->findOrFail($id); } } diff --git a/resources/assets/js/task/task_time_entry.js b/resources/assets/js/task/task_time_entry.js index 44ee90f71..280024ff0 100644 --- a/resources/assets/js/task/task_time_entry.js +++ b/resources/assets/js/task/task_time_entry.js @@ -1,5 +1,7 @@ $('#task_users').select2({ width: '100%', placeholder: "All", minimumResultsForSearch: -1 }); +let firstTime = true; + // open detail confirmation model $(document).on('click', '.taskDetails', function (event) { let id = $(event.currentTarget).data('id'); @@ -7,6 +9,7 @@ $(document).on('click', '.taskDetails', function (event) { $('#no-record-info-msg').hide(); $('#taskDetailsTable').hide(); $('.time-entry-data').hide(); + firstTime = true; $.ajax({ url: taskUrl + id + '/' + 'users', @@ -47,6 +50,8 @@ $(document).on('change', '#task_users', function () { success: function (result) { if (result.success) { let data = result.data; + let url = taskUrl + data.project.prefix + '-' + data.task_number; + $("#task-heading").html("
Task: " + data.title + "
"); drawTaskDetailTable(data); } } @@ -54,13 +59,13 @@ $(document).on('change', '#task_users', function () { }); window.drawTaskDetailTable = function (data) { - if (data.totalDuration === 0) { + if (data.totalDuration === 0 && firstTime) { $('#no-record-info-msg').show(); $('.time-entry-data').hide(); stopLoader(); return true; } - + firstTime = false; let taskDetailsTable = $('#taskDetailsTable').DataTable({ destroy: true, paging: true, diff --git a/resources/views/tasks/task_details.blade.php b/resources/views/tasks/task_details.blade.php index df02b3da9..3d5047e97 100644 --- a/resources/views/tasks/task_details.blade.php +++ b/resources/views/tasks/task_details.blade.php @@ -9,6 +9,7 @@
@include('loader')
+
From 12123f6440e4dafab3e2116839a10095b0a0d81e Mon Sep 17 00:00:00 2001 From: Shailesh Ladumor Date: Fri, 13 Sep 2019 11:18:56 +0530 Subject: [PATCH 16/23] bumping to version 1.8.4-alpha --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index 05e02dac5..58d521e3c 100644 --- a/composer.json +++ b/composer.json @@ -1,7 +1,7 @@ { "name": "infyomlabs/infy-tracker", "type": "project", - "version": "1.8.3-alpha", + "version": "1.8.4-alpha", "description": "Create Projects / Tasks, Track Time, Show Daily Reports", "keywords": [ "time", From e89925830f8e165f4c57885cf7199f3fd4546542 Mon Sep 17 00:00:00 2001 From: Farhan Kathawala <37834439+farhaninfyom@users.noreply.github.com> Date: Fri, 13 Sep 2019 14:20:00 +0530 Subject: [PATCH 17/23] refactor: default task status should be pending (#361) --- app/Http/Controllers/TaskController.php | 2 +- database/factories/TaskFactory.php | 3 +- ..._054205_update_task_status_field_value.php | 30 +++++++++++++++++++ tests/Controllers/TaskControllerTest.php | 6 ++-- tests/Controllers/TimeEntryControllerTest.php | 4 +-- .../TaskControllerValidationTest.php | 2 +- tests/Repositories/TaskRepositoryTest.php | 2 +- .../Repositories/TimeEntryRepositoryTest.php | 12 ++++---- 8 files changed, 43 insertions(+), 18 deletions(-) create mode 100644 database/migrations/2019_09_13_054205_update_task_status_field_value.php diff --git a/app/Http/Controllers/TaskController.php b/app/Http/Controllers/TaskController.php index 7c62eab5f..bbdd69bec 100644 --- a/app/Http/Controllers/TaskController.php +++ b/app/Http/Controllers/TaskController.php @@ -88,7 +88,7 @@ public function store(CreateTaskRequest $request) private function fill($input) { - $input['status'] = (isset($input['status']) && !empty($input['status'])) ? $input['status'] : 0; + $input['status'] = (isset($input['status']) && !empty($input['status'])) ? $input['status'] : Task::STATUS_ACTIVE; $input['description'] = is_null($input['description']) ? '' : $input['description']; return $input; diff --git a/database/factories/TaskFactory.php b/database/factories/TaskFactory.php index 1fec508ac..6c6636a7c 100644 --- a/database/factories/TaskFactory.php +++ b/database/factories/TaskFactory.php @@ -10,7 +10,6 @@ $factory->define(Task::class, function (Faker $faker) { $project = factory(Project::class)->create(); - $dueDate = date('Y-m-d H:i:s', strtotime('+ 4hours')); $dueDate = date('Y-m-d H:i:s', strtotime('+ 4hours')); @@ -19,7 +18,7 @@ 'description' => $faker->text, 'project_id' => $project->id, 'due_date' => $dueDate, - 'status' => Task::STATUS_ALL, + 'status' => Task::STATUS_ACTIVE, 'task_number' => $faker->unique()->randomDigitNotNull, ]; }); diff --git a/database/migrations/2019_09_13_054205_update_task_status_field_value.php b/database/migrations/2019_09_13_054205_update_task_status_field_value.php new file mode 100644 index 000000000..0cec073ad --- /dev/null +++ b/database/migrations/2019_09_13_054205_update_task_status_field_value.php @@ -0,0 +1,30 @@ +integer('status')->default(0)->change(); + }); + } + + /** + * Reverse the migrations. + * + * @return void + */ + public function down() + { + Schema::table('tasks', function ($table) { + $table->integer('status')->default(2)->change(); + }); + } +} diff --git a/tests/Controllers/TaskControllerTest.php b/tests/Controllers/TaskControllerTest.php index b058070c5..0ecd0ee08 100644 --- a/tests/Controllers/TaskControllerTest.php +++ b/tests/Controllers/TaskControllerTest.php @@ -34,10 +34,8 @@ public function test_can_filter_tasks_by_task_status() $project->users()->sync([$this->loggedInUserId]); /** @var Task $activeTask */ - $activeTask = factory(Task::class)->create([ - 'status' => Task::STATUS_ACTIVE, - 'project_id' => $project->id, - ]); + $activeTask = factory(Task::class)->create(['project_id' => $project->id]); + /** @var Task $completedTask */ $completedTask = factory(Task::class)->create([ 'status' => Task::STATUS_COMPLETED, diff --git a/tests/Controllers/TimeEntryControllerTest.php b/tests/Controllers/TimeEntryControllerTest.php index 80ef68588..a4bf48d40 100644 --- a/tests/Controllers/TimeEntryControllerTest.php +++ b/tests/Controllers/TimeEntryControllerTest.php @@ -45,9 +45,7 @@ public function test_can_filter_time_entries_by_project_with_permission() $this->withHeaders(['X-Requested-With' => 'XMLHttpRequest']); /** @var Task $task */ - $task = factory(Task::class)->create([ - 'status' => Task::STATUS_ACTIVE, - ]); + $task = factory(Task::class)->create(); $task->taskAssignee()->sync([$this->loggedInUserId]); /** @var TimeEntry $firstTimeEntry */ diff --git a/tests/Controllers/Validations/TaskControllerValidationTest.php b/tests/Controllers/Validations/TaskControllerValidationTest.php index 8748b9bbc..14b1afde5 100644 --- a/tests/Controllers/Validations/TaskControllerValidationTest.php +++ b/tests/Controllers/Validations/TaskControllerValidationTest.php @@ -125,7 +125,7 @@ public function it_can_update_task_with_valid_project_id() public function it_can_update_task_status_from_active_to_completed() { /** @var Task $task */ - $task = factory(Task::class)->create(['status' => Task::STATUS_ACTIVE]); + $task = factory(Task::class)->create(); $this->post(route('task.update-status', $task->id), [])->assertSessionHasNoErrors(); diff --git a/tests/Repositories/TaskRepositoryTest.php b/tests/Repositories/TaskRepositoryTest.php index a81d33b6c..a561c63c1 100644 --- a/tests/Repositories/TaskRepositoryTest.php +++ b/tests/Repositories/TaskRepositoryTest.php @@ -260,7 +260,7 @@ public function test_can_get_task_details_of_given_user() public function test_can_update_task_status() { /** @var Task $task */ - $task = factory(Task::class)->create(['status' => Task::STATUS_ACTIVE]); + $task = factory(Task::class)->create(); $updatedTaskStatus = $this->taskRepo->updateStatus($task->id); diff --git a/tests/Repositories/TimeEntryRepositoryTest.php b/tests/Repositories/TimeEntryRepositoryTest.php index e179d38a6..dae0e9272 100644 --- a/tests/Repositories/TimeEntryRepositoryTest.php +++ b/tests/Repositories/TimeEntryRepositoryTest.php @@ -64,10 +64,10 @@ public function test_can_get_details_of_given_time_entry() public function test_can_get_active_task_of_logged_in_user_for_given_project() { $vishal = factory(User::class)->create(); - $task1 = factory(Task::class)->create(['status' => Task::STATUS_ACTIVE]); + $task1 = factory(Task::class)->create(); $task1->taskAssignee()->attach($vishal->id); - $task2 = factory(Task::class)->create(['status' => Task::STATUS_ACTIVE]); + $task2 = factory(Task::class)->create(); $task2->taskAssignee()->attach($this->defaultUserId); $completedTask = factory(Task::class)->create(['status' => Task::STATUS_COMPLETED]); // this should not return $completedTask->taskAssignee()->attach($this->defaultUserId); @@ -80,9 +80,9 @@ public function test_can_get_active_task_of_logged_in_user_for_given_project() /** @test */ public function test_can_get_specific_active_task_of_logged_in_user_for_given_project() { - $task1 = factory(Task::class)->create(['status' => Task::STATUS_ACTIVE]); + $task1 = factory(Task::class)->create(); $task1->taskAssignee()->attach($this->defaultUserId); - $task2 = factory(Task::class)->create(['status' => Task::STATUS_ACTIVE]); + $task2 = factory(Task::class)->create(); $task2->taskAssignee()->attach($this->defaultUserId); $result = $this->timeEntryRepo->getTasksByProject($task2->project_id, $task2->id); @@ -95,10 +95,10 @@ public function test_can_get_active_task_of_logged_in_user_having_manage_project { $monika = factory(User::class)->create(); - $task1 = factory(Task::class)->create(['status' => Task::STATUS_ACTIVE]); + $task1 = factory(Task::class)->create(); $task1->taskAssignee()->attach($monika->id); - $task2 = factory(Task::class)->create(['status' => Task::STATUS_ACTIVE, 'project_id' => $task1->project_id]); + $task2 = factory(Task::class)->create(['project_id' => $task1->project_id]); $task2->taskAssignee()->attach($this->defaultUserId); $completedTask = factory(Task::class)->create(['status' => Task::STATUS_COMPLETED]); // this should not return $completedTask->taskAssignee()->attach($this->defaultUserId); From db13734f26cbe55a9bcd3ad209e75e1aa2c41329 Mon Sep 17 00:00:00 2001 From: Farhan Kathawala <37834439+farhaninfyom@users.noreply.github.com> Date: Fri, 13 Sep 2019 18:14:50 +0530 Subject: [PATCH 18/23] docs: model docs added (#365) --- app/Models/Comment.php | 3 +++ app/Models/Report.php | 6 ++++++ app/Models/Task.php | 2 +- app/Models/TaskAttachment.php | 6 ++++++ 4 files changed, 16 insertions(+), 1 deletion(-) diff --git a/app/Models/Comment.php b/app/Models/Comment.php index baa8ca497..f5210c0f3 100644 --- a/app/Models/Comment.php +++ b/app/Models/Comment.php @@ -65,6 +65,9 @@ public function task() return $this->belongsTo(Task::class, 'task_id'); } + /** + * @return string + */ public function getUserAvatarAttribute() { return getUserImageInitial($this->created_by, $this->createdUser->name); diff --git a/app/Models/Report.php b/app/Models/Report.php index ab20d4ef4..a5d951c16 100644 --- a/app/Models/Report.php +++ b/app/Models/Report.php @@ -76,11 +76,17 @@ public function projects() return $this->belongsToMany(Project::class, 'report_filters', 'report_id', 'param_id'); } + /** + * @return \Illuminate\Database\Eloquent\Relations\BelongsTo + */ public function user() { return $this->belongsTo(User::class, 'owner_id'); } + /** + * @return string + */ public function getFormattedDateAttribute() { $startDate = Carbon::parse($this->start_date); diff --git a/app/Models/Task.php b/app/Models/Task.php index 6aa469ac4..e80362a6c 100644 --- a/app/Models/Task.php +++ b/app/Models/Task.php @@ -166,7 +166,7 @@ public static function boot() { parent::boot(); - static::deleting(function ($task) { + static::deleting(function (self $task) { $task->timeEntries()->update(['deleted_by' => getLoggedInUserId()]); $task->timeEntries()->delete(); }); diff --git a/app/Models/TaskAttachment.php b/app/Models/TaskAttachment.php index bce6e05fa..27d319e4f 100644 --- a/app/Models/TaskAttachment.php +++ b/app/Models/TaskAttachment.php @@ -41,11 +41,17 @@ class TaskAttachment extends Model 'file', ]; + /** + * @return string + */ public function getFilePathAttribute() { return Storage::path('attachments'.DIRECTORY_SEPARATOR.$this->file); } + /** + * @return string + */ public function getFileUrlAttribute() { return $this->imageUrl(self::PATH.DIRECTORY_SEPARATOR.$this->file); From 842b075dbd05715efdbb083372e1e7c9789c6d99 Mon Sep 17 00:00:00 2001 From: Farhan Kathawala <37834439+farhaninfyom@users.noreply.github.com> Date: Fri, 13 Sep 2019 18:15:54 +0530 Subject: [PATCH 19/23] docs: docs updated (#367) --- app/Queries/ActivityTypeDataTable.php | 5 +++++ app/Queries/RoleDataTable.php | 3 ++- app/Queries/TaskDataTable.php | 3 ++- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/app/Queries/ActivityTypeDataTable.php b/app/Queries/ActivityTypeDataTable.php index a8d0a46df..50a298d28 100644 --- a/app/Queries/ActivityTypeDataTable.php +++ b/app/Queries/ActivityTypeDataTable.php @@ -9,6 +9,11 @@ */ class ActivityTypeDataTable { + /** + * @param null $input + * + * @return ActivityType + */ public function get($input = null) { /** @var ActivityType $query */ diff --git a/app/Queries/RoleDataTable.php b/app/Queries/RoleDataTable.php index 58a77a0e8..6e3742cdc 100644 --- a/app/Queries/RoleDataTable.php +++ b/app/Queries/RoleDataTable.php @@ -3,6 +3,7 @@ namespace App\Queries; use App\Models\Role; +use Illuminate\Database\Eloquent\Builder; /** * Class RoleDataTable. @@ -10,7 +11,7 @@ class RoleDataTable { /** - * @return \Illuminate\Database\Eloquent\Builder + * @return Builder */ public function get() { diff --git a/app/Queries/TaskDataTable.php b/app/Queries/TaskDataTable.php index 08443b4de..068f6c7f8 100644 --- a/app/Queries/TaskDataTable.php +++ b/app/Queries/TaskDataTable.php @@ -14,7 +14,7 @@ class TaskDataTable /** * @param array $input * - * @return \Illuminate\Database\Eloquent\Builder + * @return Task */ public function get($input = []) { @@ -22,6 +22,7 @@ public function get($input = []) $projectRepo = app(ProjectRepository::class); $loginUserProjects = $projectRepo->getLoginUserAssignProjectsArr(); + /** @var Task $query */ $query = Task::whereIn('project_id', array_keys($loginUserProjects)) ->leftJoin('projects as p', 'p.id', '=', 'tasks.project_id') ->with(['project', 'taskAssignee', 'createdUser']) From ad662b3028638835c0612c31617b9ee4026e600c Mon Sep 17 00:00:00 2001 From: Farhan Kathawala <37834439+farhaninfyom@users.noreply.github.com> Date: Fri, 13 Sep 2019 18:25:45 +0530 Subject: [PATCH 20/23] refactor: refactor repositories code (#369) --- app/Models/Task.php | 6 +++++- app/Repositories/AccountRepository.php | 6 +++--- app/Repositories/ActivityTypeRepository.php | 3 ++- app/Repositories/ClientRepository.php | 6 ++++-- app/Repositories/PermissionRepository.php | 3 ++- app/Repositories/ProjectRepository.php | 3 ++- app/Repositories/TagRepository.php | 2 ++ app/Repositories/TimeEntryRepository.php | 3 ++- app/Repositories/UserRepository.php | 2 +- 9 files changed, 23 insertions(+), 11 deletions(-) diff --git a/app/Models/Task.php b/app/Models/Task.php index e80362a6c..4e1567df5 100644 --- a/app/Models/Task.php +++ b/app/Models/Task.php @@ -54,6 +54,8 @@ * * @property string|null $task_number * @property string|null $priority + * @property int $totalDuration + * @property int $totalDurationMin * * @method static \Illuminate\Database\Eloquent\Builder|\App\Models\Task wherePriority($value) * @@ -75,7 +77,9 @@ class Task extends Model self::STATUS_ACTIVE => 'Pending', self::STATUS_COMPLETED => 'Completed', ]; - const PRIORITY = ['highest' => 'HIGHEST', 'high' => 'HIGH', 'medium' => 'MEDIUM', 'low' => 'LOW', 'lowest' => 'LOWEST']; + const PRIORITY = [ + 'highest' => 'HIGHEST', 'high' => 'HIGH', 'medium' => 'MEDIUM', 'low' => 'LOW', 'lowest' => 'LOWEST', + ]; const PATH = 'attachments'; public $table = 'tasks'; diff --git a/app/Repositories/AccountRepository.php b/app/Repositories/AccountRepository.php index 7b66b5e01..ac1d90c77 100644 --- a/app/Repositories/AccountRepository.php +++ b/app/Repositories/AccountRepository.php @@ -2,8 +2,8 @@ namespace App\Repositories; -use App; use Exception; +use Illuminate\Mail\Message; use Mail; use URL; @@ -23,11 +23,11 @@ public function sendConfirmEmail($username, $email, $activateCode) try { Mail::send('auth.emails.account_verification', ['data' => $data], - function ($message) use ($email) { + function (Message $message) use ($email) { $message->subject('Activate your account'); $message->to($email); }); - } catch (\Exception $e) { + } catch (Exception $e) { throw new Exception('Account created, but unable to send email'); } } diff --git a/app/Repositories/ActivityTypeRepository.php b/app/Repositories/ActivityTypeRepository.php index 9dbae75b4..da6ed5bc2 100644 --- a/app/Repositories/ActivityTypeRepository.php +++ b/app/Repositories/ActivityTypeRepository.php @@ -3,6 +3,7 @@ namespace App\Repositories; use App\Models\ActivityType; +use Illuminate\Support\Collection; /** * Class ActivityTypeRepository. @@ -39,7 +40,7 @@ public function model() /** * get activity types. * - * @return \Illuminate\Support\Collection + * @return Collection */ public function getActivityTypeList() { diff --git a/app/Repositories/ClientRepository.php b/app/Repositories/ClientRepository.php index 8f0f70977..1823baa93 100644 --- a/app/Repositories/ClientRepository.php +++ b/app/Repositories/ClientRepository.php @@ -6,6 +6,8 @@ use App\Models\Project; use App\Models\Task; use App\Models\TimeEntry; +use Exception; +use Illuminate\Support\Collection; /** * Class ClientRepository. @@ -44,7 +46,7 @@ public function model() /** * get clients. * - * @return \Illuminate\Support\Collection + * @return Collection */ public function getClientList() { @@ -54,7 +56,7 @@ public function getClientList() /** * @param int $clientId * - * @throws \Exception + * @throws Exception * * @return bool|mixed|void|null */ diff --git a/app/Repositories/PermissionRepository.php b/app/Repositories/PermissionRepository.php index a71755318..67e3bebb5 100644 --- a/app/Repositories/PermissionRepository.php +++ b/app/Repositories/PermissionRepository.php @@ -3,6 +3,7 @@ namespace App\Repositories; use App\Models\Permission; +use Illuminate\Support\Collection; /** * Class PermissionRepository. @@ -37,7 +38,7 @@ public function model() } /** - * @return \Illuminate\Support\Collection + * @return Collection */ public function permissionList() { diff --git a/app/Repositories/ProjectRepository.php b/app/Repositories/ProjectRepository.php index cfe83c0a8..ea99d3a77 100644 --- a/app/Repositories/ProjectRepository.php +++ b/app/Repositories/ProjectRepository.php @@ -6,6 +6,7 @@ use App\Models\Task; use App\Models\TimeEntry; use Auth; +use Exception; use Illuminate\Database\Eloquent\Builder; use Illuminate\Support\Collection; @@ -94,7 +95,7 @@ public function getProjectsList($clientId = null) /** * @param int $id * - * @throws \Exception + * @throws Exception * * @return bool|mixed|void|null */ diff --git a/app/Repositories/TagRepository.php b/app/Repositories/TagRepository.php index 7997cb1c9..7f239bfa4 100644 --- a/app/Repositories/TagRepository.php +++ b/app/Repositories/TagRepository.php @@ -61,6 +61,8 @@ public function store($input) $input['created_by'] = getLoggedInUserId(); Tag::create($input); + + return true; } /** diff --git a/app/Repositories/TimeEntryRepository.php b/app/Repositories/TimeEntryRepository.php index 1f85bc765..c865f5136 100644 --- a/app/Repositories/TimeEntryRepository.php +++ b/app/Repositories/TimeEntryRepository.php @@ -142,7 +142,8 @@ public function updateTimeEntry($input, $id) { /** @var TimeEntry $timeEntry */ $timeEntry = $this->find($id); - $timeEntryType = ($timeEntry->entry_type == TimeEntry::STOPWATCH) ? $this->checkTimeUpdated($timeEntry, $input) : $timeEntry->entry_type; + $timeEntryType = ($timeEntry->entry_type == TimeEntry::STOPWATCH) ? $this->checkTimeUpdated($timeEntry, + $input) : $timeEntry->entry_type; $input['entry_type'] = $timeEntryType; if ((isset($input['duration']) && !empty($input['duration'])) && (!isset($input['start_time']) || empty($input['start_time']) || !isset($input['end_time']) || empty($input['end_time']))) { if ($timeEntry->duration != $input['duration']) { diff --git a/app/Repositories/UserRepository.php b/app/Repositories/UserRepository.php index 8f9e474e9..600a19219 100644 --- a/app/Repositories/UserRepository.php +++ b/app/Repositories/UserRepository.php @@ -80,7 +80,7 @@ public function setUserPassword($input) $user->set_password = true; $user->save(); - \Auth::login($user); + Auth::login($user); return true; } From 3b028f92855e726fd1321d5f2c0fc1223c82f40d Mon Sep 17 00:00:00 2001 From: Farhan Kathawala <37834439+farhaninfyom@users.noreply.github.com> Date: Fri, 13 Sep 2019 18:26:12 +0530 Subject: [PATCH 21/23] test(tasks): tasks test cases (#364) --- .../TimeEntryControllerValidationTest.php | 1 - tests/Repositories/TaskRepositoryTest.php | 23 +++++++++++++--- .../Repositories/TimeEntryRepositoryTest.php | 27 +++++++++++++++++++ 3 files changed, 46 insertions(+), 5 deletions(-) diff --git a/tests/Controllers/Validations/TimeEntryControllerValidationTest.php b/tests/Controllers/Validations/TimeEntryControllerValidationTest.php index 9458d7fd4..e70ef665d 100644 --- a/tests/Controllers/Validations/TimeEntryControllerValidationTest.php +++ b/tests/Controllers/Validations/TimeEntryControllerValidationTest.php @@ -149,7 +149,6 @@ public function test_update_time_entry_fails_when_task_id_is_not_passed() /** @test */ public function test_user_with_valid_permission_can_update_other_users_time_entry() { - $this->attachPermissions(getLoggedInUserId(), ['manage_projects']); /** @var TimeEntry $timeEntry1 */ $timeEntry1 = factory(TimeEntry::class)->create(); $timeEntry2 = factory(TimeEntry::class)->create(['user_id' => $this->defaultUserId]); diff --git a/tests/Repositories/TaskRepositoryTest.php b/tests/Repositories/TaskRepositoryTest.php index a561c63c1..9397ee6ab 100644 --- a/tests/Repositories/TaskRepositoryTest.php +++ b/tests/Repositories/TaskRepositoryTest.php @@ -220,8 +220,6 @@ public function test_user_with_manage_project_permission_can_get_all_active_task $activeTask = factory(Task::class)->create(); $activeTask->taskAssignee()->sync([$monika->id]); - $this->attachPermissions($this->defaultUserId, ['manage_projects']); - $completedTask = factory(Task::class)->create(['status' => Task::STATUS_COMPLETED]); $completedTask->taskAssignee()->sync([$monika->id]); @@ -230,6 +228,25 @@ public function test_user_with_manage_project_permission_can_get_all_active_task $this->assertCount(2, $myTasks['tasks']); } + /** @test */ + public function test_can_get_only_active_tasks_of_logged_in_user_without_permission() + { + $activeTaskOfAnotherUser = factory(Task::class)->create(); + $activeTaskOfAnotherUser->taskAssignee()->sync([$this->defaultUserId]); + + $farhan = factory(User::class)->create(); + $this->actingAs($farhan); + $activeTask = factory(Task::class)->create(); + $activeTask->taskAssignee()->sync([$farhan->id]); + + $completedTask = factory(Task::class)->create(['status' => Task::STATUS_COMPLETED]); + $completedTask->taskAssignee()->sync([$farhan->id]); + + $myTasks = $this->taskRepo->myTasks(); + + $this->assertCount(1, $myTasks['tasks']); + } + /** @test */ public function test_can_get_task_details_with_task_duration() { @@ -283,7 +300,6 @@ public function test_tags_are_created_and_attached_to_given_task() $attachedTag = $task->fresh()->tags; $this->assertNotEmpty($attachedTag); - $this->assertEquals($tag->name, $attachedTag[0]['name']); } @@ -300,7 +316,6 @@ public function test_existing_tags_are_attached_to_given_task() $attachedTag = $task->fresh()->tags; $this->assertNotEmpty($attachedTag); - $this->assertEquals($tag->id, $attachedTag[0]['id']); } } diff --git a/tests/Repositories/TimeEntryRepositoryTest.php b/tests/Repositories/TimeEntryRepositoryTest.php index dae0e9272..d2e2ee2e8 100644 --- a/tests/Repositories/TimeEntryRepositoryTest.php +++ b/tests/Repositories/TimeEntryRepositoryTest.php @@ -2,6 +2,7 @@ namespace Tests\Repositories; +use App\Models\Project; use App\Models\Task; use App\Models\TimeEntry; use App\Models\User; @@ -73,10 +74,35 @@ public function test_can_get_active_task_of_logged_in_user_for_given_project() $completedTask->taskAssignee()->attach($this->defaultUserId); $result = $this->timeEntryRepo->getTasksByProject($task2->project_id); + $this->assertCount(1, $result); $this->assertContains($task2->id, $result->keys()); } + /** @test */ + public function test_can_get_active_task_of_logged_in_user_for_given_project_without_permission() + { + $project = factory(Project::class)->create(); + $activeTaskOfAnotherUser = factory(Task::class)->create(['project_id' => $project->id]); + $activeTaskOfAnotherUser->taskAssignee()->attach($this->defaultUserId); + + $farhan = factory(User::class)->create(); + $this->actingAs($farhan); + $activeTask = factory(Task::class)->create(['project_id' => $project->id]); + $activeTask->taskAssignee()->attach($farhan->id); + + $completedTask = factory(Task::class)->create([ + 'project_id' => $project->id, + 'status' => Task::STATUS_COMPLETED, + ]); + $completedTask->taskAssignee()->attach($farhan->id); + + $tasks = $this->timeEntryRepo->getTasksByProject($project->id); + + $this->assertCount(1, $tasks); + $this->assertContains($activeTask->id, $tasks->keys()); + } + /** @test */ public function test_can_get_specific_active_task_of_logged_in_user_for_given_project() { @@ -86,6 +112,7 @@ public function test_can_get_specific_active_task_of_logged_in_user_for_given_pr $task2->taskAssignee()->attach($this->defaultUserId); $result = $this->timeEntryRepo->getTasksByProject($task2->project_id, $task2->id); + $this->assertCount(1, $result); $this->assertContains($task2->id, $result->keys()); } From b411a9a709802b148da7912930e54eafd85f9e31 Mon Sep 17 00:00:00 2001 From: Farhan Kathawala <37834439+farhaninfyom@users.noreply.github.com> Date: Fri, 13 Sep 2019 18:30:31 +0530 Subject: [PATCH 22/23] docs: docs updated (#371) --- app/Http/Controllers/AuthController.php | 7 +++-- app/Http/Controllers/CommentController.php | 15 ++++++---- app/Http/Controllers/HomeController.php | 8 ++++-- app/Http/Controllers/ReportController.php | 5 +++- app/Http/Controllers/RoleController.php | 11 +++++--- app/Http/Controllers/TaskController.php | 2 +- app/Http/Controllers/TimeEntryController.php | 29 ++++++++++++-------- app/Http/Controllers/UserController.php | 15 ++++++---- app/helpers.php | 4 ++- 9 files changed, 61 insertions(+), 35 deletions(-) diff --git a/app/Http/Controllers/AuthController.php b/app/Http/Controllers/AuthController.php index a62c3ecf8..80ccb6af6 100644 --- a/app/Http/Controllers/AuthController.php +++ b/app/Http/Controllers/AuthController.php @@ -7,7 +7,10 @@ use App\Repositories\UserRepository; use Crypt; use Exception; +use Illuminate\Http\RedirectResponse; use Illuminate\Http\Request; +use Illuminate\Routing\Redirector; +use Illuminate\View\View; use Session; class AuthController extends AppBaseController @@ -27,7 +30,7 @@ public function __construct(AccountRepository $accountRepository, UserRepository } /** - * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector|\Illuminate\View\View + * @return RedirectResponse|Redirector|View */ public function verifyAccount() { @@ -84,7 +87,7 @@ public function verifyAccount() * * @throws Exception * - * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector + * @return RedirectResponse|Redirector */ public function setPassword(Request $request) { diff --git a/app/Http/Controllers/CommentController.php b/app/Http/Controllers/CommentController.php index 85ae27c61..4cd58a90d 100644 --- a/app/Http/Controllers/CommentController.php +++ b/app/Http/Controllers/CommentController.php @@ -5,6 +5,9 @@ use App\Models\Comment; use App\Models\Task; use App\Repositories\TaskRepository; +use Auth; +use Exception; +use Illuminate\Http\JsonResponse; use Illuminate\Http\Request; use Symfony\Component\HttpKernel\Exception\UnprocessableEntityHttpException; @@ -22,7 +25,7 @@ public function __construct(TaskRepository $taskRepo) * @param Task $task * @param Request $request * - * @return \Illuminate\Http\JsonResponse + * @return JsonResponse */ public function addComment(Task $task, Request $request) { @@ -38,13 +41,13 @@ public function addComment(Task $task, Request $request) * @param Task $task * @param Comment $comment * - * @throws \Exception + * @throws Exception * - * @return \Illuminate\Http\JsonResponse + * @return JsonResponse */ public function deleteComment(Task $task, Comment $comment) { - if ($comment->task_id != $task->id || $comment->created_by != \Auth::user()->id) { + if ($comment->task_id != $task->id || $comment->created_by != Auth::user()->id) { throw new UnprocessableEntityHttpException('Unable to delete comment.'); } @@ -59,11 +62,11 @@ public function deleteComment(Task $task, Comment $comment) * @param Comment $comment * @param Request $request * - * @return \Illuminate\Http\JsonResponse + * @return JsonResponse */ public function editComment(Task $task, Comment $comment, Request $request) { - if ($comment->task_id != $task->id || $comment->created_by != \Auth::user()->id) { + if ($comment->task_id != $task->id || $comment->created_by != Auth::user()->id) { throw new UnprocessableEntityHttpException('Unable to update comment.'); } diff --git a/app/Http/Controllers/HomeController.php b/app/Http/Controllers/HomeController.php index 4077c8ae6..f26d68c4f 100644 --- a/app/Http/Controllers/HomeController.php +++ b/app/Http/Controllers/HomeController.php @@ -5,7 +5,9 @@ use App\Repositories\DashboardRepository; use App\Repositories\UserRepository; use Auth; +use Illuminate\Http\JsonResponse; use Illuminate\Http\Request; +use Illuminate\Http\Response; class HomeController extends AppBaseController { @@ -31,7 +33,7 @@ public function __construct(DashboardRepository $dashboardRepository, UserReposi /** * Show the application dashboard. * - * @return \Illuminate\Http\Response + * @return Response */ public function index() { @@ -43,7 +45,7 @@ public function index() /** * @param Request $request * - * @return \Illuminate\Http\JsonResponse + * @return JsonResponse */ public function workReport(Request $request) { @@ -58,7 +60,7 @@ public function workReport(Request $request) /** * @param Request $request * - * @return \Illuminate\Http\JsonResponse + * @return JsonResponse */ public function developerWorkReport(Request $request) { diff --git a/app/Http/Controllers/ReportController.php b/app/Http/Controllers/ReportController.php index 58bc20877..a7223db8d 100644 --- a/app/Http/Controllers/ReportController.php +++ b/app/Http/Controllers/ReportController.php @@ -17,7 +17,10 @@ use DataTables; use Exception; use Flash; +use Illuminate\Http\JsonResponse; +use Illuminate\Http\RedirectResponse; use Illuminate\Http\Request; +use Illuminate\Routing\Redirector; use Response; class ReportController extends AppBaseController @@ -177,7 +180,7 @@ public function update(Report $report, UpdateReportRequest $request) * * @throws Exception * - * @return \Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector + * @return JsonResponse|RedirectResponse|Redirector */ public function destroy(Report $report) { diff --git a/app/Http/Controllers/RoleController.php b/app/Http/Controllers/RoleController.php index 4cd68137f..f0934eca7 100644 --- a/app/Http/Controllers/RoleController.php +++ b/app/Http/Controllers/RoleController.php @@ -12,7 +12,10 @@ use DataTables; use Exception; use Flash; +use Illuminate\Http\JsonResponse; +use Illuminate\Http\RedirectResponse; use Illuminate\Http\Request; +use Illuminate\Routing\Redirector; use Response; use Symfony\Component\HttpKernel\Exception\BadRequestHttpException; @@ -106,10 +109,10 @@ public function edit(Role $role) } /** - * @param Role $role - * @param Request $request + * @param Role $role + * @param UpdateRoleRequest $request * - * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector + * @return RedirectResponse|Redirector */ public function update(Role $role, UpdateRoleRequest $request) { @@ -131,7 +134,7 @@ public function update(Role $role, UpdateRoleRequest $request) * * @throws Exception * - * @return \Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector + * @return JsonResponse|RedirectResponse|Redirector */ public function destroy(Role $role) { diff --git a/app/Http/Controllers/TaskController.php b/app/Http/Controllers/TaskController.php index bbdd69bec..0a3af2a51 100644 --- a/app/Http/Controllers/TaskController.php +++ b/app/Http/Controllers/TaskController.php @@ -55,7 +55,7 @@ public function index(Request $request) })->filterColumn('title', function ($query, $search) { $query->where(function ($query) use ($search) { $query->where('title', 'like', "%$search%") - ->orWhereRaw("concat(ifnull(p.prefix,''),'-',ifnull(tasks.task_number,'')) LIKE ?", + ->orWhereRaw("concat(if null(p.prefix,''),'-',if null(tasks.task_number,'')) LIKE ?", ["%$search%"]); }); }) diff --git a/app/Http/Controllers/TimeEntryController.php b/app/Http/Controllers/TimeEntryController.php index c767b9f31..014edb755 100644 --- a/app/Http/Controllers/TimeEntryController.php +++ b/app/Http/Controllers/TimeEntryController.php @@ -10,9 +10,13 @@ use Auth; use Carbon\Carbon; use DataTables; +use Exception; +use Illuminate\Contracts\View\Factory; +use Illuminate\Http\JsonResponse; use Illuminate\Http\Request; use Illuminate\Http\Response; use Illuminate\Validation\UnauthorizedException; +use Illuminate\View\View; use Log; use Symfony\Component\HttpKernel\Exception\BadRequestHttpException; @@ -31,9 +35,9 @@ public function __construct(TimeEntryRepository $timeEntryRepo) * * @param Request $request * - * @throws \Exception + * @throws Exception * - * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View + * @return Factory|View */ public function index(Request $request) { @@ -53,7 +57,7 @@ public function index(Request $request) * * @param CreateTimeEntryRequest $request * - * @return \Illuminate\Http\JsonResponse + * @return JsonResponse */ public function store(CreateTimeEntryRequest $request) { @@ -70,7 +74,7 @@ public function store(CreateTimeEntryRequest $request) * * @param TimeEntry $timeEntry * - * @return \Illuminate\Http\JsonResponse + * @return JsonResponse */ public function edit(TimeEntry $timeEntry) { @@ -85,7 +89,7 @@ public function edit(TimeEntry $timeEntry) * @param TimeEntry $timeEntry * @param UpdateTimeEntryRequest $request * - * @return \Illuminate\Http\JsonResponse + * @return JsonResponse */ public function update(TimeEntry $timeEntry, UpdateTimeEntryRequest $request) { @@ -122,9 +126,9 @@ public function update(TimeEntry $timeEntry, UpdateTimeEntryRequest $request) /** * @param TimeEntry $timeEntry * - * @throws \Exception + * @throws Exception * - * @return \Illuminate\Http\JsonResponse + * @return JsonResponse */ public function destroy(TimeEntry $timeEntry) { @@ -140,8 +144,9 @@ public function destroy(TimeEntry $timeEntry) /** * @param array $input + * @param null $id * - * @return array|\Illuminate\Http\JsonResponse + * @return array|JsonResponse */ public function validateInput($input, $id = null) { @@ -180,7 +185,7 @@ public function validateInput($input, $id = null) } /** - * @return \Illuminate\Http\JsonResponse + * @return JsonResponse */ public function getUserLastTask() { @@ -193,7 +198,7 @@ public function getUserLastTask() * @param int $projectId * @param Request $request * - * @return \Illuminate\Http\JsonResponse + * @return JsonResponse */ public function getTasks($projectId, Request $request) { @@ -204,7 +209,9 @@ public function getTasks($projectId, Request $request) } /** - * @return \Illuminate\Http\JsonResponse + * @param Request $request + * + * @return JsonResponse */ public function getStartTimer(Request $request) { diff --git a/app/Http/Controllers/UserController.php b/app/Http/Controllers/UserController.php index c1395e02d..5eb110120 100644 --- a/app/Http/Controllers/UserController.php +++ b/app/Http/Controllers/UserController.php @@ -13,9 +13,12 @@ use App\Repositories\UserRepository; use Crypt; use DataTables; +use Exception; +use Illuminate\Contracts\View\Factory; use Illuminate\Http\JsonResponse; use Illuminate\Http\RedirectResponse; use Illuminate\Http\Request; +use Illuminate\View\View; class UserController extends AppBaseController { @@ -58,9 +61,9 @@ public function __construct( * * @param Request $request * - * @throws \Exception + * @throws Exception * - * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View + * @return Factory|View */ public function index(Request $request) { @@ -80,7 +83,7 @@ public function index(Request $request) * * @param CreateUserRequest $request * - * @throws \Exception + * @throws Exception * * @return JsonResponse */ @@ -134,7 +137,7 @@ public function edit(User $user) * @param User $user * @param UpdateUserRequest $request * - * @throws \Exception + * @throws Exception * * @return JsonResponse|RedirectResponse */ @@ -171,7 +174,7 @@ public function update(User $user, UpdateUserRequest $request) * * @param User $user * - * @throws \Exception + * @throws Exception * * @return JsonResponse */ @@ -187,7 +190,7 @@ public function destroy(User $user) /** * @param User $user * - * @throws \Exception + * @throws Exception * * @return JsonResponse */ diff --git a/app/helpers.php b/app/helpers.php index cd8a43dc0..238c6b77e 100644 --- a/app/helpers.php +++ b/app/helpers.php @@ -1,5 +1,7 @@ Date: Fri, 13 Sep 2019 18:31:34 +0530 Subject: [PATCH 23/23] refactor: get task details query refactored (#362) --- app/Repositories/TaskRepository.php | 34 ++++++++--------------------- 1 file changed, 9 insertions(+), 25 deletions(-) diff --git a/app/Repositories/TaskRepository.php b/app/Repositories/TaskRepository.php index e07e026ab..fbf34b7a2 100644 --- a/app/Repositories/TaskRepository.php +++ b/app/Repositories/TaskRepository.php @@ -269,32 +269,16 @@ public function attachTags($task, $tags) */ public function getTaskDetails($id, $input = []) { - if (isset($input['user_id']) && $input['user_id'] > 0) { - $task = Task::with([ - 'timeEntries' => function (HasMany $query) use ($input) { - $query->where('time_entries.user_id', '=', $input['user_id']); - if (isset($input['start_time']) && isset($input['end_time']) && !empty($input['start_time']) && !empty($input['end_time'])) { - $query->whereBetween('start_time', [$input['start_time'], $input['end_time']]); - } - $query->with('user'); - }, - 'project', - ])->findOrFail($id); - } else { - if (isset($input['start_time']) && isset($input['end_time']) && !empty($input['start_time']) && !empty($input['end_time'])) { - $task = Task::with([ - 'timeEntries' => function (HasMany $query) use ($input) { - if (isset($input['start_time']) && isset($input['end_time']) && !empty($input['start_time']) && !empty($input['end_time'])) { - $query->whereBetween('start_time', [$input['start_time'], $input['end_time']]); - } - $query->with('user'); - }, - 'project', - ])->findOrFail($id); - } else { - $task = Task::with('timeEntries.user', 'project')->findOrFail($id); + $task = Task::with(['timeEntries' => function (HasMany $query) use ($input) { + if (isset($input['user_id']) && $input['user_id'] > 0) { + $query->where('time_entries.user_id', '=', $input['user_id']); } - } + + if (!empty($input['start_time']) && !empty($input['end_time'])) { + $query->whereBetween('start_time', [$input['start_time'], $input['end_time']]); + } + $query->with('user'); + }])->findOrFail($id); $minutes = $task->timeEntries->pluck('duration')->sum(); $totalDuration = 0;
User Task ActivityEnd Time Duration (min) TypeCreated At ActionCreated At
Note Activity Tracked ByTime (Mins)Time
Activity Start Time End TimeDuration (min)Duration Type Action Created At