Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use new ldio features #14

Merged
merged 4 commits into from
Nov 14, 2024
Merged

chore: use new ldio features #14

merged 4 commits into from
Nov 14, 2024

Conversation

jobulcke
Copy link
Collaborator

No description provided.

@jobulcke jobulcke requested review from Yalz and rorlic as code owners October 23, 2024 14:31
Copy link

@Yalz Yalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would wait for ldi release...

@@ -63,7 +63,7 @@ services:
- "7200:7200"

ldio-workbench:
image: ldes/ldi-orchestrator:2.9.0-SNAPSHOT
image: ghcr.io/informatievlaanderen/ldi-orchestrator:20241021180535
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd wait when we have a release. We shouldn't be promoting dev images

@jobulcke jobulcke force-pushed the chore/use-new-ldio-features branch from cb47346 to b3950a2 Compare November 13, 2024 16:28
@jobulcke jobulcke merged commit 8f1caa0 into main Nov 14, 2024
2 checks passed
@jobulcke jobulcke deleted the chore/use-new-ldio-features branch November 14, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants