From aafe611d640ed82b285b74d48be17ce7a6f9d5e6 Mon Sep 17 00:00:00 2001
From: Keith Fung <keith.fung@infernored.com>
Date: Tue, 6 Aug 2024 11:21:01 -0400
Subject: [PATCH] Not Founds and 404s

---
 src/app/image/[id]/not-found.tsx | 27 +++++++++++++++++++++++++++
 src/app/image/[id]/page.tsx      |  7 +++++++
 src/app/not-found.tsx            | 27 +++++++++++++++++++++++++++
 src/utils/getImage.ts            | 12 +++++++-----
 4 files changed, 68 insertions(+), 5 deletions(-)
 create mode 100644 src/app/image/[id]/not-found.tsx
 create mode 100644 src/app/not-found.tsx

diff --git a/src/app/image/[id]/not-found.tsx b/src/app/image/[id]/not-found.tsx
new file mode 100644
index 0000000..bcdcf88
--- /dev/null
+++ b/src/app/image/[id]/not-found.tsx
@@ -0,0 +1,27 @@
+import React from "react";
+import { Metadata } from "next";
+import Link from "next/link";
+
+export const metadata: Metadata = {
+  title: "❓Image Not Found",
+  description: "Sorry, this image cannot be found.",
+};
+
+const NotFoundPage = () => {
+  return (
+    <div className="min-h-screen flex flex-col justify-center items-center">
+      <h1 className="text-6xl font-bold text-gray-900 mb-4">404</h1>
+      <p className="text-xl text-gray-600 mb-8">
+        Sorry, this image cannot be found.
+      </p>
+      <Link
+        href="/"
+        className="px-4 py-2 bg-red-600 text-white rounded hover:bg-red-700 transition"
+      >
+        Go back home
+      </Link>
+    </div>
+  );
+};
+
+export default NotFoundPage;
diff --git a/src/app/image/[id]/page.tsx b/src/app/image/[id]/page.tsx
index 2997d22..44ba9ce 100644
--- a/src/app/image/[id]/page.tsx
+++ b/src/app/image/[id]/page.tsx
@@ -6,6 +6,7 @@ import CAISummary from "@/components/CAISummary";
 import { getManifestStore } from "@/services/manifest";
 import getImage from "@/utils/getImage";
 import getMetadata from "@/utils/getMetadata";
+import { notFound } from "next/navigation";
 
 interface Params {
   params: {
@@ -15,12 +16,18 @@ interface Params {
 
 export async function generateMetadata({ params }: Params): Promise<Metadata> {
   const image = await getImage(params.id);
+  if (!image) {
+    return notFound();
+  }
   const manifestStore = await getManifestStore(image.src, image.mimeType);
   return getMetadata(manifestStore, image.src);
 }
 
 export default async function Home({ params }: Params) {
   const image = await getImage(params.id);
+  if (!image) {
+    return notFound();
+  }
   const manifestStore = await getManifestStore(image.src, image.mimeType);
 
   return (
diff --git a/src/app/not-found.tsx b/src/app/not-found.tsx
new file mode 100644
index 0000000..d9c8c1a
--- /dev/null
+++ b/src/app/not-found.tsx
@@ -0,0 +1,27 @@
+import React from "react";
+import { Metadata } from "next";
+import Link from "next/link";
+
+export const metadata: Metadata = {
+  title: "Page Not Found",
+  description: "Sorry, this page cannot be found.",
+};
+
+const NotFoundPage = () => {
+  return (
+    <div className="min-h-screen flex flex-col justify-center items-center">
+      <h1 className="text-6xl font-bold text-gray-900 mb-4">404</h1>
+      <p className="text-xl text-gray-600 mb-8">
+        Sorry, this page cannot be found.
+      </p>
+      <Link
+        href="/"
+        className="px-4 py-2 bg-red-600 text-white rounded hover:bg-red-700 transition"
+      >
+        Go back home
+      </Link>
+    </div>
+  );
+};
+
+export default NotFoundPage;
diff --git a/src/utils/getImage.ts b/src/utils/getImage.ts
index 98b40f6..16d4409 100644
--- a/src/utils/getImage.ts
+++ b/src/utils/getImage.ts
@@ -1,11 +1,13 @@
-import sampleImages from "@/constants/sampleImages";
+import sampleImages, { SampleImage } from "@/constants/sampleImages";
 
-export default async function getImage(id: string) {
+export default async function getImage(
+  id: string
+): Promise<SampleImage | undefined> {
   const numericId = Number(id) - 1;
 
-  if (isNaN(numericId) || numericId < 0) {
-    return sampleImages[0]; // fallback
+  if (isNaN(numericId) || numericId < 0 || numericId >= sampleImages.length) {
+    return undefined;
   }
 
-  return sampleImages[numericId % sampleImages.length];
+  return sampleImages[numericId];
 }