You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, l’m having an issue with the translation checker bundle, especially with the compare feature which is not working anymore on our project.
Context
Currently we're working with the following component versions :
Symfony 5.4
Incenteev/translation-checker-bundle 1.7
Symfony/translation 5.4.7
After an update of our project dependencies, the compare feature now end with all the translations missing. So i checked which has changed and since the 5.4.2 release of the translation component of Symfony, there were changes in their methods to retrieve the list of domains to handle potential ICU domains.
So, we had to fix symfony/translation bundle to 5.4.1 version to keep the good behavior of your bundle with the compare command which is not a good long-term solution.
Expected behavior
In the CompareCommand.php, the domains variable should retrieve all the domains available in the catalogue.
Current behavior
Since thoses changes from symfony/translation this domains variable, which use the getDomains() method from AbstractOperation.php, retrieve all the domains that we had before and duplicate all of them with the +intl-icu suffix.
Then, the compare command find all translations missing on those "new" domains.
Thank you in advance for your help ! 😃
The text was updated successfully, but these errors were encountered:
Hello, l’m having an issue with the translation checker bundle, especially with the compare feature which is not working anymore on our project.
Context
Currently we're working with the following component versions :
Symfony 5.4
Incenteev/translation-checker-bundle 1.7
Symfony/translation 5.4.7
After an update of our project dependencies, the compare feature now end with all the translations missing. So i checked which has changed and since the 5.4.2 release of the translation component of Symfony, there were changes in their methods to retrieve the list of domains to handle potential ICU domains.
So, we had to fix
symfony/translation
bundle to 5.4.1 version to keep the good behavior of your bundle with the compare command which is not a good long-term solution.Expected behavior
In the
CompareCommand.php
, the domains variable should retrieve all the domains available in the catalogue.Current behavior
Since thoses changes from symfony/translation this domains variable, which use the
getDomains()
method fromAbstractOperation.php
, retrieve all the domains that we had before and duplicate all of them with the +intl-icu suffix.Then, the compare command find all translations missing on those "new" domains.
Thank you in advance for your help ! 😃
The text was updated successfully, but these errors were encountered: