Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for nan values before running the soil model #536

Open
vgro opened this issue Aug 6, 2024 · 0 comments
Open

Add check for nan values before running the soil model #536

vgro opened this issue Aug 6, 2024 · 0 comments

Comments

@vgro
Copy link
Collaborator

vgro commented Aug 6, 2024

Is your feature request related to a problem? Please describe.
The soil model integration function runs into an endless loop when it is fed with NaN values without giving any indication of what is going wrong. This has happened a few times when changes were made in other models and it took quite some time to find the bug.

Describe the solution you'd like
We would like the functions that are affected to check if there are NaN values in the input before it starts and throw an error message and exit the model run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants