You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The OSM rivers layer seems a bit temperamental - the ones that it has are accurate but it is missing obvious ones. Something like pysheds and presumably pyflwdir enable river creation - this might be more reliable.
Also should be something to handle no rivers present - I guess related to #125 . It also seems that this error is now out of date so the try/except isn't working.
The text was updated successfully, but these errors were encountered:
Initial check of this is promising - though probably will also need to include the rivers in the SWMM model as the generated rivers can go quite deep into the catchments - maybe this is not so difficult with #84
And a test:
deftest_derive_subbasins():
"""Test the derive_subbasins_streamorder function."""elevation_fid=Path(__file__).parent/'test_data'/'elevation.tif'basins, streams=go.derive_subbasins_streamorder(elevation_fid,3)
assertbasins.shape[0] ==5assertstreams.shape[0] ==6assert (streams.strord>=3).all()
The OSM rivers layer seems a bit temperamental - the ones that it has are accurate but it is missing obvious ones. Something like
pysheds
and presumablypyflwdir
enable river creation - this might be more reliable.Also should be something to handle no rivers present - I guess related to #125 . It also seems that this error is now out of date so the
try/except
isn't working.The text was updated successfully, but these errors were encountered: