Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential for tidy up #26

Closed
IdlePhysicist opened this issue Sep 4, 2020 · 0 comments
Closed

Potential for tidy up #26

IdlePhysicist opened this issue Sep 4, 2020 · 0 comments

Comments

@IdlePhysicist
Copy link
Owner

IdlePhysicist commented Sep 4, 2020

Regarding model.Statistic

$ grep -R Statis .
./internal/gui/gui.go:	//statsLocations []*model.Statistic
./internal/db/db.go:func (db *Database) GetTopPeople() ([]*model.Statistic, error) {
./internal/db/db.go:	cavers := make([]*model.Statistic, 0)
./internal/db/db.go:		var c model.Statistic
./internal/db/db.go:func (db *Database) GetTopLocations() ([]*model.Statistic, error) {
./internal/db/db.go:	stats := make([]*model.Statistic, 0)
./internal/db/db.go:		var s model.Statistic
./internal/model/gui.go:type Statistic struct {

Whether this is removed depends on how #24 progresses in development.
I don’t believe that this needs to be on the v2 milestone as these structs and functions may survive in some manner (based on #24 once again).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant