Handle unknown sla results correctly

Author: yhabteab

library/Icingadb/ProvidedHook/Reporting/Common/ReportData.php

@@ -24,10 +24,18 @@ public function getAverages()
                 $problemTime += $timeline->getProblemTime();
             }
 
+            if ($totalTime <= 0) {
+                continue;
+            }
+
             ++$count;
             $totals += 100 * ($totalTime - $problemTime) / $totalTime;
         }
 
+        if ($count === 0) {
+            return [null];
+        }
+
         return [$totals / $count];
     }
 }

library/Icingadb/ProvidedHook/Reporting/Common/SlaReportUtils.php

@@ -179,11 +179,15 @@ protected function fetchReportData(DateTime $reportStart, DateTime $reportEnd, a
                 }
 
                 foreach ($reports as $name => $timeline) {
-                    $rd->addTimeline($name, $timeline);
                     $row = (object) [];
-                    $row->sla = $timeline->getResult();
                     $row->display_name = $name;
+                    $row->sla = $timeline->getResult();
+                    if ($row->sla === null) {
+                        // No data available
+                        continue;
+                    }
 
+                    $rd->addTimeline($name, $timeline);
                     if (strpos($name, static::$hostServiceSeparator) !== false) {
                         list($host, $service) = Str::trimSplit($name, static::$hostServiceSeparator);
                         $row->display_name = $service;
@@ -317,7 +321,8 @@ protected function fetchInitialHardState(DateTime $start, string $hostId, string
                         $serviceFilter,
                         Filter::greaterThan('event_time', $start)
                     )
-                );
+                )
+                ->limit(1);
 
             $hardState = $hardState->first();
 

library/Icingadb/ProvidedHook/Reporting/HostSlaReport.php

@@ -31,12 +31,8 @@ protected function createReportData()
 
     protected function createReportRow($row)
     {
-        if ($row->sla === null) {
-            return null;
-        }
-
         return (new ReportRow())
             ->setDimensions([$row->display_name])
-            ->setValues([(float) $row->sla]);
+            ->setValues([$row->sla]);
     }
 }

library/Icingadb/ProvidedHook/Reporting/ServiceSlaReport.php

@@ -33,6 +33,6 @@ protected function createReportRow($row)
     {
         return (new ReportRow())
             ->setDimensions([$row->host_display_name, $row->display_name])
-            ->setValues([(float) $row->sla]);
+            ->setValues([$row->sla]);
     }
 }

library/Icingadb/ProvidedHook/Reporting/SlaReport.php

@@ -119,7 +119,10 @@ public function getHtml(Timerange $timerange, array $config = null)
             // We only have one metric
             $sla = $row->getValues()[0];
 
-            if ($sla < $threshold) {
+            if ($sla === null) {
+                $sla = 0;
+                $slaClass = 'unknown';
+            } elseif ($sla < $threshold) {
                 $slaClass = 'nok';
             } else {
                 $slaClass = 'ok';
@@ -132,7 +135,11 @@ public function getHtml(Timerange $timerange, array $config = null)
 
         // We only have one average
         $average = $data->getAverages()[0];
-        if ($average < $threshold) {
+
+        if ($average === null) {
+            $average = 0;
+            $slaClass = 'unknown';
+        } elseif ($average < $threshold) {
             $slaClass = 'nok';
         } else {
             $slaClass = 'ok';