Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatpickr not defined #36

Open
KaiMartin opened this issue Jul 29, 2020 · 6 comments · May be fixed by #41
Open

flatpickr not defined #36

KaiMartin opened this issue Jul 29, 2020 · 6 comments · May be fixed by #41

Comments

@KaiMartin
Copy link

With the Argon template enabled I see the following error message in the javacript console of firefox:

ReferenceError: flatpickr is not defined.

This message appears for every page of my wiki. I do not see this error message with any of the other templates I have installed (dokuwiki, material, writr).
I have yet to spot a specific failure due to this error. flatpickr seems to be related to time and date. The date in the list of old revisions seems to be fine, though.

All the best,
---<)kaimartin(>---

@lpaulsen93
Copy link

I am also seeing this error and I assume that the Java-Script error causes the side effect that some plugins might not work, e.g. dokufreaks/plugin-folded#68.

@SoarinFerret
Copy link
Contributor

@lpaulsen93 I doubt that this is effecting the other plugins like folded, because this library is very specific to datetime pickers. I wrote a patch to include flatpickr though, you are more than welcome to test that branch out and see if it helps

@lpaulsen93
Copy link

@SoarinFerret 👍 Thanks for the quick fix. Don't get me wrong. I don't think that other plugins like folded use the datetime pickers themselves but won't the error prevent other JavaScript code from being executed/loaded?

Aynway, I will test as soon as I got time for it.

@lpaulsen93
Copy link

@SoarinFerret You are right. The flatpickr error message is gone but the folded plugin issue is still there.

@SoarinFerret
Copy link
Contributor

@lpaulsen93 I may try and take a crack at getting the folded plugin issues fixed this week if I get time. I appreciate you taking an initial look for me!

@SoarinFerret
Copy link
Contributor

@lpaulsen93 totally just saw you put in a pull request, nevermind!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants