Incorrect HTTP response codes.

[andacata]

The HTTP response code is automated based on the OCPI response code:

ocpi-toolkit/ocpi-toolkit-2.2.1/src/main/kotlin/com/izivia/ocpi/toolkit/common/OcpiResponseBody.kt

Lines 124 to 128 in 4642efb

	status = when (ocpiResponseBody.status_code) {
	OcpiStatus.SUCCESS.code -> if (ocpiResponseBody.data != null) HttpStatus.OK else HttpStatus.NOT_FOUND
	OcpiStatus.CLIENT_INVALID_PARAMETERS.code -> HttpStatus.BAD_REQUEST
	else -> HttpStatus.INTERNAL_SERVER_ERROR
	},

Currently, the code returned is HTTP 500 on any response that is not SUCCESS or CLIENT_INVALID_PARAMETERS. So returning any of the other OCPI errors will result in an HTTP 500 error.

The documentation states that

If a request is syntactically valid JSON and addresses an existing resource, a HTTP error MUST NOT be returned. Those requests are supposed to have reached the OCPI layer.

so all these responses should be and HTTP 200.

I've asked for my thoughts on this in the OCPI Slack: https://ocpi.slack.com/archives/C0S64NZJQ/p1707299786355599
and confirmed by one of the authors of the OCPI documentation 😅

Maybe related with #65

[lilgallon]

Indeed, this code has to be updated to return 200 instead of 500. Concerning #65, I think that it should be fixed separately