Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element IDs are not unique (IU Accessibility Mandate) #140

Open
1 task done
mdalmau opened this issue Feb 20, 2024 · 6 comments
Open
1 task done

Element IDs are not unique (IU Accessibility Mandate) #140

mdalmau opened this issue Feb 20, 2024 · 6 comments
Assignees

Comments

@mdalmau
Copy link
Collaborator

mdalmau commented Feb 20, 2024

This may be a more complex developer issue. IDs generated in the HTML are repeated and IDs should be unique.
2,986 occurrences


IU has a mandate that all web sites published on IU servers must meet WCAG I and II Accessibility requirements. If the requirements are NOT met, sites will be taken down. To learn more about this initiative, visit the Digital Strategy Initiative web site.

  • Ask Bill who should be added to the SiteImprove tool
@mdalmau mdalmau assigned mdalmau and tubesoft and unassigned mdalmau and tubesoft Feb 20, 2024
@mdalmau
Copy link
Collaborator Author

mdalmau commented Feb 20, 2024

@tubesoft : At the Newton meeting today, Bill said you would be working on these accessibility issues. I requested SiteImprove access for you. Once you have access, you will login using your @iu credentials. If you want to read more about SIteImprove and accessibility, LOGIN to the KB and start here.

Could you have a look at this issue and confirm it's something you can fix? Once you confirm, we can figure out a testing workflow.

PS This one might be more complicated. If it's not clear how to fix this, let me know ASAP and we will work on Plan B.

@tubesoft
Copy link
Collaborator

I think this comes from TEI coding. @xml:id is copied to @id in html. I think change the TEI code should work. For example adding the document number to the folio number should work. (From id="thirtythreer-ref-1" to id="ALCH00034-thirtythreer-ref-1")

TEI:
image

Rendered:
image

@mdalmau
Copy link
Collaborator Author

mdalmau commented Feb 26, 2024

@tubesoft : Is this something that needs to be batch updated in the TEI files?

@tubesoft
Copy link
Collaborator

@mdalmau I think so. Just adding the ALCH number to the beginning of the id would work.

@mdalmau
Copy link
Collaborator Author

mdalmau commented Feb 27, 2024

@tubesoft : I am going to need you to talk me through this issue. I am not sure I fully understand. I'll follow-up over email to schedule a 30 min meeting with you and probably @aewingate too. Alex is pretty familiar with the encoding conventions from updating the encoding guide + all the bibl encoding. I just want to make sure that changing the ID values do not impact something else.

@aewingate
Copy link
Collaborator

@tubesoft and @mdalmau, I think that as long as the xml:id and anywhere it is referenced with the "#" change, we're okay. But happy to sit in on whatever meeting. And then I can make changes in the encoding guide as needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants