Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thirdpartyemailpassword addition #4

Open
kubeworkz opened this issue Oct 4, 2022 · 4 comments
Open

thirdpartyemailpassword addition #4

kubeworkz opened this issue Oct 4, 2022 · 4 comments

Comments

@kubeworkz
Copy link

I'm want to add the thirdpartyemailpassword recipe. Where's a good place to start? Cheers, Dave

@ITenthusiasm
Copy link
Owner

Hey @kubeworkz. Appreciate your eagerness to contribute!

When I first wrote the code for this repo, I didn't have the idea of exemplifying multiple recipes in mind. (I also didn't expect contributors. 😅) So I think we'll need to figure out the best way to organize this repository to handle different examples before adding too many.

If we're going to prepare for this, there's also some general cleaning up to do. I need to update some TS types (the app itself still runs fine). I'd also probably need to pull all of the react-hook-form stuff into its own "example section". Same with the useFormLocalStorage logic. This will help minimize any confusion or distractions for people trying to get the basic setup up and running.


After the repo is reorganized to handle different examples, we could just add an "example section" for ThirdPartyEmailPassword. I'm assuming most of the code would look the same as the regular EmailPassword recipe. Most of the changes would probably be in server.js. We should, of course, exclude react-hook-form (and similar unnecessary logic) from any new recipes in order to keep things simple for readers.

@kubeworkz
Copy link
Author

Thanks for the input. Sounds like a solid initial approach. I'll do some noodling on this.

@kubeworkz
Copy link
Author

kubeworkz commented Oct 5, 2022

Here's an attempt I made by generating a project from supertokens-auth-react example: thirdpartyemailpassword => backend node / frontend react and converting the frontend to Remix.

It has an issue running: {getSuperTokensRoutesForReactRouterDom(require("react-router-dom"))} in the root.tsx file. I don't think Supertokens.init is getting initialized.
new-app.tar.gz

@ITenthusiasm
Copy link
Owner

Thanks for putting progress towards this! Sorry for these late responses. Life is a bit busy on my end between work and church life. But as I get opportunity, I'll try to stay in contact. (I'll at least try not to let a week go by at a time. 😬)

Are you able to display these examples through some kind of PR or Fork? I think that would make review a little easier/faster since there wouldn't be a need to download and unzip a file. (Plus it would have more immediate visibility for others.) If you need any help with that, feel free to let me know.

Since we're using Remix, I actually think we should be able to avoid using supertokens-auth-react, supertokens-website, and the like. We should only need the backend in order to perform authentication/authorization. Were you able to see that functionality from the existing example in this codebase? (I hope so; if not, then I've broken something 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants