Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fixes raises when stopping log fetching in dynamic-sidecar #7302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🐛 Fixes raises when stopping log fetching in dynamic-sidecar #7302

wants to merge 1 commit into from
+7 −7

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Mar 4, 2025 •
edited
Loading

What do these changes do?

Sometimes the docker engine will raise TimeoutError when awaiting the log fetching task in the background. These can be safely ignore and avoids errors when soothing down the user services.

Related issue/s

How to test

Dev-ops checklist

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@GitHK GitHK self-assigned this Mar 4, 2025
@GitHK GitHK added bug buggy, it does not work as expected a:dynamic-sidecar dynamic-sidecar service labels Mar 4, 2025
@GitHK GitHK added this to the The Awakening milestone Mar 4, 2025
@GitHK GitHK marked this pull request as ready for review March 4, 2025 09:27
pcrespov
pcrespov approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/docker_logs.py
@@ -85,7 +85,7 @@ async def stop_log_fetching(self, container_name: str) -> None:
return

task.cancel()
with suppress(CancelledError):
with suppress(CancelledError, TimeoutError):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add your justification here "Sometimes the docker engine will raise TimeoutError when awaiting the log fetching task in the background"

@codecov Codecov
Copy link

codecov bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.71%. Comparing base (27f40cc) to head (5f7c73d).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (27f40cc) and HEAD (5f7c73d). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (27f40cc) HEAD (5f7c73d)
unittests 30 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #7302       +/-   ##
===========================================
- Coverage   87.14%   67.71%   -19.43%     
===========================================
  Files        1690      656     -1034     
  Lines       65633    31450    -34183     
  Branches     1121      168      -953     
===========================================
- Hits        57193    21295    -35898     
- Misses       8120    10097     +1977     
+ Partials      320       58      -262
Flag Coverage Δ
integrationtests 65.47% <66.66%> (+0.09%) ⬆️
unittests 88.66% <100.00%> (+2.37%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.99% <ø> (-12.32%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.74% <100.00%> (+<0.01%) ⬆️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.33% <ø> (-25.92%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f40cc...5f7c73d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

Assignees

@GitHK GitHK

Labels
a:dynamic-sidecar dynamic-sidecar service bug buggy, it does not work as expected
Projects
None yet
Milestone
The Awakening
Development

Successfully merging this pull request may close these issues.

dynamic-sidecar times out and raises occasionally error when calling stop_log_fetching
4 participants
@GitHK @pcrespov @sanderegg @matusdrobuliak66